From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6U/lMpsUvGoTjxkAWB0awg (envelope-from ) for ; Tue, 29 Sep 2026 15:42:19 -0400 Received: by simark.ca (Postfix, from userid 112) id CD0E11E051; Tue, 29 Sep 2026 15:42:19 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 58CA31E01F for ; Tue, 29 Sep 2026 15:42:19 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 921084B9DB61 for ; Tue, 29 Sep 2026 19:42:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 921084B9DB61 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 6D4D54BA23DB for ; Tue, 29 Sep 2026 19:41:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6D4D54BA23DB Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6D4D54BA23DB Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790710884; cv=none; b=c9RLegQBQO2DinqnINuzCf5Mn/q4SHrJr32PHTtLkvrt18VxH5IFaSy5twQN2agV8flTVuvIkcye0bThpqcGFPw4VoniybHK6SZD1WmSaKx65FT7hW0w/TV+f1lYQJiwEgbQRiAo8U4IZk6b53LCiY+hY9OhbORZer6F3MMXzqg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790710884; c=relaxed/simple; bh=S/7a+55wAoUe5cq7V2rwKEmiwqno5tMwNgI00VetiT8=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=IGxtrVR2Ik7a9RjPmQDkw0QQvBP6PPRJBe/M6l48g23y4uM2plu8P8mfDbX0fMI32pEEV5mq9975QIV9/Lpga6JE0CNijocVoGMX6KCxfBmIoqG+7Twq212qPHrCTDs3PMBP0xcRt7IYOklcykgbUg2LmQisdfq3Sj3gvZyLRiM= ARC-Authentication-Results: i=1; sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6D4D54BA23DB Received: by simark.ca (Postfix) id 439661E0BC; Tue, 29 Sep 2026 15:41:23 -0400 (EDT) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 6/9] gdb: update comment of global_symbol_searcher::expand_symtabs Date: Tue, 29 Sep 2026 15:39:27 -0400 Message-ID: <20260929194119.155169-7-simon.marchi@efficios.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260929194119.155169-1-simon.marchi@efficios.com> References: <20260929194119.155169-1-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Update the comment of expand_symtabs to describe more accurately what the return value means. It is true when a matching function msymbol for which no debug info exists is found. Change-Id: I7c26c065b31575066ed2398563cdc1dac8869f8b --- gdb/symtab.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gdb/symtab.h b/gdb/symtab.h index 50d7000681df..acbe41d131b7 100644 --- a/gdb/symtab.h +++ b/gdb/symtab.h @@ -2676,8 +2676,9 @@ class global_symbol_searcher std::optional compile_type_regex () const; /* Expand symtabs in OBJFILE that match NAME_REGEX, are of type M_KIND. - Return true if any msymbols were seen that we should later consider - adding to the results list. */ + Return true if a matching function msymbol without debug info was + seen, meaning that msymbols should later be considered for the results + list. */ bool expand_symtabs (objfile *objfile, const std::optional &name_regex) const; -- 2.55.0