From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4aFlJ/MUvGoGjxkAWB0awg (envelope-from ) for ; Tue, 29 Sep 2026 15:43:47 -0400 Received: by simark.ca (Postfix, from userid 112) id 9A8761E01F; Tue, 29 Sep 2026 15:43:47 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 03D6D1E01F for ; Tue, 29 Sep 2026 15:43:47 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 90F9F4BA9004 for ; Tue, 29 Sep 2026 19:43:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 90F9F4BA9004 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id DB3854BA23C0 for ; Tue, 29 Sep 2026 19:43:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DB3854BA23C0 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DB3854BA23C0 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790711004; cv=none; b=ts6GIeR7zo30gdyKXPq6LiO1E3iLwTWr59Aa6YnfWIC5gZn0UzwKAfDeVDOxkKkTrwD2lDO9FLYqfggD6/sQnh9ilWxh3n9nwh4022+JqyWp+bfDk3s7CL3V+JT+WofbEmBGj5cLckw280OtaNgisP/y8suGOlRe/G++pB3L0N4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790711004; c=relaxed/simple; bh=LDcJAWJEnr8ZH/P04TFlfnQDynGWMD+9a+PG9ihcnl4=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=R9qlCfDokgh7Ey91DfD8z+PmhN1uVAmi0+KNJUzli7NAnClDWs9HWKghw2+YnybkyaVXAQq/eieTWZn9WMpdC5klT6AUmdOgfuCUBcuaHpv1o8nB5sfRBlGmF3oh37XtXWnRDN0rS5gLvbDrDQH45oMtZRPoO3G318Hh10ysWJc= ARC-Authentication-Results: i=1; sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DB3854BA23C0 Received: by simark.ca (Postfix) id 685F11E04E; Tue, 29 Sep 2026 15:43:24 -0400 (EDT) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 9/9] gdb: fix some comments in global_symbol_searcher Date: Tue, 29 Sep 2026 15:39:30 -0400 Message-ID: <20260929194119.155169-10-simon.marchi@efficios.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260929194119.155169-1-simon.marchi@efficios.com> References: <20260929194119.155169-1-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Fix a few comments in and around global_symbol_searcher: - The comment of global_symbol_searcher::m_exclude_minsyms refers to M_SYMBOL_REGEXP, which does not (or no longer) exist. It means M_SYMBOL_NAME_REGEXP. - The comment in global_symbol_searcher::add_matching_msymbols refers to find_pc_symtab, which does not exist anymore. The code calls find_compunit_symtab_for_pc. - The comment of global_symbol_searcher calls it a structure, but it is a class. Change-Id: I0ec18651688406bb525752a53b9558096a798aef --- gdb/symtab.c | 2 +- gdb/symtab.h | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/gdb/symtab.c b/gdb/symtab.c index 10a794004d33..611815a568d6 100644 --- a/gdb/symtab.c +++ b/gdb/symtab.c @@ -4944,7 +4944,7 @@ global_symbol_searcher::add_matching_msymbols continue; /* For functions we can do a quick check of whether the - symbol might be found via find_pc_symtab. */ + symbol might be found via find_compunit_symtab_for_pc. */ if (m_kind == symbol_search_kind::FUNCTION && (find_compunit_symtab_for_pc (msymbol->value_address (objfile)) != NULL)) diff --git a/gdb/symtab.h b/gdb/symtab.h index e382b64b427c..1d92907fce2c 100644 --- a/gdb/symtab.h +++ b/gdb/symtab.h @@ -2604,8 +2604,8 @@ enum class symbol_search_kind }; /* In order to search for global symbols of a particular kind matching - particular regular expressions, create an instance of this structure and - call the SEARCH member function. */ + particular regular expressions, create an instance of this class and call + the SEARCH member function. */ class global_symbol_searcher { public: @@ -2661,8 +2661,8 @@ class global_symbol_searcher /* Regular expression to match against the symbol type. */ const char *m_symbol_type_regexp = nullptr; - /* When this flag is false then minsyms that match M_SYMBOL_REGEXP will - be included in the results, otherwise they are excluded. */ + /* When this flag is false then minsyms that match M_SYMBOL_NAME_REGEXP + will be included in the results, otherwise they are excluded. */ bool m_exclude_minsyms = false; /* Maximum number of search results. We currently impose a hard limit -- 2.55.0