From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id zelsM3wUvGoTjxkAWB0awg (envelope-from ) for ; Tue, 29 Sep 2026 15:41:48 -0400 Received: by simark.ca (Postfix, from userid 112) id 91CEF1E01F; Tue, 29 Sep 2026 15:41:48 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 44CB01E01F for ; Tue, 29 Sep 2026 15:41:46 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0B7704BA23C0 for ; Tue, 29 Sep 2026 19:41:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0B7704BA23C0 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 0A4FF4BA2E18 for ; Tue, 29 Sep 2026 19:41:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0A4FF4BA2E18 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0A4FF4BA2E18 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790710882; cv=none; b=YxgIpPmvG8LrdLyOvRAH2niCdbJOy/+WVdMpmqK0/D7ObCN5cTJSTwnqlo2p909sFMws/kVYX8r7G6a9ppBA6oRlmTrCBV81QZNOiAn8hgUj4lpE0e0zDHMTaw/kq75tPjm53+7n9d7KpMzIsJdSGyNJd+efKiEsctdHbR950U8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790710882; c=relaxed/simple; bh=QyYe0waLi82bxO6WXcXTDKmdI6TA4eJItIFbb5tecdM=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=ErpwQYKp+rkL4fK53SeKFjUbHyt7VPhT1HEBLrtwLzX4VyGl1kAV9Xrq/5OkIU3P5Lhdyi0jxDREH/wPLleMwuR1YGLPr1t1uYm/HtjxpdbdVB6GQXZSBP2V/DaSrJRSS4pLZ5sB4tmUTZHQbVMWLMY/ei2V5AQfVXGnToZFTpk= ARC-Authentication-Results: i=1; sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0A4FF4BA2E18 Received: by simark.ca (Postfix) id B21431E01F; Tue, 29 Sep 2026 15:41:20 -0400 (EDT) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 0/9] Cleanups in global_symbol_searcher Date: Tue, 29 Sep 2026 15:39:21 -0400 Message-ID: <20260929194119.155169-1-simon.marchi@efficios.com> X-Mailer: git-send-email 2.55.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I had a look at global_symbol_searcher while reviewing a recent patch, and I had a bit of trouble understanding how it worked. I made a few changes to try to make it clearer. Simon Marchi (9): gdb: add symbol_search_kind enum for global_symbol_searcher gdb: factor out regexp compilation from global_symbol_searcher::search gdb: simplify insertion in global_symbol_searcher::add_matching_symbols gdb: use a switch on m_kind in add_matching_symbols gdb: make global_symbol_searcher::is_suitable_msymbol non-static gdb: update comment of global_symbol_searcher::expand_symtabs gdb: add matching helpers to global_symbol_searcher gdb: pass result containers by reference in global_symbol_searcher gdb: fix some comments in global_symbol_searcher gdb/mi/mi-symbol-cmds.c | 36 ++-- gdb/python/python.c | 2 +- gdb/symtab.c | 458 +++++++++++++++++++++++----------------- gdb/symtab.h | 105 +++++---- 4 files changed, 348 insertions(+), 253 deletions(-) base-commit: ccf0f68e72ea0a5628097b980a04e1a8262781df -- 2.55.0