Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [pushed] [gdb/testsuite] Reformat gdb.ada
Date: Tue, 29 Sep 2026 15:13:31 +0200	[thread overview]
Message-ID: <20260929131333.1959170-1-tdevries@suse.de> (raw)

Reformat gdb.ada using emacs, and revert the parts where it messes with
indentation of comments blocks due to trailing backslash.

See here [1] for an earlier attempt as part of an RFC series introducing a
pre-commit hook indent-exp.

The change results in excessive indentation in gdb.ada/var_shadowing.exp.
Manually fix this using:
...
-gdb_test "info locals" [multi_line \
+gdb_test "info locals" \
+    [multi_line \
...
and reformat the same test to be more typical.

[1] https://sourceware.org/pipermail/gdb-patches/2026-September/230045.html
---
 gdb/testsuite/gdb.ada/non-ascii-latin-3.exp |  2 +-
 gdb/testsuite/gdb.ada/ptype_field.exp       |  6 +++---
 gdb/testsuite/gdb.ada/var_shadowing.exp     | 16 +++++++++-------
 3 files changed, 13 insertions(+), 11 deletions(-)

diff --git a/gdb/testsuite/gdb.ada/non-ascii-latin-3.exp b/gdb/testsuite/gdb.ada/non-ascii-latin-3.exp
index fd4cd5f064c..8dd422cfb7b 100644
--- a/gdb/testsuite/gdb.ada/non-ascii-latin-3.exp
+++ b/gdb/testsuite/gdb.ada/non-ascii-latin-3.exp
@@ -67,4 +67,4 @@ gdb_test break_2 "Breakpoint $decimal .*" \
     "gdb_breakpoint: set breakpoint at func_ż"
 
 gdb_test print_3 "warning: charset conversion failure.*" \
-     "print var_𝕯"
+    "print var_𝕯"
diff --git a/gdb/testsuite/gdb.ada/ptype_field.exp b/gdb/testsuite/gdb.ada/ptype_field.exp
index e808b8492bb..1776742120d 100644
--- a/gdb/testsuite/gdb.ada/ptype_field.exp
+++ b/gdb/testsuite/gdb.ada/ptype_field.exp
@@ -65,9 +65,9 @@ gdb_test "complete ptype pck.c" "ptype pck\\.circle"
 # We can't query the members of a package yet, and this yields a bit
 # too much output, so comment out for now instead of kfailing.
 # gdb_test "complete ptype pck." \
-    #     [multi_line \
-    # 	 "ptype pck\\.circle" \
-    # 	 "ptype pck\\.position"]
+#     [multi_line \
+# 	 "ptype pck\\.circle" \
+# 	 "ptype pck\\.position"]
 
 gdb_test "complete ptype circle.pos." \
     [multi_line \
diff --git a/gdb/testsuite/gdb.ada/var_shadowing.exp b/gdb/testsuite/gdb.ada/var_shadowing.exp
index 034febd22bd..f0ec2dd918b 100644
--- a/gdb/testsuite/gdb.ada/var_shadowing.exp
+++ b/gdb/testsuite/gdb.ada/var_shadowing.exp
@@ -20,7 +20,7 @@ require allow_ada_tests
 standard_ada_testfile var_shadowing
 
 if {[gdb_compile_ada "${srcfile}" "${binfile}" \
-    executable [list debug]] != "" } {
+	 executable [list debug]] != "" } {
     return
 }
 
@@ -32,9 +32,11 @@ set i_level3 [gdb_get_line_number "I-Level3"]
 set bp_location [gdb_get_line_number "BREAK"]
 runto "var_shadowing.adb:$bp_location"
 
-gdb_test "info locals" [multi_line \
-    "i = 111\t<$testfile.adb:$i_level3>"  \
-    "i = 11\t<$testfile.adb:$i_level2, shadowed>"  \
-    "i = 1\t<$testfile.adb:$i_level1, shadowed>"  \
-    "Use \"set print shadowed off\" to hide shadowed variables." \
-] "info locals at innermost level"
+gdb_test "info locals" \
+    [multi_line \
+	 "i = 111\t<$testfile.adb:$i_level3>"  \
+	 "i = 11\t<$testfile.adb:$i_level2, shadowed>"  \
+	 "i = 1\t<$testfile.adb:$i_level1, shadowed>"  \
+	 [string_to_regexp \
+	      {Use "set print shadowed off" to hide shadowed variables.}]] \
+    "info locals at innermost level"

base-commit: 4ba6bd8393418b63dc3efa0ec6f934903a10f140
-- 
2.51.0


                 reply	other threads:[~2026-09-29 13:14 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260929131333.1959170-1-tdevries@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox