From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id XOjENpWcu2p1EhcAWB0awg (envelope-from ) for ; Tue, 29 Sep 2026 07:10:13 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Cz6Eu525; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=GX4NmdTe; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=pYrzaLsY; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=xvyRzI4c; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id CD5961E033; Tue, 29 Sep 2026 07:10:13 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D71331E033 for ; Tue, 29 Sep 2026 07:10:12 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3EE1A4BB24CF for ; Tue, 29 Sep 2026 11:10:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3EE1A4BB24CF Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Cz6Eu525; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=GX4NmdTe; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=pYrzaLsY; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=xvyRzI4c Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 435C94BB1C3B for ; Tue, 29 Sep 2026 11:09:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 435C94BB1C3B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 435C94BB1C3B Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790680172; cv=none; b=eld6qWWNOLu7HGEZQJHoX3CsN7NMi/HwgKQkUVHppAnLIkKjHMmk2BUoDW0zSDo6Cj90bWwUz7mwLwgipwysnh31CfmOS9d/nYmCTrG4Et0ii/SlZZT+hRlUVQWR/qA3sCT2vmU//urv13mtNNt/s6uN7E/e3/W1jAFeWhnx9zQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790680172; c=relaxed/simple; bh=lBXHKgZDTQN/5t9sHgsQU33r9wWIZKngcxD14z0n92g=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=G8bkeOABlChuF/ttZdZCWGhjkIIFviB9q52uEqzsxf3Kwzvi0nH7tqmUjSxrIx4UyEpYQDOvDNSRcVYY/Aq9AWZ3lRz9C+qIZmpxXd8EupG14tTUCC9+ksMzvgaCjK8AFp51EQpsrr+JZNvu7cphYJsTiF5le16DTW3dXFP3wSI= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Cz6Eu525; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=GX4NmdTe; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=pYrzaLsY; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=xvyRzI4c DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 435C94BB1C3B Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 94DAA21C42 for ; Tue, 29 Sep 2026 11:09:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1790680166; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oKhCBvrKm14LVr1NglQ7hKHGwA2zZNL5NHNIB/mUXS4=; b=Cz6Eu525OEraJ+M8l+c8D3fmm90bQlIGXghq0kbjGC1OwSUpKWHXa8ALOmoiGIvWXjbW+u 34GC8Pj9Z2EbbTZwR/ljHnRDON5NAdsplhSC0UFkv2NECH/Llu4qCqjsridwDGOpKvC+Rg cNBxYtO6ITi9KkGgVA/EbbNxhB+LN8Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1790680166; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oKhCBvrKm14LVr1NglQ7hKHGwA2zZNL5NHNIB/mUXS4=; b=GX4NmdTe6OL1dKd89gzqgRI0Ij0Q+FUlmjpUdOfOPuzASbQ+0PB2CCHs3RbGOHloYCLtBZ p9HpkCM0hLsnzRAA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=pYrzaLsY; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=xvyRzI4c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1790680162; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oKhCBvrKm14LVr1NglQ7hKHGwA2zZNL5NHNIB/mUXS4=; b=pYrzaLsYl/C3Ui1Ex6Th10ezaJmndOcokBdvNBXcMuh3ccazWGuHDdlOYhnSf9vgvytuFz JYkJBgI8cy5z93IPLERpPj+186O2w+TDCEBjgPjml5sFJ1UVm2bhu+WM99YWkbZub5RSAP FBl+OGkTDIc0Y+bZkjUxX5E3ongKcGU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1790680162; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oKhCBvrKm14LVr1NglQ7hKHGwA2zZNL5NHNIB/mUXS4=; b=xvyRzI4c5V1GTkbnP5U00/lOkuszzSVDqw/DTaEA/mBudN7tMeB477Q/JrxZU7PBEg70ik Aomph9+pDa6lpuDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5FF9E13722 for ; Tue, 29 Sep 2026 11:09:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id jiAQNGGcu2oIAgAAD6G6ig:T4 (envelope-from ) for ; Tue, 29 Sep 2026 11:09:22 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH v2 4/6] [gdb/testsuite] Only retry on EEXIST in lock_file_acquire Date: Tue, 29 Sep 2026 13:09:19 +0200 Message-ID: <20260929110921.1910094-4-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260929110921.1910094-1-tdevries@suse.de> References: <20260929110921.1910094-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-2.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; TO_DN_NONE(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-Rspamd-Queue-Id: 94DAA21C42 X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org It occurred to me that ignoring all errors in lock_file_acquire may be undesirable. Say you call lock_file_acquire with a lock file for which you have no permission. You'd get an EACCESS. It doesn't make sense to keep retrying on such an error. Instead, only retry on the error that indicates that the lock is taken: EEXIST. --- gdb/testsuite/lib/gdb-utils.exp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/lib/gdb-utils.exp b/gdb/testsuite/lib/gdb-utils.exp index 854496e9bb1..1277558170d 100644 --- a/gdb/testsuite/lib/gdb-utils.exp +++ b/gdb/testsuite/lib/gdb-utils.exp @@ -189,8 +189,8 @@ proc lock_file_acquire {lockfile} { while {![info exists fh]} { try { set fh [open $lockfile {WRONLY CREAT EXCL}] - } on error {} { - # Ignore and try again. + } trap "POSIX EEXIST" {} { + # Lock in use. Ignore and try again. Propagate all other errors. after 10 } } -- 2.51.0