From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QCJ7CzHGumpvchMAWB0awg (envelope-from ) for ; Mon, 28 Sep 2026 15:55:29 -0400 Received: by simark.ca (Postfix, from userid 112) id 07B3E1E01F; Mon, 28 Sep 2026 15:55:29 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 55C3F1E01F for ; Mon, 28 Sep 2026 15:55:28 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7BAAC4BAE7CF for ; Mon, 28 Sep 2026 19:55:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7BAAC4BAE7CF Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 5C2DD4B9DB62 for ; Mon, 28 Sep 2026 19:54:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5C2DD4B9DB62 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5C2DD4B9DB62 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790625299; cv=none; b=LjgQsAbersTRbyFKMtA6OYgfhrfJi6Yp4LmAqX2ftOSwWlgTPmxeuFE29RHGHIh7Bv5G7aKVyDuQ5+Jmcgy35+0yC4b9Hap5Kne8HfUXP1+P8r77OBP1fTFFXhzlrC1c1JsajxALiLpjWYr6X3gUGZlsIu2DEqxY/T+CqYuuUV4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790625299; c=relaxed/simple; bh=G6mLFOvr3uRnDiikMeUKPvZZsiMYjN89w1ojOKuAkZU=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=KTur8HcEwvSt+LfhI5sIJJqhMheeqz+7131oJV3nsRb118PgEmA5UZK4D9eE2ddYWJdZL/91mGrVuYzyLJI+QJfgApC2r3aOU4iBenfmHeAvJRWVkoUS3+tedbq1OojpBNBm6iJMb3FqSap01kqvcxznaNcwSHwWg0a+KZO+mZU= ARC-Authentication-Results: i=1; sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5C2DD4B9DB62 Received: by simark.ca (Postfix) id 8F1A71E01F; Mon, 28 Sep 2026 15:54:57 -0400 (EDT) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH] gdb: make "stop-on-solib-events" a boolean setting Date: Mon, 28 Sep 2026 15:54:54 -0400 Message-ID: <20260928195456.557337-1-simon.marchi@efficios.com> X-Mailer: git-send-email 2.55.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org While reviewing a patch, I noticed that the "stop-on-solib-events" setting was an integer, even though it is spiritually a boolean. It has been an integer since it was introduced in commit 87273c713f0e (1996-01-23). Make it a boolean setting. User-visible improvements: - The setting accepts the usual boolean values: on/off, yes/no, enable/disable, as well as 1/0. - "set stop-on-solib-events" with no argument now turns the setting on, like other boolean settings, instead of erroring out with "Argument required (integer to set it to)". - Tab completion offers "on" and "off". - "show stop-on-solib-events" prints "on" or "off" instead of a number. Possible breaking changes: - Integer values other than 0 and 1, as well as expressions (for instance "set stop-on-solib-events $var"), are now rejected with an error. - The CLI and MI output changes from: (gdb) show stop-on-solib-events Stopping for shared library events is 0. (gdb) interpreter-exec mi "-gdb-show stop-on-solib-events" ^done,value="0" (gdb) print $_gdb_setting_str("stop-on-solib-events") $1 = "0" to: (gdb) show stop-on-solib-events Stopping for shared library events is off. (gdb) interpreter-exec mi "-gdb-show stop-on-solib-events" ^done,value="off" (gdb) print $_gdb_setting_str("stop-on-solib-events") $1 = "off" - The Python gdb.parameter("stop-on-solib-events") function now returns True or False instead of an integer. The Guile equivalent now returns #t or #f. I think that all these observable changes are relatively easy to work around. Add a NEWS entry for the change and update the documentation. Change-Id: Ia792b172cd6da810de208446447dc78a2e47b09d --- gdb/NEWS | 6 ++++++ gdb/breakpoint.c | 4 ++-- gdb/doc/gdb.texinfo | 2 +- gdb/infrun.c | 16 ++++++++-------- gdb/infrun.h | 4 ++-- 5 files changed, 19 insertions(+), 13 deletions(-) diff --git a/gdb/NEWS b/gdb/NEWS index 77ad2d3fc22c..af85dac6665d 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -51,6 +51,12 @@ show print shadowed * Changed commands +set stop-on-solib-events on|off +show stop-on-solib-events + This setting is now a boolean. Previously, it was an integer, where + any non-zero value meant "on". The values 0 and 1 are still + accepted. + info locals The new "-shadowed on|off" option overrides the "set print shadowed" setting for a single invocation of the command. diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 988737b6f96f..69b9b47276b0 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -12236,8 +12236,8 @@ internal_breakpoint::check_status (bpstat *bs) events. This allows the user to get control and place breakpoints in initializer routines for dynamically loaded objects (among other things). */ - bs->stop = stop_on_solib_events != 0; - bs->print = stop_on_solib_events != 0; + bs->stop = stop_on_solib_events; + bs->print = stop_on_solib_events; } else bs->stop = false; diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index a24f67cb8de1..5cfbad231402 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -22510,7 +22510,7 @@ The surrounding square brackets are optional. @end table @table @code -@item set stop-on-solib-events +@item set stop-on-solib-events [on|off] @kindex set stop-on-solib-events This command controls whether @value{GDBN} should give you control when the dynamic linker notifies it about some shared library event. diff --git a/gdb/infrun.c b/gdb/infrun.c index 3fbfeff9269d..59c25259fd52 100644 --- a/gdb/infrun.c +++ b/gdb/infrun.c @@ -413,9 +413,9 @@ get_detach_signal (process_stratum_target *proc_target, ptid_t ptid) static struct cmd_list_element *stop_command; -/* Nonzero if we want to give control to the user when we're notified +/* True if we want to give control to the user when we're notified of shared library events by the dynamic linker. */ -int stop_on_solib_events; +bool stop_on_solib_events; /* Enable or disable optional shared library event breakpoints as appropriate when the above flag is changed. */ @@ -10846,16 +10846,16 @@ leave it stopped or free to run as needed."), /* Update cached state. */ signal_cache_update (-1); - add_setshow_zinteger_cmd ("stop-on-solib-events", class_support, - &stop_on_solib_events, _("\ + add_setshow_boolean_cmd ("stop-on-solib-events", class_support, + &stop_on_solib_events, _("\ Set stopping for shared library events."), _("\ Show stopping for shared library events."), _("\ -If nonzero, gdb will give control to the user when the dynamic linker\n\ +If on, gdb will give control to the user when the dynamic linker\n\ notifies gdb of shared library events. The most common event of interest\n\ to the user would be loading/unloading of a new library."), - set_stop_on_solib_events, - show_stop_on_solib_events, - &setlist, &showlist); + set_stop_on_solib_events, + show_stop_on_solib_events, + &setlist, &showlist); add_setshow_enum_cmd ("follow-fork-mode", class_run, follow_fork_mode_kind_names, diff --git a/gdb/infrun.h b/gdb/infrun.h index cbc603b74edd..7b2b882dc9ad 100644 --- a/gdb/infrun.h +++ b/gdb/infrun.h @@ -75,9 +75,9 @@ infrun_debug_show_threads (const char *title, ThreadRange threads) } -/* Nonzero if we want to give control to the user when we're notified +/* True if we want to give control to the user when we're notified of shared library events by the dynamic linker. */ -extern int stop_on_solib_events; +extern bool stop_on_solib_events; /* True if execution commands resume all threads of all processes by default; otherwise, resume only threads of the current inferior base-commit: 421bec796fa3a06179856da870a13cf71ddf5df2 -- 2.55.0