From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AXmgHS/hsmrKJjQAWB0awg (envelope-from ) for ; Tue, 22 Sep 2026 16:12:31 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=PfKCuYgY; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 744F51E06B; Tue, 22 Sep 2026 16:12:31 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C264D1E01F for ; Tue, 22 Sep 2026 16:12:30 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 83A484BAE7F8 for ; Tue, 22 Sep 2026 20:12:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 83A484BAE7F8 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=PfKCuYgY Received: from mail-oi2-x0f.google.com (mail-oi2-x0f.google.com [IPv6:2607:f8b0:4864:32::f]) by sourceware.org (Postfix) with ESMTPS id 84B824BA900A for ; Tue, 22 Sep 2026 20:12:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 84B824BA900A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 84B824BA900A Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:32::f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790107925; cv=none; b=HOuHFNBxprf2loxzXvcKGWKFA3tTODR+UPNotLZIqP/RV49Q0glBI2Hr6e1grY6zPyWe6MyHm+h8wBDAA0E1k/47r7KrgdMU+G7RtJ+aexI/6LIoy+059xSkmfviU63lv2UGHIFPtRsYQM8LlgaEseqcfuAxJEY8xhd1pN9ygXg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790107925; c=relaxed/simple; bh=VfSvWbXqnyoYXprLBjsp3fMpp7ykHchCeAjMAWzP0tA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=uJSNZ7QdUGRjsV8QExJW1RRXpc+whvlq8OCdm50jwn9eZJpR26n5K58NajOkH4Lrqtgn/Qkw+2bfwZt1RHyMXX/ngzZG9QijLfyaEUqycpGZk0TRG/oYrezvgZdSFpCC9PGd2Mh2OHRsQXFp7V8WrkYHpUXJJeQRY6zJw+BB+mw= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=PfKCuYgY DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 84B824BA900A Received: by mail-oi2-x0f.google.com with SMTP id 46e09a7af769-7f4f0d1779dso295511a34.2 for ; Tue, 22 Sep 2026 13:12:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1790107925; x=1790712725; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=pcTdKcvh6ce/ZE4PAv3d1tFlRsPR9n3wOM+kvlvBv+c=; b=PfKCuYgYhuBKdfLC+UnIEpWWcTvaQHRnRjouDL2wT1nb5c4G12lOejXPp1Such3owU HiiQjjPUO4yUOiNSDpFE3u/j3plHwipFQhQUKkvA7fuP63ZGyOj/G0xVqZwKBwfqKRLP vsDFNan1J9ZPmR6OJQbshK/hMcZDMtxxDnalg5ekpxJ/3ESoK5QzSJE32t+BvjjdESEt NkypfOqawlSghko9zGFCEX0EQB9UbQyUqMgtIDHym79HxJd7CMRc9U2hHkVewdfBoKYr 3PMoW5KOiMnlBUoc1RqnPuzkvuxzbTKZtXFpvQMFAsb0+zqugZoZgZZUPpWSpOM2yE97 sc8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790107925; x=1790712725; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=pcTdKcvh6ce/ZE4PAv3d1tFlRsPR9n3wOM+kvlvBv+c=; b=JdcbEkQhptUwsETrZ6kJPGjaSyMs+I+f/zrJENVMw6dBU2h14h5SKMXqYblvmGfd7U wJYoJ+7ZU2Uy2Zmx7cip4Nn++RgsiL1v+U6G86UPYn7O8+eKXWgec029z9cf+7lYxw+y 8XpX8/W9HH0gndu6Uq19RPx0WQktOd7d6upL0n6JBTRp9/ao5RYGBOwDAIrWXMXOK6PL EwY5/o6cAUBfo/0FhV8XjGDZDhWyhHRy9rMyHxjA56OiELfVC5f+5jFak55Mw2yjzDMr UTj03u+ahMCka3Y/FyF188B0d5/OYck1d8LDqreK6WTdBVdUnjxSTK6K8D5hR00lBQXg 67lg== X-Gm-Message-State: AFuF++l4RlPcb5lMhRmeMwriYGusFSlg8T29Inq4OK/OnpKcNUIcOzts Sti0vpw1qeKQlV4bu0I3KPjBlMKABu/ADE7V6K3lKhkM32puYXVlsTltnW6B89rxxWv1oyPg6yg iE1+8Mw== X-Gm-Gg: AYBFou13YX7PTpIs8rtXI+3PGl+HRhSCEWS80T0D9nb/zeY+4dv9+ddtu3bg6vRlbRD qdc8HLv9mDU6+ZL185nvxG1GVPPg5mvNz3QrJ5tiZGXCYt25Rl0z3vFD5Ns0ZBMOXe5X5Qxf1sA rh2fuhL52kSF8hfLL4XCYTglMWYyQ2voH9Yz2QrNFpPcivRNHe0xPQrQllmFVyaR9UYc/MLpg7K wGjgImy+i/vnMTdt5R8J+QLStvpjhvPDwlAnWRnp/PJnbqlTJP0g5MA5oNtpjXzUAVxqGXpmUXa X454HbzIhuM4NlQgn8Ik9UVGXUj9i5hiK9E5vzAArRkfvZzeSZ4AzX7Gffo2bx4Qtv1x6y5zu2X FutUk6ORXGh0Q1zP5K9LWpC8A4UYkXac0UpUAzXFAGrh7I9M26acOgV1K/wIJgbTQY74zALdthO 0T1OS10s04a98lrdqDYG/XhYAEEuKJnKG+li7vDmdCdAAWgzrRO7xp/yTfIMtmThMK+DhJRZvwR 0eu+hgDv2jkmb0B7w== X-Received: by 2002:a05:6830:4ac5:b0:7eb:d848:c856 with SMTP id 46e09a7af769-815ee4a1ddbmr798361a34.4.1790107924832; Tue, 22 Sep 2026 13:12:04 -0700 (PDT) Received: from bapiya (75-166-229-74.hlrn.qwest.net. [75.166.229.74]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-81603ad2b19sm699435a34.4.2026.09.22.13.12.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Sep 2026 13:12:04 -0700 (PDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Add QUIT to inner loop in value_print_array_elements Date: Tue, 22 Sep 2026 14:12:02 -0600 Message-ID: <20260922201202.2189948-1-tromey@adacore.com> X-Mailer: git-send-email 2.55.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org When printing an array, some work is done to detect repeated elements. This work is not interruptible, and it is somewhat slow (see PR exp/32681). This patch adds QUITs to the relevant spots. I am not sure there is a way to write a non-racy test for this. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=17613 --- gdb/ada-valprint.c | 2 ++ gdb/f-valprint.c | 5 +++++ gdb/valprint.c | 2 ++ 3 files changed, 9 insertions(+) diff --git a/gdb/ada-valprint.c b/gdb/ada-valprint.c index d66f9f84d52..020478bdf40 100644 --- a/gdb/ada-valprint.c +++ b/gdb/ada-valprint.c @@ -183,6 +183,8 @@ val_print_packed_array_elements (struct type *type, const gdb_byte *valaddr, bitsize, elttype); while (1) { + QUIT; + /* Make sure to free any values in the inner loop. */ scoped_value_mark free_values; diff --git a/gdb/f-valprint.c b/gdb/f-valprint.c index d0b2030554f..2b54c8bf1c0 100644 --- a/gdb/f-valprint.c +++ b/gdb/f-valprint.c @@ -36,6 +36,7 @@ #include "cli/cli-style.h" #include "gdbarch.h" #include "f-array-walker.h" +#include "event-top.h" static void f77_get_dynamic_length_of_aggregate (struct type *); @@ -188,6 +189,8 @@ class fortran_array_printer_impl : public fortran_array_walker_base_impl struct type *elt_type, LONGEST elt_off, LONGEST index, bool last_p) { + QUIT; + size_t dim_indx = m_dimension - 1; struct type *elt_type_prev = m_elt_type_prev; LONGEST elt_off_prev = m_elt_off_prev; @@ -262,6 +265,8 @@ class fortran_array_printer_impl : public fortran_array_walker_base_impl LONGEST elt_off_prev = m_elt_off_prev; bool repeated = false; + QUIT; + if (m_options.repeat_count_threshold < UINT_MAX && elt_type_prev != nullptr) { diff --git a/gdb/valprint.c b/gdb/valprint.c index 83a442dcef5..7e41943f66f 100644 --- a/gdb/valprint.c +++ b/gdb/valprint.c @@ -2038,6 +2038,8 @@ value_print_array_elements (struct value *val, struct ui_file *stream, while (rep1 < len) { + QUIT; + /* When printing large arrays this spot is called frequently, so clean up temporary values asap to prevent allocating a large amount of them. */ base-commit: 123e4a5eab2db300b44288dcc1a29c903f9622f9 -- 2.55.0