From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gea+L45ssWp49C0AWB0awg (envelope-from ) for ; Mon, 21 Sep 2026 13:42:38 -0400 Received: by simark.ca (Postfix, from userid 112) id C08341E01F; Mon, 21 Sep 2026 13:42:38 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 413921E01F for ; Mon, 21 Sep 2026 13:42:38 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CF7734BA902B for ; Mon, 21 Sep 2026 17:42:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CF7734BA902B Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id E2F0C4BA7998; Mon, 21 Sep 2026 17:39:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E2F0C4BA7998 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E2F0C4BA7998 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790012395; cv=none; b=iFCrIiwt3dqeB/ITE4012gtBA7U5Q1ZElGh1EjbuFCA8mJzcPHFxbQ81Q2f+3YXGi+T/KZ+ndjgeGmCZyC0cOJJei9u1Az06xUwKIcLJe0TaHtgjB078BDTcjz6T3bENMN94cjE/rNAe8OMPYwgxt9+aMWXKIuDmsBVPhVD0xgA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790012395; c=relaxed/simple; bh=jOHDkC+Lko+ErMldIFE6Q6whHYGw6ZCd2cCDBa0VdYE=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=fBJJc2jLBIKNtpEGnbsgiOgnRBbocbFUgw1GJt/Fzq+373AasgbntQ2ZNag0IUwEkcpUpvnBazCU+XtTTHw3gmNL4qyytTKUFR8M5oZtd1IakKxbI/MXET7GNjyShEWqRzSBYfuQ3eEbOGfDPV7xKKZxbY5L/UHA+xC7HyOXC34= ARC-Authentication-Results: i=1; sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E2F0C4BA7998 Received: by simark.ca (Postfix) id 49FEC1E090; Mon, 21 Sep 2026 13:39:53 -0400 (EDT) From: Simon Marchi To: gdb-patches@sourceware.org, binutils@sourceware.org Cc: Simon Marchi Subject: [PATCH v2 3/4] gdb/dwarf: don't store segment_collector_size (sic) Date: Mon, 21 Sep 2026 13:39:43 -0400 Message-ID: <20260921173951.688121-4-simon.marchi@efficios.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260921173951.688121-1-simon.marchi@efficios.com> References: <20260921173951.688121-1-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I noticed that structure loclists_rnglists_header stored the segment selector size (which seems to be misspelled as "collector"). Nothing uses that, and it has even been removed from the DWARF 6 draft (it stays as a "reserved" field). Remove the structure field and simply skip it. There are other functions (read_addrmap_from_aranges and dwarf_decode_line_header) that do read it, only to validate that it's 0, but it didn't seem useful to me to add such a check here (we could even remove these other ones). Change-Id: If73f510398bef2cb1215ce7ec2e4e083d5a50697 --- gdb/dwarf2/read.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index c1454a664bef..2f38dfdaf970 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -238,10 +238,6 @@ struct loclists_rnglists_header the target system. */ unsigned char addr_size; - /* A 1-byte unsigned integer containing the size in bytes of a segment selector - on the target system. */ - unsigned char segment_collector_size; - /* A 4-byte count of the number of offsets that follow the header. */ unsigned int offset_entry_count; }; @@ -14098,7 +14094,7 @@ read_loclists_rnglists_header (struct loclists_rnglists_header *header, section->get_name (), header->addr_size, section->get_file_name ()); - header->segment_collector_size = read_1_byte (abfd, info_ptr); + /* Skip segment_selector_size. */ info_ptr += 1; header->offset_entry_count = read_4_bytes (abfd, info_ptr); -- 2.55.0