From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [PATCH 2/4] [gdb] Use SCOPE_EXIT in tfile_get_traceframe_address
Date: Sun, 20 Sep 2026 15:02:52 +0200 [thread overview]
Message-ID: <20260920130254.604592-3-tdevries@suse.de> (raw)
In-Reply-To: <20260920130254.604592-1-tdevries@suse.de>
Use SCOPE_EXIT in tfile_get_traceframe_address to protect a cleanup against
exceptions.
---
gdb/tracefile-tfile.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/gdb/tracefile-tfile.c b/gdb/tracefile-tfile.c
index 289e00ff531..83d863302f9 100644
--- a/gdb/tracefile-tfile.c
+++ b/gdb/tracefile-tfile.c
@@ -652,6 +652,12 @@ tfile_get_traceframe_address (off_t tframe_offset)
short tpnum;
struct tracepoint *tp;
off_t saved_offset = cur_offset;
+ SCOPE_EXIT
+ {
+ /* Restore our seek position. */
+ cur_offset = saved_offset;
+ lseek (trace_fd, cur_offset, SEEK_SET);
+ };
/* FIXME dig pc out of collected registers. */
@@ -667,9 +673,6 @@ tfile_get_traceframe_address (off_t tframe_offset)
if (tp != nullptr && tp->has_locations ())
addr = tp->first_loc ().address;
- /* Restore our seek position. */
- cur_offset = saved_offset;
- lseek (trace_fd, cur_offset, SEEK_SET);
return addr;
}
--
2.51.0
next prev parent reply other threads:[~2026-09-20 13:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-20 13:02 [PATCH 0/4] [gdb] Use c++-style cleanups a bit more Tom de Vries
2026-09-20 13:02 ` [PATCH 1/4] [gdb] Use make_scoped_restore in z80_read_overlay_region_table Tom de Vries
2026-09-20 13:02 ` Tom de Vries [this message]
2026-09-20 13:02 ` [PATCH 3/4] [gdb] Use make_scoped_restore in linespec_lexer_peek_token Tom de Vries
2026-09-20 13:02 ` [PATCH 4/4] [gdb] Use make_scoped_restore in captured_main_1 Tom de Vries
2026-09-22 19:37 ` [PATCH 0/4] [gdb] Use c++-style cleanups a bit more Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260920130254.604592-3-tdevries@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox