From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mZ7/LUFLrmqQ/B8AWB0awg (envelope-from ) for ; Sat, 19 Sep 2026 04:43:45 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=qxYY/8NI; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=PhS1cGX4; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=qhcu3eGP; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=03iMlbi/; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B8EA31E01F; Sat, 19 Sep 2026 04:43:45 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 524841E01F for ; Sat, 19 Sep 2026 04:43:45 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 311B64BB24EF for ; Sat, 19 Sep 2026 08:43:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 311B64BB24EF Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=qxYY/8NI; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=PhS1cGX4; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=qhcu3eGP; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=03iMlbi/ Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 4DA104BB1C10 for ; Sat, 19 Sep 2026 08:42:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4DA104BB1C10 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4DA104BB1C10 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789807369; cv=none; b=PyZCwblg61mJ5aVugCZMZ8lDChPKlOKB3Ql2Ku3MBRNugjBwIG2YsAmN8OGe63AONvxw1dguirUQ0WHj4sRzdGcHPVL00pIOzzbAvkthXAFv5ShhgWynmqS8ENCXT1llLyX9pdAPyq4IT6Ziijzd7fumbkw2V/Rf3PO4UBwmluA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789807369; c=relaxed/simple; bh=i+hZ8I2+OSlfrAvBdbHuCRy0wqRYBvkiBc2KXDxvt2A=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=qfQ84edEkmtoSZaEzKX7X/Z+zKjTUxcx61INqf2le20fEDxgVXnlRXVbnUmxXZ6BPUSsXAQUK+bVBFSLnSexdYCcSQk9kSTj59Or357xrHVAA2MtCfb143HodRFFJ1sZ896dERT61OuygI/bQdHgpKURVUd2QtzNbNyAMNBrq3I= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=qxYY/8NI; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=PhS1cGX4; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=qhcu3eGP; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=03iMlbi/ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4DA104BB1C10 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B280F21E77 for ; Sat, 19 Sep 2026 08:42:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1789807363; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B0RZiVdZBKQETt3xYfrSSwO37M1eFgXCgxwHmSecfyg=; b=qxYY/8NIdcWvFSDvrFjoohQiiaPDy6TkmacTpU29kJZhggWMmZS/Ly3EYfPYxz3+1IZ7/D kPZ6kmGxw93pSB+fCj09jeYX2abuDzftkh1f4T62HGBGYFJ5sWdx021F+sbob9HjNSU3fy TpFhBLMM77YUzw9XBym0fdcdtQaEFSE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1789807363; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B0RZiVdZBKQETt3xYfrSSwO37M1eFgXCgxwHmSecfyg=; b=PhS1cGX4EX6SGr52eylbRGWexEsmYUhHrvvAOLX9GHrIYoZFAUhW/ZQDmIlfu/RVHE+Err zMsXWZfiphpmDLBg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1789807359; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B0RZiVdZBKQETt3xYfrSSwO37M1eFgXCgxwHmSecfyg=; b=qhcu3eGPyAk/Wc5yqYusU6q0gOrCngXembeAEveNxvGr04L78F4fR7epj9qLP2cCGbzH+s 7+l2xnAyXcaLZq3yTVH8t3K3wN/FMwPF63ltDiRAEY/Y2V6Wr4F0Ic9hINQLUU+pUPlOPq udH2HP8cc3XHT0UeiXWAk1e+yiygS5A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1789807359; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B0RZiVdZBKQETt3xYfrSSwO37M1eFgXCgxwHmSecfyg=; b=03iMlbi/MKBQWC3KGzHo/HVAhytmsd/gR62M5pmIYCksnuJrbxENYC6mHf2iWdnsVG32UF 4ossB0WKE+eG3fCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 1843413869 for ; Sat, 19 Sep 2026 08:42:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 0eG0F/5KrmpvZQAAD6G6ig:T2 (envelope-from ) for ; Sat, 19 Sep 2026 08:42:38 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH 1/3] [gdb/testsuite] Add gdb_exit_cleanup Date: Sat, 19 Sep 2026 10:42:35 +0200 Message-ID: <20260919084237.1045724-2-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260919084237.1045724-1-tdevries@suse.de> References: <20260919084237.1045724-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-0.996]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; RCVD_TLS_ALL(0.00)[] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Proc default_gdb_exit does two things: - it tries to make gdb exit, and - it does cleanup that needs doing after gdb exits. Factor out the second part as new proc gdb_exit_cleanup. --- .../gdb.server/monitor-exit-quit.exp | 7 +----- gdb/testsuite/lib/gdb.exp | 23 ++++++++++++------- 2 files changed, 16 insertions(+), 14 deletions(-) diff --git a/gdb/testsuite/gdb.server/monitor-exit-quit.exp b/gdb/testsuite/gdb.server/monitor-exit-quit.exp index cb90169ef0c..75c3e6e2221 100644 --- a/gdb/testsuite/gdb.server/monitor-exit-quit.exp +++ b/gdb/testsuite/gdb.server/monitor-exit-quit.exp @@ -70,10 +70,5 @@ gdb_test_multiple "quit" "" { # Cleanup, as in default_gdb_exit. if { $do_cleanup } { - if { ![is_remote host] } { - remote_close host - } - unset gdb_spawn_id - unset ::gdb_tty_name - unset inferior_spawn_id + gdb_exit_cleanup } diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 1ebdaf6ba10..7bdc5dad0a7 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -2505,6 +2505,20 @@ proc gdb_reinitialize_dir { subdir } { } } +# Clean up after the current gdb instance that has exited. + +proc gdb_exit_cleanup {} { + if {![is_remote host]} { + if {[catch { remote_close host } message]} { + warning "closing gdb failed with: $message" + } + } + + unset ::gdb_spawn_id + unset ::gdb_tty_name + unset ::inferior_spawn_id +} + # # gdb_exit -- exit the GDB, killing the target program if necessary # @@ -2547,14 +2561,7 @@ proc default_gdb_exit {} { } } - if {![is_remote host]} { - if {[catch { remote_close host } message]} { - warning "closing gdb failed with: $message" - } - } - unset gdb_spawn_id - unset ::gdb_tty_name - unset inferior_spawn_id + gdb_exit_cleanup } # Load a file into the debugger. -- 2.51.0