From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id pgEUJL4srWoUVxsAWB0awg (envelope-from ) for ; Fri, 18 Sep 2026 08:21:18 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=r38yePqG; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 82EAD1E01F; Fri, 18 Sep 2026 08:21:18 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id ED6F21E01F for ; Fri, 18 Sep 2026 08:21:17 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 787D04BA2E36 for ; Fri, 18 Sep 2026 12:21:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 787D04BA2E36 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=r38yePqG Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by sourceware.org (Postfix) with ESMTPS id A30844BB1C02 for ; Fri, 18 Sep 2026 12:20:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A30844BB1C02 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A30844BB1C02 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789734047; cv=none; b=m2jRNvfBHOtpaQA/LrMNJJxBT6O+O7xbje1AaFV6s29NzHyw7y2i0UKCG5eXfmHGvyMDMDdjNOaC8Wz93PGhq+du/Dmk6nvIxTGuZdvSuDwV8+VOFt0okNBkSxriYSiIcMlLGx1U8cO+X3ByFgY9CkBq0ajFh1q+t184aEmSqHQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789734047; c=relaxed/simple; bh=/+upeuhDIXIA/mYdunQYbDli+NNoQw6HuCh1ZvQSfiY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=PKYfWWDVlytQpXcCmXwqIBQovgNxf5W+GAlHzbHVtOPrGNyV5760rSNNMYHvYDbL/d3QwPpZZqN8bJ6yk3B2zDJFqqXG6ql0m+FmaTQftLPOFuEXtmhc1/6sch4BsLXBFWBz5cDdOxjGt2ZDZC+azYhhsuX7lne4hFZx80eB9Pw= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=r38yePqG DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A30844BB1C02 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-2db710396ffso13992065ad.1 for ; Fri, 18 Sep 2026 05:20:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789734046; x=1790338846; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=6qEIAyvd5Gw2SOwPhhG3bNnZJms7NgfrKYxs71OKURs=; b=r38yePqGZk7G+qNub3+0NOBayEzhDhvCq7RW7rHVPBu5cmAjBs/AEtH9NAMdOCT9ue 0iq/BIbEcc8+MFlPXUsUXsvSK8VpCIH5zwykaJ5b3TyETOaENpXDBK9+2nm3eCX+nOWh Z4YC1RzmYYu2aei2b1Mn2OITpGCLYuhu+iJ0/KRO6LVy08EtQEwSUrxyB2NcXmzOqx4R hjQEhA7QaQY/mi1VpBnkvKGTcb4H2kK5ubPgU5Xyz4n7Q7gEZr4fg9ptdYLmMQHgVD4q cq14cg5CpjVDGikkBTw5ICgTusZViR2u+WH9aVwlQqyGmRHhY9DZZpfVuwpGJuVdQqJz JERw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789734046; x=1790338846; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6qEIAyvd5Gw2SOwPhhG3bNnZJms7NgfrKYxs71OKURs=; b=pm2+T3StsgMwmfKkBBNxuHT+Gn4eJ0VtWABdQciKpX0srjNf/FrjoVeWqRpMNKxziY PwdTrtLApxLUQJuMEj7HNN2iEWyiAqVoU8UP/zVQtwGLs+MrDsgdQrDDQ/wD2j5/xapx 2lf7wlqx/CCj4do9vibztNeeDL+lPHe8+ZpAkcfawTwkgyff1ZThHeX55+Y8zot6g2Du 2K8UG8MOhdJl/VNktCpHniZPYkaTpkA8LTKtgEOw8NgyPkB+iImB0Dkfo6qpYAu3nIo5 4rjQYkFv6nuEUQwN0MOZxH6WcTXtgLn9hf2JPdWmogK0z/NSfbCl+Donp6clxC+8camH vDMA== X-Gm-Message-State: AFuF++l6iZhH0gx6FjTWELxsgoTf4ls+sO6h1vfedFwMhvlESfV+S7cT XYgYkitWpz1HIPE9kWFhSqf4BeDf81iWla1fi9pv1dDuyOy1mKjJqDml X-Gm-Gg: AYBFou32kBTaFrDTqX0FP3+k03yC+NRDA/ycFYhMCxD1EFUA3bzDMFi+z1oITWrc+PW GWh31pqFfMR/NuDyVzIob5snpxzhWSlSPu136IebYVrYwUSsP6QUFdYdO3996C1nSeTGWkabrvj 3ZcFHpyBnPi4Vi+VMTiIYmXbJqtNLbSzcKaRXAwLob9UCSmCCV8yPwxqgOG9EGIi1+/dFuLHv54 poFabte5oSiktZJ/xjQydGUwpgXVKveL/nXV83OL9oz4Doxv6reRXgGOzglpEh/JZXqhfiMzgMz MXC5wl/wPOOtsolCsrtAiOqJV7ZVM+WsepFtWtWQiBLB5XjLwhscXI62UFC6HUWb7pPt8Aoh2/T s0ZbNpSiZvbAGePw4h5+QTtsCJeeJdwMjmgpLaITJnEBfyWWhJ62n7mdRw80YzLVkr0iQyajAse c2Il2ccrIqF4X3ZOIx2MIcvKMzDtxpfajzpx7nLFzzc1Q5dwajidHqFzY7cYiPPksFCTIu2mjZt FJT6YypLd8Qm+Cj2gEXDXJxr7RHYBG+BTWawQ== X-Received: by 2002:a17:90b:3607:b0:39e:370e:2f48 with SMTP id 98e67ed59e1d1-39e370e2fd4mr6943294a91.4.1789734046487; Fri, 18 Sep 2026 05:20:46 -0700 (PDT) Received: from localhost.localdomain ([122.171.19.232]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33c2872052fsm4735512eec.11.2026.09.18.05.20.43 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 18 Sep 2026 05:20:46 -0700 (PDT) From: Aditya Vidyadhar Kamath To: ulrich.weigand@de.ibm.com, simon.marchi@polymtl.ca, tom@tromey.com Cc: gdb-patches@sourceware.org, Aditya.Kamath1@ibm.com, sangamesh.swamy@in.ibm.com, Aditya Vidyadhar Kamath Subject: [PATCH 2/2] Fix uninitialised fields in aix_thread_variables structure. Date: Fri, 18 Sep 2026 17:50:05 +0530 Message-ID: <20260918122004.37424-2-akamath996@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org From: Aditya Vidyadhar Kamath The fields in aix_thread_variables structure were never initialised. So we initialise them and also change to bool since they are purely flags. This patch updates all assignment sites to use true or false accordingly. --- gdb/aix-thread.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/gdb/aix-thread.c b/gdb/aix-thread.c index b4b9efca5d4..0602fc3a8f3 100644 --- a/gdb/aix-thread.c +++ b/gdb/aix-thread.c @@ -165,21 +165,21 @@ static pthdb_callbacks_t pd_callbacks = { struct aix_thread_variables { /* Whether the current application is debuggable by pthdb. */ - int pd_able; + bool pd_able = false; /* Whether a threaded application is being debugged. */ - int pd_active; + bool pd_active = false; /* Current pthdb session. */ - pthdb_session_t pd_session; + pthdb_session_t pd_session = 0; /* Address of the function that libpthread will call when libpthdebug is ready to be initialized. */ - CORE_ADDR pd_brk_addr; + CORE_ADDR pd_brk_addr = 0; /* Whether the current architecture is 64-bit. Only valid when pd_able is true. */ - int arch64; + bool arch64 = false; /* Describes the number of thread exit events reported. */ std::unordered_set exited_threads; @@ -839,7 +839,7 @@ pd_activate (pid_t pid) PTHDB_FLAG_REGS, &pd_callbacks, &data->pd_session); if (status == PTHDB_SUCCESS) - data->pd_active = 1; + data->pd_active = true; } /* AIX implementation of update_thread_list. */ @@ -904,7 +904,7 @@ pd_enable (inferior *inf) /* Prepare for thread debugging. */ current_inferior ()->push_target (&aix_thread_ops); - data->pd_able = 1; + data->pd_able = true; /* If we're debugging a core file or an attached inferior, the pthread library may already have been initialized, so try to @@ -927,8 +927,8 @@ pd_disable (inferior *inf) pthdb_session_destroy (data->pd_session); pid_to_prc (&inferior_ptid); - data->pd_active = 0; - data->pd_able = 0; + data->pd_active = false; + data->pd_able = false; current_inferior ()->unpush_target (&aix_thread_ops); } -- 2.51.2