From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OaD8C/Tfq2r+rhYAWB0awg (envelope-from ) for ; Thu, 17 Sep 2026 08:41:24 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=oxVWWtj4; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=HSWA3Il0; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=dphkyprF; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=NzPB2RJV; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 197611E06B; Thu, 17 Sep 2026 08:41:24 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 092B71E01F for ; Thu, 17 Sep 2026 08:41:22 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 193EC4B9DB60 for ; Thu, 17 Sep 2026 12:41:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 193EC4B9DB60 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=oxVWWtj4; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=HSWA3Il0; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=dphkyprF; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=NzPB2RJV Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 186F84BA2E0A for ; Thu, 17 Sep 2026 12:40:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 186F84BA2E0A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 186F84BA2E0A Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789648853; cv=none; b=Nt/3wga1+1IBKawk62Fy+hQlCnT2j40RY16u7UtpuLnRzyDDLekeMvfWGXzhUBhTXdQOybQ77dTA2uzMudPlCsvPSO8VfgpANWvGCcSSbH7ZuBApBQjYR59GIKVj/BNJKunL5uIPXhJ1HmOcXqm9IVoA11Di5L+f7i8U9C7zXrw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789648853; c=relaxed/simple; bh=v+yCbxdgHjie2V2Yr8NCUeoEsk08Tjb2r9oY3eB1zZk=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=C7YBb0zvyMLyJiATZEzvGp9VZNvIF/Oy+vuKdH1jkVAcdE2Qa2jy1/XFNyJUQ7nxvUkradnHczYuYljERn7PlH4F0S+6bc/BAepAEuvp/4ry5vVZ/ZdjyCtZ//9H6eJeBD76JNHUYECohM1ksikTiTGWuwoiWIyMp02T8HpQ160= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=oxVWWtj4; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=HSWA3Il0; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=dphkyprF; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=NzPB2RJV DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 186F84BA2E0A Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6F94B21992 for ; Thu, 17 Sep 2026 12:40:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1789648847; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=nS5RPvUDI+9oACktZzWXT95rnv/OsTVxNmKglhQkCRg=; b=oxVWWtj4ABxlyPVC5ADixUB13Z1CUn8dJSpDA9gPZf70ss0SDyy2NEZX+rTSSHoX/Aze/l SYSg/D3vgZlDQaSRtO33mm1wYGWBstNXiCJ0leQwUN1uYe/Dz6DevgMmu78NgYIdnao16r l/59ilc7wr/m0JO5XUnwh2HzfEMgVfg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1789648847; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=nS5RPvUDI+9oACktZzWXT95rnv/OsTVxNmKglhQkCRg=; b=HSWA3Il0hALjuuVK3IyDaK5UDFn8Vvo/oYs6SdBH4QuHEQkK3VbGxzVoZNrQru+dXMm40F DkvTgO9cH8H5+XAA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=dphkyprF; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=NzPB2RJV DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1789648843; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=nS5RPvUDI+9oACktZzWXT95rnv/OsTVxNmKglhQkCRg=; b=dphkyprFwjB96KZZCowxV5vfYefYPIQ96eXpec1WcIckNlLVAdIQRmYv0hJA+Mb+Tt52Tx VjU5k5IHtg2bdv8JoHeanvisAV1ofB6GrCSakrfS34HD27tJCEfv/BExnVGWZfpr1sGGTu i5xtMu61IkvjKi5WRtMsfaGtm/+yzFg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1789648843; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=nS5RPvUDI+9oACktZzWXT95rnv/OsTVxNmKglhQkCRg=; b=NzPB2RJVz6RHemdIzqgYHKfmVFmfpogxj2oa/W5U3DktehfGG17WorNLagb2pNZjPNJ0J8 YEfFd3C/TXXtTKAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 35B32134B3 for ; Thu, 17 Sep 2026 12:40:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id OH+8OMrfq2qBDAAAD6G6ig (envelope-from ) for ; Thu, 17 Sep 2026 12:40:43 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH] [gdb] Check for sched_getaffinity in configure Date: Thu, 17 Sep 2026 14:40:42 +0200 Message-ID: <20260917124042.3215076-1-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 6F94B21992 X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; FROM_EQ_ENVFROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_TLS_ALL(0.00)[]; TO_DN_NONE(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org A post-commit review comment [1] on commit 8ea833b7067 ("[gdb] Exclude unavailable hardware threads in default worker-threads") mentioned that we should: - check for the presence of sched_getaffinity in configure - remove the todo comment. Implement these two. [1] https://sourceware.org/pipermail/gdb-patches/2026-September/230415.html --- gdb/config.in | 3 +++ gdb/configure | 1 + gdb/configure.ac | 1 + gdb/maint.c | 6 ++---- 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/gdb/config.in b/gdb/config.in index 74745665d4d..0e5a6637c2b 100644 --- a/gdb/config.in +++ b/gdb/config.in @@ -430,6 +430,9 @@ /* Define to 1 if you have the `sbrk' function. */ #undef HAVE_SBRK +/* Define to 1 if you have the `sched_getaffinity' function. */ +#undef HAVE_SCHED_GETAFFINITY + /* Define to 1 if you have the `setlocale' function. */ #undef HAVE_SETLOCALE diff --git a/gdb/configure b/gdb/configure index f411113ea66..810e9ed7a37 100755 --- a/gdb/configure +++ b/gdb/configure @@ -30161,6 +30161,7 @@ for ac_func in \ pread64 \ pwrite \ resize_term \ + sched_getaffinity \ setlocale \ setrlimit \ setsid \ diff --git a/gdb/configure.ac b/gdb/configure.ac index 5d8e2d6628f..0d88a280b16 100644 --- a/gdb/configure.ac +++ b/gdb/configure.ac @@ -1542,6 +1542,7 @@ AC_CHECK_FUNCS([ \ pread64 \ pwrite \ resize_term \ + sched_getaffinity \ setlocale \ setrlimit \ setsid \ diff --git a/gdb/maint.c b/gdb/maint.c index 800cf7e0cda..ed57b34eab5 100644 --- a/gdb/maint.c +++ b/gdb/maint.c @@ -47,7 +47,7 @@ #include "cli/cli-style.h" #include "cli/cli-cmds.h" -#if defined (__linux__) || defined (__CYGWIN__) +#if HAVE_SCHED_GETAFFINITY #include #endif @@ -891,13 +891,11 @@ update_thread_pool_size () { /* Exclude unavailable hardware threads (for instance made unavailable using taskset). */ -#if (defined (__linux__) || defined (__CYGWIN__)) && defined (_GNU_SOURCE) +#if HAVE_SCHED_GETAFFINITY cpu_set_t cpus; int res = sched_getaffinity (getpid (), sizeof (cpu_set_t), &cpus); if (res == 0) n_threads = std::min (n_threads, CPU_COUNT (&cpus)); -#else - /* Todo: handle other platforms. */ #endif } } base-commit: 4c733e49e3da1eab7991ab64c5bb75c7a56bf48a -- 2.51.0