From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id iT4YIYNnqmrQ7xEAWB0awg (envelope-from ) for ; Wed, 16 Sep 2026 05:55:15 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=DK+aDGOG; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=j8Q9x/Bf; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=DXt52zMS; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=aJe9kHKe; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7BDFA1E06B; Wed, 16 Sep 2026 05:55:15 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EB57C1E01F for ; Wed, 16 Sep 2026 05:55:13 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2827D4BA23EE for ; Wed, 16 Sep 2026 09:55:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2827D4BA23EE Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=DK+aDGOG; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=j8Q9x/Bf; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=DXt52zMS; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=aJe9kHKe Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 110104BA2E3C for ; Wed, 16 Sep 2026 09:52:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 110104BA2E3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 110104BA2E3C Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789552374; cv=none; b=uHFn/62QLcD6ge0zp7Zyp8yyIXcaImwqzCTRJF4oMyZenAaanmf1gqwvbm6Ty8llLGFKhBohx7Uw2J8Xke3ISMLKz44lxD84lVy9aeAQjiPEvWYycwdTxspVucRvzQB9tfx88EiuMdgLkML1MSlnlAjDNh6Q3xBP2rNnulbrKrw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789552374; c=relaxed/simple; bh=GpzSRHa9K85j6uFxDkvvLQi2rypLShKYOldB7nVQbjI=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=LgBQxX0yzhOqr2BveMFDFerpsKA10JmmDEVvQUPkmuoGUwdMZLtOcl9+XksEUy1etT7/yFB0YwqXLH2aY0ioo3/o9hgErW79+a/6H9YoFbVtYYVuSGYlFiwsg2ShQKNXuQafTOAT0jq2aROwhdaCBCrnJJz4TS/Ip8IYNFzUiJs= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=DK+aDGOG; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=j8Q9x/Bf; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=DXt52zMS; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=aJe9kHKe DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 110104BA2E3C Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id AF6AF21B61 for ; Wed, 16 Sep 2026 09:52:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1789552368; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nHwNcrt9dKEyWTMCibU1x8p1ZpIWOVLr8wbX2wZLdDg=; b=DK+aDGOGxqf5D8u5a6qqKvF70kIkkpYYgWHBBy0q305bHeXR8RZbQ0cVcfP0e/gaWgQIYq sCQsarlhxh/qZwx73QGQ4RKnQoCvtTucOQzlU+SUJooeai8Z35qGLJU3beNFKbT/j4hgEi MpklSnppXwW+kxEs/Wigu2daZi6QAYA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1789552368; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nHwNcrt9dKEyWTMCibU1x8p1ZpIWOVLr8wbX2wZLdDg=; b=j8Q9x/BfDkJauYtGA9Y02oQ9ALfZD2iheaD7JGvDwm3fj9DvaO4U4bv46ndH8PiQgjn6oQ ONT6Jqwzi418dZCw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=DXt52zMS; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=aJe9kHKe DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1789552364; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nHwNcrt9dKEyWTMCibU1x8p1ZpIWOVLr8wbX2wZLdDg=; b=DXt52zMSZ1Fqaz1WnEYPdMxG2rAfUp8xYxxbWxXA88ZSmml8x60O0qSA0VYLFLGmJWaopb 8CpESI8sYviqFmdbWgjACBCOYsOmxlN8psK6CCeEK2t6PtZ27PJmbvknk3qqVozdzSwq8G iUj/mBY4LAPmLGy7IoPDz14jQ0dlO/4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1789552364; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nHwNcrt9dKEyWTMCibU1x8p1ZpIWOVLr8wbX2wZLdDg=; b=aJe9kHKeQ2Nwd4S0icRXAiy8JgK4J159IECI2Xnlv2guk1vxPr9OyRfpn5ChYf6lxEPH+F vjgBDGpYCJsrvBAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5914C137D2 for ; Wed, 16 Sep 2026 09:52:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id omSCKetmqmqMMQAAD6G6ig:T5 (envelope-from ) for ; Wed, 16 Sep 2026 09:52:44 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH 4/4] [gdb/testsuite] Speed up gdb.python/py-rbreak.exp Date: Wed, 16 Sep 2026 11:52:43 +0200 Message-ID: <20260916095243.3040533-5-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260916095243.3040533-1-tdevries@suse.de> References: <20260916095243.3040533-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: AF6AF21B61 X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; RCVD_TLS_ALL(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I noticed that gdb.python/py-rbreak.exp does: ... if {![runto_main]} { return } gdb_test_no_output "nosharedlibrary" ... Speed up the test-case by not running to main. This breaks the gdb.lookup_symbol("efunc1") call, which requires a current frame, so use lookup_global_symbol instead. Also remove the nosharedlibrary command. No longer running to main means we no longer load symbols for shared libraries, so the nosharedlibrary that drops those symbols is no longer required. --- gdb/testsuite/gdb.python/py-rbreak.exp | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/gdb/testsuite/gdb.python/py-rbreak.exp b/gdb/testsuite/gdb.python/py-rbreak.exp index 395a603ef4e..a1ca7d4283d 100644 --- a/gdb/testsuite/gdb.python/py-rbreak.exp +++ b/gdb/testsuite/gdb.python/py-rbreak.exp @@ -26,12 +26,6 @@ if {[prepare_for_testing "failed to prepare" ${testfile} [list $srcfile $srcfile return 1 } -if {![runto_main]} { - return -} - -gdb_test_no_output "nosharedlibrary" - gdb_py_test_silent_cmd {py sl = gdb.rbreak("",minsyms=False)} \ "get all function breakpoints" 0 set min_breakpoints 11 @@ -65,9 +59,9 @@ gdb_py_test_silent_cmd {py sl = gdb.rbreak("func1",minsyms=True)} \ gdb_test "py print(len(sl))" "2" \ "check number of returned breakpoints is 2" -gdb_py_test_silent_cmd {python sym = gdb.lookup_symbol("efunc1")} \ +gdb_py_test_silent_cmd {python sym = gdb.lookup_global_symbol("efunc1")} \ "find a symbol in objfile" 1 -gdb_py_test_silent_cmd {python symtab = sym[0].symtab} \ +gdb_py_test_silent_cmd {python symtab = sym.symtab} \ "get backing symbol table" 1 gdb_py_test_silent_cmd \ [subst_vars \ -- 2.51.0