From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 3deMMb/5pmrWJQkAWB0awg (envelope-from ) for ; Sun, 13 Sep 2026 15:30:07 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=JskmcsPX; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BA8F51E033; Sun, 13 Sep 2026 15:30:07 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4475F1E033 for ; Sun, 13 Sep 2026 15:30:07 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A71834BB24FA for ; Sun, 13 Sep 2026 19:30:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A71834BB24FA Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=JskmcsPX Received: from mail-wm2-x10.google.com (mail-wm2-x10.google.com [IPv6:2a00:1450:4864:31::10]) by sourceware.org (Postfix) with ESMTPS id 124F84BB3B9C for ; Sun, 13 Sep 2026 19:28:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 124F84BB3B9C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 124F84BB3B9C Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:31::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789327711; cv=none; b=R+4lJEA3e2O5R/Bij62iEAc4mo4fMesU98AygyZW57C37JGzAkwN4ifYfBb1xgjG3dct0Vl49dKNRK2M1+kEC824hMLBwRuFpV+vHeTlu9FKf3wFR2I5VMOJuS+VjjVI67tMvXuv5YQ9LblYpt0+5FkdWmABAyg1Z00UUVd8lAs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789327711; c=relaxed/simple; bh=b2IB0yT8ncLjVrBttp7c4BrzDkt6d6g+5u+0MqzfEqs=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=GvQVxGWuP0gUpiKn0ZT63ljZx4WIEJT4UxsedVleUT1WWGafvyVRYM1m6ZC1G4xrrjM67dOelXycxznfRtu9iCZJsb6GKctYXuheO5tPd6cZrqViTJu+NBThKO4ezqWvqdY2w8m6GGh3oldiWasQ6dD5nPG6CfGLnwadTYjhwBU= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=JskmcsPX DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 124F84BB3B9C Received: by mail-wm2-x10.google.com with SMTP id 5b1f17b1804b1-49e69b9e16aso11820665e9.1 for ; Sun, 13 Sep 2026 12:28:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789327710; x=1789932510; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Jr3mUgCIrDUyvNrWEZN56QdE1yA4H0BjLVqGxNlhMV0=; b=JskmcsPX0xpAtayGGlp5Elr0+qh1lggL0jgyS0oCP650sGJrolFjpuWivYXeHIffYp pekc9/2om6FSm3Nk+ZSwcKROUfehg/6aIx8wii9APAoOSN+wxx8qnMTEz1VAP3TUcxW/ rghY450N117SoDIdVMNp1NGoXrFG1nxsIXLw+6OFAnBaKlcdjDZmfARbsaWI4SCbvx1n M9CojQMF/DOQGGoPPEBvOcfNn8lgTZfv9EX12YxQQPuUDA1ad5ofcWaTymThwV+ivgMN S3K643yEm0OpkojXYrsBAE+zkuBM3Mli7aCcPHn6YeH5aFqB73M1516NzmPsYgH2kQHq xX3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789327710; x=1789932510; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Jr3mUgCIrDUyvNrWEZN56QdE1yA4H0BjLVqGxNlhMV0=; b=UNtzFZVLxWnb+qjR86CnDmG69qutFCvAJ1P88Zw45ii6BOStWtv0qiptUm9X35A5RB qsfqc5/cRr/FYuuKsOKtE6n91klTjlzbfDtudq8P+blBXeEFPtpaQU7gtY1ALwK8r3pg GGS83/Tg0vtEu75sy/gl9sirBje/5qtEjrwjchmLeTGItWqnaKJmqA9rPkBSJPm6w5L+ U8FY2ti6eWcLmqeJvnAyPOIeTgcHVopDLkyp7zqZIWzSdurdSwaB1sXXbDj92akP+1gC uqi2T9L6MaxhiRlD0ERQnNU/s++r6SVuJVqJAaagnzFD784I607vYTyXftl4rEKIT0po JCJA== X-Gm-Message-State: AFuF++kSH8iMCzs3jL1apt+jwdSQqZQooCsA+XwFh/pjHld2F3/IWFcy lKAg8B73NlUbuI4AGV/ZbNs2zVOx1iKRRrT9NlOZibcFV9Kz8cZ5WDVqIY5lrg== X-Gm-Gg: AYBFou1OhlgMzRfyn21VFc/otAnAxTfxboBFbZyd4fvKs/N+cNvWWQUdcjAlnw49CMZ bxuR8TI43mXDUJjeDWFzYyNFVyH1KE0QjPTdo3SlKaXNtWRm8GSiRGhBDDs+g2g2Yt9aUEv2ROL R7oX5bRwLOCwmhLb/iWfdKuIDSVMGMMyJUCBJiZLh8vFGf4g9eQk4ER3sHPlmIeXYODv+rM4FFC zorleG5D++Y2g5BP4bnuz3du9JM3zcOmeo7MT2eHJYAuNJc0VA+1ZZpaUt8hFGQ60JKV+DBho7Q geh7EJGJCIyPI2luEkvU+wfKwP1m4Q2nRytZT+xoaVQfxyJDRmFXohN6djQbZm8Bt9LYhQqZt99 J9cWsiqwLFBo78CxT0NIzIKu4ohLpxXAY39VoKY7Ol7cyIexE5mrmprLCLgnriZWLejrzsK2Fwv 8AiYsnhcdGBRR1z+e/QjsWpZuwfJ3KnyuFfn31giMuAv4rbyHJeSpWNcbISK8h2H26Xc3ntK7kT /TmCrDQpI1Z7XkdccFaccqKLgOBz4CyfY8c/cBbTR+b/F36ZuLzRk5266Qh+hRoD5xX+b1aEadU Tu4= X-Received: by 2002:a05:600c:19c9:b0:49e:6c9b:4e94 with SMTP id 5b1f17b1804b1-49e6cc11409mr76062005e9.28.1789327709734; Sun, 13 Sep 2026 12:28:29 -0700 (PDT) Received: from Mein-PC (p200300ed8f441a0024c1028e800bc45b.dip0.t-ipconnect.de. [2003:ed:8f44:1a00:24c1:28e:800b:c45b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e6a06cfb8sm180604355e9.5.2026.09.13.12.28.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Sep 2026 12:28:29 -0700 (PDT) From: Oleg Tolmatcev To: gdb-patches@sourceware.org Cc: Oleg Tolmatcev Subject: [PATCH] gdb/dap: compute CompletionItem.length from input Date: Sun, 13 Sep 2026 21:26:14 +0200 Message-ID: <20260913192613.1952-2-oleg.tolmatcev@gmail.com> X-Mailer: git-send-email 2.55.0.windows.5 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org The GDB/MI -complete command returns the complete command line, including the prefix supplied by the user. CompletionItem.length specifies how much of the existing input should be replaced. Set it to the length of the text passed to -complete, rather than the length of the returned completion. --- gdb/python/lib/gdb/dap/completions.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/python/lib/gdb/dap/completions.py b/gdb/python/lib/gdb/dap/completions.py index 5cc6e025ee5..8495e4f8b6b 100644 --- a/gdb/python/lib/gdb/dap/completions.py +++ b/gdb/python/lib/gdb/dap/completions.py @@ -49,7 +49,7 @@ def completions( completion = None if "completion" in mi_result: completion = mi_result["completion"] - result.append({"label": completion, "length": len(completion)}) + result.append({"label": completion, "length": len(text)}) # If `-complete' finds one match then `completion' and `matches' # will contain the same one match. if ( @@ -59,5 +59,5 @@ def completions( ): return {"targets": result} for match in mi_result["matches"]: - result.append({"label": match, "length": len(match)}) + result.append({"label": match, "length": len(text)}) return {"targets": result} -- 2.55.0.windows.5