From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id UZGQGjvQpWoiawUAWB0awg (envelope-from ) for ; Sat, 12 Sep 2026 18:20:43 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=fHt+GDac; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 65F821E167; Sat, 12 Sep 2026 18:20:43 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B87661E033 for ; Sat, 12 Sep 2026 18:20:42 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E6F824BBC0AF for ; Sat, 12 Sep 2026 22:20:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E6F824BBC0AF Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=fHt+GDac Received: from mail-wm2-x11.google.com (mail-wm2-x11.google.com [IPv6:2a00:1450:4864:31::11]) by sourceware.org (Postfix) with ESMTPS id 242744BB8F55 for ; Sat, 12 Sep 2026 22:20:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 242744BB8F55 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 242744BB8F55 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:31::11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789251618; cv=none; b=sR9dJTD0TggrnEoCrUHuDrfTLIlBBvqNzBtcKtNa+YT2TeVsRrmWoJnhi3SCG9SISpGR+5feOtgF76FLSYDCappi27ZNvY6TG/DUERXgUzYhg438Ue/chd/Vs3O354S+i72fcIcXzfcl8hw8jJyuTNIkN219da3lPqXjUYqjEVE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789251618; c=relaxed/simple; bh=4FHiCVXd5gnPTHVViR5wEpSEAbeidhCYm38ZWC02Sqg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=OQbPcjpHbc+pCKwoiGGkTRw+4SVIriBQA6sSV77zgDzrPTvVLSa7EVNm90M8dJxmUJEgDCyc9D2929n6scCiBE5VxaSzxIGh5BzXOszc82SACadlZZBSH2AM+S2sOvBYqrmmXVg+w5Ckzdg8aIdJ792e1XrpqrrKKeZ+u0Pviek= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=fHt+GDac DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 242744BB8F55 Received: by mail-wm2-x11.google.com with SMTP id 5b1f17b1804b1-49e7355e411so3726175e9.1 for ; Sat, 12 Sep 2026 15:20:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789251617; x=1789856417; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=osHxwMryJxCiDFygiy0ZXia7Z6iBYEEp4/6VYnuZAaY=; b=fHt+GDacDzPB+SkvyiEGOBirz5O2/gNLK1DvvDb7LrPdmhGOjB3hY4WT4pkxNRPlLU MO/j47iI/wYxUk9wpGtAld4ltzNNqsi1jsGkAOk74DKkso6fOjg3fJO42LZ0AjMQVbFw KCU9A6vFf2WBYJy6vtNkhtMVlEkLu6JIsrTTFZUiTXMYe/NOpdSa4I/Y33gJ+bI9xq+u sX4yX5rKnm/0YxAz7EosyVEQORxbHnuxQVSgUhwShCPX2BDRd6efaQ8jpqwbchLVKjkr Y4gKIkC8okvogc6DlUNwLYcee6TaKSWcW+mOfMmQa2FqMRraAEynZqS99vqhT+0wqD8n pRNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789251617; x=1789856417; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=osHxwMryJxCiDFygiy0ZXia7Z6iBYEEp4/6VYnuZAaY=; b=iYNzwlAS+Lf8jtN6Ka4Mc3j4rKMrEXvrZLnBy6qtsTzsWoWS2+lO+ZeVh1q6RvCiC+ Z44ONhln0470jnLZEOvSSxjYbCXVpL2b2GGXt6kMev0PLP4no+kU1viN6bNemn7whcBk OWm901QjxZyjtWaVeJl4v72uoFPSXwNEpY8mL8f9Qvi9LzvJPvL5LCv5j6HccGqfv7O2 ZPerHey68bFcGzSIOCLqyijXBO0/I2CoxLCV1RH40oM3FLzQ/ycj0gZcrj1dXnz/h3nY DP+7MaWucMne4h7HqzI3/yTj+eC9yzsKynA6OwuXzJh+darqBpC1lb4UMWc/ORYEUYzy h+Vg== X-Gm-Message-State: AFuF++lbRGau3UqG4+AQjttoVgoJrwwLk2pKrZWkazqpvO0BvX+WcrQD NUraKpS/aotUIiiyurnfBt57K35WhGae19ROagnPCqdyiHpaOEw+otKpe7o8xw== X-Gm-Gg: AYBFou1kS8JnQjJh6aCC1JXm98/ydRYLH9IwMB/6E6w+co46BnZdQyrw3dYsNN6ak6F D+TGa0YwzOTQAXeTjVm60qnoonQsPOqHS2SpqSzqpSf0vNrf9vasEdBoe/hXO/x4XPdPfaEOdkg 7UxafaAdS1qOY6EcfyX3I8vur67OGukgEsemm0CAfiYhvWnfTdiFY4uZ2IszeVPZN9L/Zi1YdHR X6yABIFJhm7cgxyqPR/OYoOVgraqHo3F8/0kRvcbBzVTmpYG25qGink0Sndosp2RBipZ0eM2Tta x+g69VZkb44bJwHaMKMPKMNkhRUe00PzOSMheTSg0OIDxDNC2qHhqTMxlMLd2hQ47DpGcOeLMES GvMibDm3Pd4MZmgm2eJqo8RZHmI3MplDHx27tK+XXBZhlDEyFvM1K968tMrbb60I2YzNxgpJw1F sM10YSIQzDlzjfiWArM5Dmii9YnW7Z+Ek3xNMuUvFiFKQRiJyrsIjob1peP9eUFK/4zPfC2v3EU vx4NE0OPO4cXw== X-Received: by 2002:a05:600c:4505:b0:499:7a15:fcec with SMTP id 5b1f17b1804b1-49e61a03b32mr208556975e9.13.1789251616793; Sat, 12 Sep 2026 15:20:16 -0700 (PDT) Received: from jolana.. ([86.12.216.189]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e61a803c5sm112535845e9.1.2026.09.12.15.20.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Sep 2026 15:20:16 -0700 (PDT) From: Luis Machado To: gdb-patches@sourceware.org Cc: thiago.bauermann@linaro.org Subject: [PATCH 2/2] gdb, aarch64: add selftest for the pauth mask cache Date: Sat, 12 Sep 2026 23:20:11 +0100 Message-ID: <20260912222011.2395686-3-luis.machado.foss@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260912222011.2395686-1-luis.machado.foss@gmail.com> References: <20260912222011.2395686-1-luis.machado.foss@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Add aarch64_remove_non_address_bits_test, a selftest that builds an aarch64 gdbarch with the pauth feature, installs a mock target that counts fetch_registers calls, and calls aarch64_remove_non_address_bits repeatedly while invalidating the regcache between calls to simulate a resume/stop cycle. It checks that the target is only ever asked for the dmask/cmask registers once each, rather than once per stop, verifying the per-inferior cache added in the previous commit. --- gdb/aarch64-tdep.c | 70 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 70 insertions(+) diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c index c7003687eab..fb046d12c8e 100644 --- a/gdb/aarch64-tdep.c +++ b/gdb/aarch64-tdep.c @@ -42,6 +42,9 @@ #include "user-regs.h" #include "ax-gdb.h" #include "gdbsupport/selftest.h" +#include "gdbthread.h" +#include "test-target.h" +#include "scoped-mock-context.h" #include "aarch64-tdep.h" #include "aarch64-ravenscar-thread.h" @@ -4470,6 +4473,71 @@ aarch64_remove_non_address_bits (struct gdbarch *gdbarch, CORE_ADDR pointer) return aarch64_remove_top_bits (pointer, mask); } +#if GDB_SELF_TEST +namespace selftests { + +/* A mock target that supplies zeroed pauth mask registers and counts + how many times fetch_registers is called, so tests can tell how many + times a mask value was actually fetched from the target as opposed to + reused from a cache. */ + +class pac_mask_counting_target : public test_target_ops +{ +public: + void fetch_registers (regcache *regs, int regno) override + { + fetch_registers_called++; + regs->raw_supply_zeroed (regno); + } + + unsigned int fetch_registers_called = 0; +}; + +/* Verify that aarch64_remove_non_address_bits does not re-fetch the + pauth mask registers from the target on every call, since those masks + are constant for the lifetime of the inferior (see the comment in + aarch64_remove_non_address_bits). We simulate one call per stop by + invalidating the regcache (via registers_changed) between calls, the + same way a resume/stop cycle (e.g. stepi) would. */ + +static void +aarch64_remove_non_address_bits_test () +{ + aarch64_features features; + features.pauth = true; + + struct gdbarch_info info; + info.bfd_arch_info = bfd_scan_arch ("aarch64"); + info.target_desc = aarch64_read_description (features); + + struct gdbarch *gdbarch = gdbarch_find_by_info (info); + SELF_CHECK (gdbarch != nullptr); + + aarch64_gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); + SELF_CHECK (tdep->has_pauth ()); + + scoped_mock_context ctx (gdbarch); + + const int n_calls = 20; + for (int i = 0; i < n_calls; i++) + { + aarch64_remove_non_address_bits (gdbarch, 0x1234); + + /* Invalidate the regcache, as would happen after a resume/stop + cycle, so that a naive implementation is forced to re-fetch the + mask registers on the next call. */ + registers_changed (); + } + + /* The masks never change for the life of the inferior. Each of the two + mask registers (dmask, cmask) should only ever need to be fetched + from the target once, not once per stop. */ + SELF_CHECK (ctx.mock_target.fetch_registers_called == 2); +} + +} /* namespace selftests */ +#endif /* GDB_SELF_TEST */ + /* Given NAMES, a vector of strings, initialize it with all the SME pseudo-register names for the current streaming vector length. */ @@ -5160,6 +5228,8 @@ When on, AArch64 specific debugging is enabled."), selftests::aarch64_analyze_prologue_test); selftests::register_test ("aarch64-process-record", selftests::aarch64_process_record_test); + selftests::register_test ("aarch64-remove-non-address-bits", + selftests::aarch64_remove_non_address_bits_test); #endif } -- 2.43.0