From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qRNNH70roWrcWzkAWB0awg (envelope-from ) for ; Wed, 09 Sep 2026 05:49:49 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=FAGTOXZZ; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=3zbh2vLp; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=HuPxUD2c; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=vLcniPmq; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7B7931E09E; Wed, 09 Sep 2026 05:49:49 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EC2931E091 for ; Wed, 09 Sep 2026 05:49:48 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8D6FB4BB3BA4 for ; Wed, 9 Sep 2026 09:49:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8D6FB4BB3BA4 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=FAGTOXZZ; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=3zbh2vLp; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=HuPxUD2c; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=vLcniPmq Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 1CDBA4BA2E31 for ; Wed, 9 Sep 2026 09:49:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1CDBA4BA2E31 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1CDBA4BA2E31 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788947340; cv=none; b=ehdsCIUGN9IkE6ckDR6IYvoyr3mtHRPytsuIXerjifO2Sef8EvFlF+1SOaBo0xJvN2/kIU0CJGQWXDK+XCH4Nh2apDdw8T5/5ok69pQRM82595Aqgrj6WtR4Lly1lkrOnFF6Bg5fIguM89Kiy5PX3CJMCHZgOVk2Xzibvdz92Dk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788947340; c=relaxed/simple; bh=+E1Q4G79gQ4Is1aJa6FHwPMrx4kpYj0RrQ9BQgyXbGs=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=MATE10EIPqVKUG6anzOsMZsO1vwZmDikCx0504LYW5dOJbWBm9MK7TFm+qKP4ebIXqVEkMI2/08BzaN9fbeqWqlsmnbOpOoySJ2iS0vpomapnEyPjWEoKJe5mqz5vKPB/TurqHD1vzvTzqomSyYQFfD0sPDRaVGQsOCIzQULokw= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=FAGTOXZZ; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=3zbh2vLp; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=HuPxUD2c; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=vLcniPmq DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1CDBA4BA2E31 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C75ED21B24 for ; Wed, 9 Sep 2026 09:48:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1788947334; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IXnqPRManvSeoKpWEaijBgDrWjH+vjwH2SGGaIGcVtY=; b=FAGTOXZZwgvbI9HPS0jd9+39w+KJWr+iJKX54ZhNxTghxbuL1TyIdMYuq6D86kUbuHYNAb ETuWBlnWXiJRepv2f0EALF05hl6leCtG2zqc+L3LmpvR4lrthGTFPe7mVxVzM5oePUQD/3 UKZ/3X/Rc4jOicqxOL/bhOhrFj02gsU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1788947334; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IXnqPRManvSeoKpWEaijBgDrWjH+vjwH2SGGaIGcVtY=; b=3zbh2vLpNbraRaq69teil4GtQWJ44jkJJejhg53wimB6VXf7XQkFg7BqjkBtorT7NC6qQp F382Rio5sJ3T5cBg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=HuPxUD2c; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=vLcniPmq DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1788947330; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IXnqPRManvSeoKpWEaijBgDrWjH+vjwH2SGGaIGcVtY=; b=HuPxUD2cSjKM6HZgqXIoPOZ92U4nlRlKeolgIGg7C4lxGyYAdPHz4gGL2xGf1h5CZ5fXo1 u356CsRzEOCZjds0rndP1ugrKE+rofeoKJmjPMc9EbVZt16L10M+79f2DgghDJIoAA+0FD UiXXXiREuLMUiE4jOHm8bAt0h4FWxMg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1788947330; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IXnqPRManvSeoKpWEaijBgDrWjH+vjwH2SGGaIGcVtY=; b=vLcniPmqqWdGFrLGukbLoayfCNif9dJX+MBUsNnuQReIkrhD2uoyUZWp8PcNBH0M/AB7oR bMbMZVHLPhW7DpDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9CD171365D for ; Wed, 9 Sep 2026 09:48:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id UJfQJIIroWpJBAAAD6G6ig (envelope-from ) for ; Wed, 09 Sep 2026 09:48:50 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH v2 2/7] [gdb/tui] Fix underflow in tui_find_backward_disassembly_start_address Date: Wed, 9 Sep 2026 11:48:44 +0200 Message-ID: <20260909094849.2745086-3-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260909094849.2745086-1-tdevries@suse.de> References: <20260909094849.2745086-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: C75ED21B24 X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_EQ_ENVFROM(0.00)[]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCVD_TLS_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:dkim,suse.de:mid]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; TO_DN_NONE(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org In the tui-disasm.c selftests, we do: ... SELF_CHECK (tui_find_disassembly_address (gdbarch, 0, -1) == 0); ... This causes tui_find_backward_disassembly_start_address to be called with addr == 0, causing underflow in: ... bound_minimal_symbol msym = lookup_minimal_symbol_by_pc_section (addr - 1, nullptr, lookup_msym_prefer::TEXT, &msym_prev); ... Fix this by handling addr == 0 in tui_find_backward_disassembly_start_address. --- gdb/tui/tui-disasm.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gdb/tui/tui-disasm.c b/gdb/tui/tui-disasm.c index 923d4373e8f..7dcb59e6264 100644 --- a/gdb/tui/tui-disasm.c +++ b/gdb/tui/tui-disasm.c @@ -161,6 +161,12 @@ tui_disassemble (struct gdbarch *gdbarch, static CORE_ADDR tui_find_backward_disassembly_start_address (CORE_ADDR addr) { + if (addr == 0) + { + /* We cannot go backwards from zero. */ + return addr; + } + bound_minimal_symbol msym_prev; bound_minimal_symbol msym = lookup_minimal_symbol_by_pc_section (addr - 1, nullptr, -- 2.51.0