From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Yc++KtoroWrcWzkAWB0awg (envelope-from ) for ; Wed, 09 Sep 2026 05:50:18 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=tl6SCkTy; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=pVK88K5K; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=pgWoIgE7; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=+PIZ89wJ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A959F1E09E; Wed, 09 Sep 2026 05:50:18 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1B8251E091 for ; Wed, 09 Sep 2026 05:50:18 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4095E4BA23FC for ; Wed, 9 Sep 2026 09:50:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4095E4BA23FC Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=tl6SCkTy; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=pVK88K5K; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=pgWoIgE7; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=+PIZ89wJ Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id DB5044BA2E15 for ; Wed, 9 Sep 2026 09:48:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DB5044BA2E15 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DB5044BA2E15 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788947340; cv=none; b=MyuctVnGOBK2ZpidBYihQwQXBvZ1tQg3b6SG7rz/pCaTfE3Ys05pwnL5SHr0jNCkv3bVR/ptvEqQI5/titrbsGZpTGApXjjE0DifAljM3Wng9reCvpebshTpAU7VFd4LP8eLM4ANJOvE4SpTDWswE5Ki6e6vqcgGyPg/0GZYiSk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788947340; c=relaxed/simple; bh=5pvZIWcKoTDydN2M4FbP58mg0S7qYQvFcyHCDo4nzWc=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=Ac+Op6Xh/gyVATt/t0Shs7olX9VxxVBq6f1uW1GkM67Uh4LrIQVc27n2weaUQD0EvqLekwP3ijlR6cU84XFmWyYOYVN3jUkRqpyHBmqWxAeRKfeWa0ZbgTsVYIbFZa1gPVJdN6TPGVYPtnk/hqjbz2ait50gemuzRl6oRy6adVo= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=tl6SCkTy; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=pVK88K5K; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=pgWoIgE7; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=+PIZ89wJ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DB5044BA2E15 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id AB0A321B22 for ; Wed, 9 Sep 2026 09:48:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1788947334; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k3g4ErrHKn3VZxgejIl5zouBhZox8lc6dGQGnGA3cKU=; b=tl6SCkTyVQjCrS9mXTQyrs9GYFYj/CBTma6dZPgGphkU5+rEHxusKFKzUkp2Sz81WJ6s3/ ug8QW2xS3k7kytBEpb61gax8TTzOsri3zX7bAPI4n8dZe70XXBkLfGTQp+b3Ic5sEkU65p DQnjv0LgyKIUf/dNKSrcvYwM2msOqf0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1788947334; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k3g4ErrHKn3VZxgejIl5zouBhZox8lc6dGQGnGA3cKU=; b=pVK88K5KrepC8xH60ifeEcdgyZxCahpTKi0hhfT3rOl4LL+jdZhSnCBHyoeaRgnqCmpLxj 8tfOaUWYMFZEPCCQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=pgWoIgE7; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=+PIZ89wJ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1788947330; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k3g4ErrHKn3VZxgejIl5zouBhZox8lc6dGQGnGA3cKU=; b=pgWoIgE7crbgY6eLPxtkbaCkdPVm8yb819fdB9s8z1ohQuDElKgpfqilAGqDncGS/YnziX ezoS9xwlabNZ7tQOyVFAX71qcPir/DBKvDSCN3YwOIsBZYe6huk6GhEa44k67hyaRFRIV7 UK+bXw/GL5QzgrPSFY3nK5t64UrXJyg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1788947330; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k3g4ErrHKn3VZxgejIl5zouBhZox8lc6dGQGnGA3cKU=; b=+PIZ89wJOaCOzkVjMB2CNvX3UQ1AXgyS3lWHTFzvYb7O7Glw9361HHDh6ncvCcjcYg+5vS PItfIw7n8dJfyQBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 805D41352C for ; Wed, 9 Sep 2026 09:48:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id QB3zHYIroWpJBAAAD6G6ig (envelope-from ) for ; Wed, 09 Sep 2026 09:48:50 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH v2 1/7] [gdb/tui] Improve tui_disassemble comment Date: Wed, 9 Sep 2026 11:48:43 +0200 Message-ID: <20260909094849.2745086-2-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260909094849.2745086-1-tdevries@suse.de> References: <20260909094849.2745086-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: AB0A321B22 X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_EQ_ENVFROM(0.00)[]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCVD_TLS_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; TO_DN_NONE(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org The tui_disassemble comment states: ... /* Function to disassemble up to COUNT instructions starting from address PC into the ASM_LINES vector (which will be emptied of any previous contents). Return the address of the COUNT'th instruction after pc. ... In fact, the address after the last disassembled instruction is returned. In case less than COUNT instructions are disassembled, the comment is incorrect. Fix the comment to use "address after last disassembled instruction". Suggested-By: Guinevere Larsen --- gdb/tui/tui-disasm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/tui/tui-disasm.c b/gdb/tui/tui-disasm.c index 68a5c425934..923d4373e8f 100644 --- a/gdb/tui/tui-disasm.c +++ b/gdb/tui/tui-disasm.c @@ -82,7 +82,7 @@ len_without_escapes (const std::string &str) /* Function to disassemble up to COUNT instructions starting from address PC into the ASM_LINES vector (which will be emptied of any previous - contents). Return the address of the COUNT'th instruction after pc. + contents). Return the address after the last disassembled instruction. When ADDR_SIZE is non-null then place the maximum size of an address and label into the value pointed to by ADDR_SIZE, and set the addr_size field on each item in ASM_LINES, otherwise the addr_size fields within -- 2.51.0