From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id sRYRBdVToGruvTcAWB0awg (envelope-from ) for ; Tue, 08 Sep 2026 14:28:37 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=R7DittGS; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 11CB51E033; Tue, 08 Sep 2026 14:28:37 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_SBL_CSS autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 471FB1E033 for ; Tue, 08 Sep 2026 14:28:36 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AB8454B7A1DA for ; Tue, 8 Sep 2026 18:28:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AB8454B7A1DA Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=R7DittGS Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id A303E4B99F54 for ; Tue, 8 Sep 2026 18:28:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A303E4B99F54 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A303E4B99F54 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788892091; cv=none; b=veLegbujbtsLDtE3RoHL3/uaDU3zGMMSAezmCfHzH7mDpV5xLXm/HEuQkuD8Pil/0jNRsyKmvNE6dGUHrxdvoZg1vnwTVHqB7tSPrHWUk644HFoGWcYleotpuQr86OG/NHjA8lttra3mbAbsOR50AK3HBIxW+LVwjhwSRR/A1UY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788892091; c=relaxed/simple; bh=ETBBvr6cWEL/prV1KkIgvmXLqN+yHna1hA7L1xzg/hk=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=Feo8U82fyLDO5CBInDP3Gzpu0ho9Mfa20zTFLf+uLAJLx/g/RBwRFwEenm95p21RbkAGfo4UK/KCQMgnhoy6OMiNEcIi1pnRtjMkqsxVB4ZPBaF06spkJKCApappMa4071qJRMkuCX/nQtawwX3YrHEG60j4049ypVLw1wPR9II= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=R7DittGS DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A303E4B99F54 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788892091; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0CmkFHwOeTn6DS1L5wxvcWhI95TExbN/bDAkT9L1Ng0=; b=R7DittGStulej/ML6ELjkBKW9FsDvocUQ6XPEY5rll49x+eSbLHSBC3+UCZdWKMCJxyMru FQclZbZQhmOtESPu1PDYYpvDhu31KtFDZqMzpGPOgXBHHA2ELgxYepKF52HTL3hS4hlxmI EhF+iSc99dofubd0yiyM9H2/Dy/TaAA= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-303-cLAgf8a6M6yDKiQJvA7Cww-1; Tue, 08 Sep 2026 14:28:08 -0400 X-MC-Unique: cLAgf8a6M6yDKiQJvA7Cww-1 X-Mimecast-MFC-AGG-ID: cLAgf8a6M6yDKiQJvA7Cww_1788892087 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 79DB0195422A; Tue, 8 Sep 2026 18:28:07 +0000 (UTC) Received: from f44-mesa-1 (unknown [10.22.80.33]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5D0B91800598; Tue, 8 Sep 2026 18:28:06 +0000 (UTC) Date: Tue, 8 Sep 2026 11:28:02 -0700 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: simon.marchi@polymtl.ca Subject: Re: [PATCH v2 13/19] gdb: move ada-exp-parser.y's support code to ada-exp-parser.c Message-ID: <20260908112802.3630e0dc@f44-mesa-1> In-Reply-To: <20260905042353.1702204-14-simon.marchi@polymtl.ca> References: <20260905042353.1702204-1-simon.marchi@polymtl.ca> <20260905042353.1702204-14-simon.marchi@polymtl.ca> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: GuFUHa805i0r-7fE2f3nl56OP91Vh9aAFOGA7ZsJM9o_1788892087 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Sat, 5 Sep 2026 00:23:16 -0400 simon.marchi@polymtl.ca wrote: > diff --git a/gdb/ada-exp-parser.y b/gdb/ada-exp-parser.y > index 433293d22ad9..0a629f82cc86 100644 > --- a/gdb/ada-exp-parser.y > +++ b/gdb/ada-exp-parser.y > @@ -40,412 +40,19 @@ > #include "value.h" > #include "parser-defs.h" > #include "language.h" > +#include "ada-exp-parser.h" > #include "ada-lang.h" > #include "frame.h" > #include "block.h" > #include "ada-exp.h" > +#include "ada-exp-parser.h" > #include "cli/cli-style.h" Nit: ada-exp-parser.h is included twice here. (Found by AI.) My AIs (GLM 5.3 Flash and Claude Opus for detailed patch review) checked the rest of the series, including build and regression testing. No problems found except for the above nit. You still have my approval for the entire series: Approved-By: Kevin Buettner