From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id nXVzIGqmnmqA6jMAWB0awg (envelope-from ) for ; Mon, 07 Sep 2026 07:56:26 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=X/7PWqfn; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 713861E091; Mon, 07 Sep 2026 07:56:26 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 524B31E091 for ; Mon, 07 Sep 2026 07:56:25 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 26BE048FDC86 for ; Mon, 7 Sep 2026 11:56:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 26BE048FDC86 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=X/7PWqfn Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by sourceware.org (Postfix) with ESMTPS id B35AE4BA79A7 for ; Mon, 7 Sep 2026 11:55:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B35AE4BA79A7 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B35AE4BA79A7 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=198.175.65.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788782145; cv=none; b=gvSmvhSBbl2oKnFW7v4FaW0/ek5UXR4rBbSkBcv22kEjKG7gAlG4IzYbmzgHvlpU7s14RI6vQfxPyzjVhOxL88cNRPYN+wtv4v7dv4CVY9ni2yUu//yztC7+ebMvPRFCI9JHsbKUZeCd+zjs5Yw4q5CYbZNOzmvA9qCHLuyGsr0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788782145; c=relaxed/simple; bh=6N1lcvhdC9HlTnqvCbkgHljGIlHRPJXhwm0ijJn5x28=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=dVkKdjLjRDakdqFeiBMVqtP9qqyPbbgO2QzNaNs+D4KUQ39x4IDPbLr6s6PRFl24zeqvZfvFZblQS2ah8mqjn77nqbuKYj57scP49ztwmusjBuiEyVrJ/dzmcz7b1tiHWz1R2mxd3oPL9DNOEHe5G7r6DFz/pVjYX1KMputJQ9M= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=X/7PWqfn DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B35AE4BA79A7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1788782145; x=1820318145; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=6N1lcvhdC9HlTnqvCbkgHljGIlHRPJXhwm0ijJn5x28=; b=X/7PWqfnKk0Q5LaRG7dpFX81WUkXBPOa4zD+0zyxqv3mWi7/GqWyDdkC A0h8WtMV0ncqAo9zeM35+JRoIV//0U7o6dysYJbYUw0tEfSw6FkoW1htX SvXNe171H29b+JsxPa9ctoeVwaLuWRshuDdJBIehi0pWw2GfLE5BdR0fM G7phqQO/6CyTrxszzvg91UM2YlXy8EU7KquLbEmJ4UWFqD5NNCWKvhHiz UFxVUOYrOUrLRu4M9HIQUIBuKohWfpje9fl5EgNViXw9uwXp/SeG3myWI yVvFj+htgWoHBur3t0m6yshstrkKFfY0pzATiaHqx1RknkoUunxj8m0P4 w==; X-CSE-ConnectionGUID: lVhW7POjSIyTMrKNx6v91g== X-CSE-MsgGUID: vUkuip3yRbm97x6SMguEgg== X-IronPort-AV: E=McAfee;i="6800,10657,11898"; a="99517459" X-IronPort-AV: E=Sophos;i="6.25,267,1779174000"; d="scan'208";a="99517459" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2026 04:55:44 -0700 X-CSE-ConnectionGUID: fbzUmC2ZT22CW98S1fvOWQ== X-CSE-MsgGUID: lTCXoBbaQou+BCtF8xrJoA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,267,1779174000"; d="scan'208";a="264496071" Received: from dut1583dg2frd.igk.intel.com (HELO localhost) ([10.211.179.243]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2026 04:55:42 -0700 From: Klaus Gerlicher To: gdb-patches@sourceware.org Cc: tom@tromey.com, aburgess@redhat.com, eliz@gnu.org, guinevere@redhat.com Subject: [PATCH v9 0/6] gdb: refine scheduler locking settings Date: Mon, 7 Sep 2026 11:55:31 +0000 Message-Id: <20260907115537.307049-1-klaus.gerlicher@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org From: "Gerlicher, Klaus" Hi Andrew, Tom, Eli, This is version 9 of the patch series to refine scheduler locking settings in GDB. For this version I took the time to get fully acquainted with the patch series. In previous iterations my role had largely been limited to forwarding and rebasing the work; this time I reviewed all patches in depth, addressed Andrew's outstanding comments, and made a number of additional fixes and documentation improvements as listed below, hoping I covered every single one properly now. Previous versions: V8: https://inbox.sourceware.org/gdb-patches/20260722102746.131536-1-klaus.gerlicher@intel.com/ V7: https://inbox.sourceware.org/gdb-patches/20260325134328.550990-1-klaus.gerlicher@intel.com/ V6: https://inbox.sourceware.org/gdb-patches/20260204133753.547281-1-klaus.gerlicher@intel.com/ V5: https://inbox.sourceware.org/gdb-patches/20260129095918.2216661-1-klaus.gerlicher@intel.com/ V4: https://inbox.sourceware.org/gdb-patches/20251205135851.2581702-1-klaus.gerlicher@intel.com/ V3: https://inbox.sourceware.org/gdb-patches/20250811132321.486911-1-klaus.gerlicher@intel.com/ Changes since V8: ----------------- * Patch 3/6: - Fixed bug: V8 passed `arg` to the callback but `arg` had already been advanced by option parsing. V9 saves `org_arg` before any processing and passes that instead. - Added set-callback infrastructure in maint-test-settings.c so that the callbacks print their received argument. - Added tests in gdb.base/settings.exp and gdb.base/with.exp to verify the callback receives the correct original argument. * Patch 5/6: - Restored outer parentheses in return statement of schedlock_applies_to_opts that were inadvertently removed. * Patch 6/6: - Merged two separate comment blocks in clear_proceed_status into one. - Removed default argument from schedlock_applies_to_opts; added explicit nullptr with explanatory comment at the call site. - Documented that 'eval' controls direct user inferior calls and GDB-triggered calls (display expressions, pretty-printers), but does NOT affect breakpoint/watchpoint condition evaluation, which always runs on the thread that triggered the breakpoint. - Updated introductory doc paragraph to list the three independently controllable categories: stepping, continuing, and inferior function calls. - Fixed TCL test loop style: for/incr idiom per GDB testsuite conventions. - Fixed duplicate test name warnings in schedlock.exp. - Fixed return type of some_function in schedlock.c from void to int to allow use in breakpoint conditions. - Removed stray blank lines in schedlock.c. - Fixed "normal mode" wording in NEWS and documentation to "outside replay mode" for clarity. * All patches: - Removed non-standard "Contributed-by:" tags. Approval status: Patches 1-2/6: Approved-By: Andrew Burgess https://inbox.sourceware.org/gdb-patches/87zfiu6omc.fsf@redhat.com/ Patch 1/6: Also approved by Tom Tromey https://inbox.sourceware.org/gdb-patches/87a4xu9733.fsf@tromey.com/ Patch 3/6: (Tom's approval from V8 was invalidated by the bug Andrew found; V9 fixes the bug and needs re-review) Patch 4/6: (unchanged from V5, needs review) https://inbox.sourceware.org/gdb-patches/20260129095918.2216661-5-klaus.gerlicher@intel.com/ Patch 5/6: Reviewed-By: Eli Zaretskii (documentation parts) https://inbox.sourceware.org/gdb-patches/86ttb4t6kz.fsf@gnu.org/ Patch 6/6: Reviewed-By: Eli Zaretskii (documentation parts) https://inbox.sourceware.org/gdb-patches/86ldx8t6ex.fsf@gnu.org/ Overall series (V8): Reviewed-By: Guinevere Larsen https://inbox.sourceware.org/gdb-patches/bc6fd851-29c1-436e-a833-a53c0cf5a18d@redhat.com/ Thanks to all reviewers for their thorough feedback. Best regards, Klaus Natalia Saiapova (6): gdb: use schedlock_applies in user_visible_resume_ptid. gdb, cli: remove left-over code from "set_logging_on". gdb, cli: pass the argument of a set command to its callback. gdb: change the internal representation of scheduler locking. gdb: refine commands to control scheduler locking. gdb: add eval option to lock the scheduler during infcalls. gdb/NEWS | 30 ++ gdb/cli/cli-logging.c | 5 - gdb/cli/cli-setshow.c | 4 +- gdb/doc/gdb.texinfo | 89 +++- gdb/infrun.c | 467 +++++++++++++++--- gdb/maint-test-settings.c | 33 +- gdb/testsuite/gdb.base/settings.exp | 113 +++-- gdb/testsuite/gdb.base/with.exp | 3 +- .../gdb.mi/user-selected-context-sync.exp | 29 +- .../gdb.threads/hand-call-in-threads.exp | 12 +- .../multiple-successive-infcall.exp | 7 +- gdb/testsuite/gdb.threads/schedlock.c | 3 +- gdb/testsuite/gdb.threads/schedlock.exp | 164 +++++- gdb/testsuite/lib/gdb.exp | 77 ++- 14 files changed, 869 insertions(+), 167 deletions(-) -- 2.34.1 ________________________________________ Intel Deutschland GmbH Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany Tel: +49 (89) 99143-0 www.intel.de Managing Directors: Candice Moore, Jeffrey Schneiderman, Ramachandran Sitaraman Chairperson of the Supervisory Board: Sonja Pierer Registered Seat: Munich Commercial Register B: Amtsgericht Munich HRB 186928 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.