Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [PATCH 1/2] [gdb] Document word regexp choice in pyproject.toml
Date: Fri,  4 Sep 2026 19:39:32 +0200	[thread overview]
Message-ID: <20260904173935.16461-1-tdevries@suse.de> (raw)

The codespell tool has an option regex that can be used to control what it
considered a word.

An open question is whether dropping dash or underscore from that regexp is a
good tradeoff in terms of amount of true and false positives.

Document this issue in detail in pyproject.toml.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34241
---
 gdb/pyproject.toml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/gdb/pyproject.toml b/gdb/pyproject.toml
index 47704bb0048..32f14f13f3e 100644
--- a/gdb/pyproject.toml
+++ b/gdb/pyproject.toml
@@ -151,3 +151,13 @@ ignore-multiline-regex = 'codespell:ignore-begin.*?codespell:ignore-end'
 # Add 1 (disable warnings about wrong encoding) in addition to the default
 # 2+32 to skip warnings about iso-8859-1 encoded files.
 quiet-level = 35 # 1+2+32
+
+# For regex we currently use the default value, which since v2.2.6 corresponds
+# to: regex = '''[A-Za-z0-9_'’-]+''' .
+#
+# Dropping the underscore or dash exposes us to more true and false positives.
+# It remains to be seen whether that's a good tradeoff.
+#
+# A related issue ( https://github.com/codespell-project/codespell/issues/1508
+# ) is the fact that using a non-default regex is not compatible with -w, which
+# is a convenient way to fix codespell errors.

base-commit: 881f1e8384b69f2dcf832b29eb7cf8fe7a1fae1a
-- 
2.51.0


             reply	other threads:[~2026-09-04 17:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-04 17:39 Tom de Vries [this message]
2026-09-04 17:39 ` [PATCH 2/2] [gdb] Fix some typos Tom de Vries
2026-09-04 19:45   ` Eli Zaretskii
2026-09-09 11:49     ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260904173935.16461-1-tdevries@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox