From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AV49D0OSmmr7/ScAWB0awg (envelope-from ) for ; Fri, 04 Sep 2026 05:41:23 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ia+r0Pyw; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=kHrGbS7L; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=EnEoCNFM; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=oCGOzquF; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 361881E09B; Fri, 04 Sep 2026 05:41:23 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 452271E09B for ; Fri, 04 Sep 2026 05:41:22 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8722B4C900E5 for ; Fri, 4 Sep 2026 09:41:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8722B4C900E5 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ia+r0Pyw; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=kHrGbS7L; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=EnEoCNFM; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=oCGOzquF Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 649E34C318B6 for ; Fri, 4 Sep 2026 09:39:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 649E34C318B6 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 649E34C318B6 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788514749; cv=none; b=jFzCjpcinVuI9tSBB0S2JszjkkQRLURMaL9Cj62ZcVb6PsiqxBquOUiIeniXP1kj5lvEAk6BUrREO2ImS5bbBrcLg5aZBQ58k8KAYO/dykSqTC3MSMhLjM7xBGj8hw2+qFIUzb1VboASkoku9E0/iRpBVEyeSaPLGcN7qHP7Jtk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788514749; c=relaxed/simple; bh=xdr4P4J/wCCQqy0UDmgHRA3TvWr1F5M3cNUzRdhmaQ4=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=aITmD9/S7Agp+8E60gBHWeW60zocZt7ap3iTaH8ED/Ak4uuEAxiqzZzLPhA0YepVfufp6PUNhIr23y0vY1pI/kVa8TsbRGjDooL3jDPWMUVVYsi7bEVwcuv9PKXTAKpUln/peeO4EiTxN4CDNzbWIRnkGH0B8KW3gCMtvcKj/9s= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ia+r0Pyw; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=kHrGbS7L; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=EnEoCNFM; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=oCGOzquF DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 649E34C318B6 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2765E22C8F for ; Fri, 4 Sep 2026 09:39:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1788514744; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x53wGs3Qc75QMJ03L9wHsOJKO9eDF/7JhEuLv1J3Xus=; b=ia+r0Pyw5MHNb5TlL+CUgjWp/uv6GS7dAH/SIJ0tyGk01Afg2hVVOhZM5sNaqlXYvPaMdU l/JztykKtIkDnDXmcMeiUrXvwMvUl3gkpNe+wI+HOBhHxGl7zkbE3gdvDh7aqAOLmL8bRV Yss1PEJntPZwAMoI9WOxaLRKENXDGxA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1788514744; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x53wGs3Qc75QMJ03L9wHsOJKO9eDF/7JhEuLv1J3Xus=; b=kHrGbS7LcODbjeLFfr1tGSdAJihzwsAqx5c09KE1vkOJHPpQvpv301kP8iF3hWDMcgJwYo He+HRKCZ5UQbglDQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=EnEoCNFM; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=oCGOzquF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1788514740; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x53wGs3Qc75QMJ03L9wHsOJKO9eDF/7JhEuLv1J3Xus=; b=EnEoCNFMFlYBAHJwhCvq31YUrnAwZcIzbdIe6gBKJpzDcPDQNuLgfFOlAVIEgFGCGXtaTT hVqMbrmIqh1mERRMakVBqftkJBLhALoyvXPyMCc87/mvrrvB1i0124ZCF7Il7AhZozS+Uf dCoMtVqw4xesHgXrky66sIo9T5h8rtE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1788514740; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x53wGs3Qc75QMJ03L9wHsOJKO9eDF/7JhEuLv1J3Xus=; b=oCGOzquFROyAWSzE3kjNoj7+Fa17ZBBFSExeTayAeIoaqs23j99eFAulCPRkOFEFh+nqYK iEsyFNahbMeUq9CQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B07CA13886 for ; Fri, 4 Sep 2026 09:38:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id AIa+KbORmmqyFQAAD6G6ig (envelope-from ) for ; Fri, 04 Sep 2026 09:38:59 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [RFC 5/5] [gdb/testsuite] Reformat gdb.ada Date: Fri, 4 Sep 2026 11:38:55 +0200 Message-ID: <20260904093858.359604-5-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260904093858.359604-1-tdevries@suse.de> References: <20260904093858.359604-1-tdevries@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 2765E22C8F X-Spamd-Result: default: False [-3.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_ONE(0.00)[1]; DWL_DNSWL_BLOCKED(0.00)[suse.de:dkim]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org The gdb/testsuite/gdb.ada directory was recently (Dec 2025) reindented by commit 6779faa9cea ("Reindent gdb.ada tests"). So this is a good candidate to see the impact of the indent-exp approach. Run: ... $ pre-commit run \ --hook-stage manual \ indent-exp \ --files $(find gdb/testsuite/gdb.ada -type f -name "*.exp*") ... In gdb.ada/ptype_field.exp, a comment looking like this is fixed: ... # foo \ # bar ... to: ... # foo \ # bar ... The change results in excessive indentation in gdb.ada/var_shadowing.exp. Manually fix this using: ... -gdb_test "info locals" [multi_line \ +gdb_test "info locals" \ + [multi_line \ ... and reformat the same test to be more typical. --- gdb/testsuite/gdb.ada/non-ascii-latin-3.exp | 2 +- gdb/testsuite/gdb.ada/ptype_field.exp | 8 ++++---- gdb/testsuite/gdb.ada/var_shadowing.exp | 13 +++++++------ 3 files changed, 12 insertions(+), 11 deletions(-) diff --git a/gdb/testsuite/gdb.ada/non-ascii-latin-3.exp b/gdb/testsuite/gdb.ada/non-ascii-latin-3.exp index fd4cd5f064c..8dd422cfb7b 100644 --- a/gdb/testsuite/gdb.ada/non-ascii-latin-3.exp +++ b/gdb/testsuite/gdb.ada/non-ascii-latin-3.exp @@ -67,4 +67,4 @@ gdb_test break_2 "Breakpoint $decimal .*" \ "gdb_breakpoint: set breakpoint at func_ż" gdb_test print_3 "warning: charset conversion failure.*" \ - "print var_𝕯" + "print var_𝕯" diff --git a/gdb/testsuite/gdb.ada/ptype_field.exp b/gdb/testsuite/gdb.ada/ptype_field.exp index e808b8492bb..4e326a7ca98 100644 --- a/gdb/testsuite/gdb.ada/ptype_field.exp +++ b/gdb/testsuite/gdb.ada/ptype_field.exp @@ -64,10 +64,10 @@ gdb_test "complete ptype pck.c" "ptype pck\\.circle" # We can't query the members of a package yet, and this yields a bit # too much output, so comment out for now instead of kfailing. -# gdb_test "complete ptype pck." \ - # [multi_line \ - # "ptype pck\\.circle" \ - # "ptype pck\\.position"] +# gdb_test "complete ptype pck." \# +# [multi_line \# +# "ptype pck\\.circle" \# +# "ptype pck\\.position"] gdb_test "complete ptype circle.pos." \ [multi_line \ diff --git a/gdb/testsuite/gdb.ada/var_shadowing.exp b/gdb/testsuite/gdb.ada/var_shadowing.exp index ffa96b049cf..468485b118f 100644 --- a/gdb/testsuite/gdb.ada/var_shadowing.exp +++ b/gdb/testsuite/gdb.ada/var_shadowing.exp @@ -20,7 +20,7 @@ require allow_ada_tests standard_ada_testfile var_shadowing if {[gdb_compile_ada "${srcfile}" "${binfile}" \ - executable [list debug]] != "" } { + executable [list debug]] != "" } { return } @@ -32,8 +32,9 @@ set i_level3 [gdb_get_line_number "I-Level3"] set bp_location [gdb_get_line_number "BREAK"] runto "var_shadowing.adb:$bp_location" -gdb_test "info locals" [multi_line \ - "i = 111\t<$testfile.adb:$i_level3>" \ - "i = 11\t<$testfile.adb:$i_level2, shadowed>" \ - "i = 1\t<$testfile.adb:$i_level1, shadowed>" \ -] "info locals at innermost level" +gdb_test "info locals" \ + [multi_line \ + "i = 111\t<$testfile.adb:$i_level3>" \ + "i = 11\t<$testfile.adb:$i_level2, shadowed>" \ + "i = 1\t<$testfile.adb:$i_level1, shadowed>"] \ + "info locals at innermost level" -- 2.51.0