Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [pushed 3/3] [gdb] Fix dont -> don't typo
Date: Thu,  3 Sep 2026 07:47:22 +0200	[thread overview]
Message-ID: <20260903054722.1461007-3-tdevries@suse.de> (raw)
In-Reply-To: <20260903054722.1461007-1-tdevries@suse.de>

Result of:
...
$ find gdb* -type f | xargs sed -i "s/ dont / don't /"
...
and manually fixing two hits of ' dont.'

The "dont->don't" rule is part of the code dictionary:
...
- 'code' for words from code and/or mathematics that are likely to be typos
  in other contexts (such as uint)
...
but it tries to rewrite stdio into studio, so we'll leave that disabled.

We do have a fair amount of dont_<something> in our sources, so I'm not adding
this as a rule in gdb/contrib/codespell-dictionary.txt.  It doesn't hurt us
now, but it does if we start playing with the word regexp [1].

[1] https://sourceware.org/bugzilla/show_bug.cgi?id=34241
---
 gdb/arm-tdep.c                             | 2 +-
 gdb/dwarf2/loc.c                           | 4 ++--
 gdb/m32r-tdep.c                            | 2 +-
 gdb/mips-tdep.c                            | 2 +-
 gdb/stubs/m68k-stub.c                      | 2 +-
 gdb/testsuite/gdb.base/skip-inline.exp     | 2 +-
 gdb/testsuite/gdb.reverse/step-reverse.exp | 2 +-
 gdbsupport/event-loop.cc                   | 2 +-
 8 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c
index 7ac544c3bbf..bffd5d22199 100644
--- a/gdb/arm-tdep.c
+++ b/gdb/arm-tdep.c
@@ -11546,7 +11546,7 @@ arm_record_extension_space (arm_insn_decode_record *arm_insn_r)
 	      if (0 == insn_op1 || 1 == insn_op1)
 		{
 		  /* SMLA<x><y>, SMLAW<y>, SMULW<y>.  */
-		  /* We dont do optimization for SMULW<y> where we
+		  /* We don't do optimization for SMULW<y> where we
 		     need only Rd.  */
 		  record_buf[0] = bits (arm_insn_r->arm_insn, 12, 15);
 		  record_buf[1] = ARM_PS_REGNUM;
diff --git a/gdb/dwarf2/loc.c b/gdb/dwarf2/loc.c
index 8e2b401ba34..15336aaf017 100644
--- a/gdb/dwarf2/loc.c
+++ b/gdb/dwarf2/loc.c
@@ -2161,7 +2161,7 @@ dwarf2_get_symbol_read_needs (gdb::array_view<const gdb_byte> expr,
 					     get_frame_pc);
 
 	    /* If SYMBOL_NEEDS_FRAME is returned from the previous call,
-	       we dont have to check the baton content.  */
+	       we don't have to check the baton content.  */
 	    if (symbol_needs != SYMBOL_NEEDS_FRAME)
 	      {
 		gdbarch *arch = baton.per_objfile->objfile->arch ();
@@ -2212,7 +2212,7 @@ dwarf2_get_symbol_read_needs (gdb::array_view<const gdb_byte> expr,
 					       get_frame_pc, true);
 
 	    /* If SYMBOL_NEEDS_FRAME is returned from the previous call,
-	       we dont have to check the baton content.  */
+	       we don't have to check the baton content.  */
 	    if (symbol_needs != SYMBOL_NEEDS_FRAME)
 	      {
 		gdbarch *arch = baton.per_objfile->objfile->arch ();
diff --git a/gdb/m32r-tdep.c b/gdb/m32r-tdep.c
index b5792eeeafc..d881f33c057 100644
--- a/gdb/m32r-tdep.c
+++ b/gdb/m32r-tdep.c
@@ -289,7 +289,7 @@ decode_prologue (struct gdbarch *gdbarch,
       if (insn == 0x0000)
 	break;
 
-      /* If this is a 32 bit instruction, we dont want to examine its
+      /* If this is a 32 bit instruction, we don't want to examine its
 	 immediate data as though it were an instruction.  */
       if (current_pc & 0x02)
 	{
diff --git a/gdb/mips-tdep.c b/gdb/mips-tdep.c
index fe0482fe5bf..2a60d6ef097 100644
--- a/gdb/mips-tdep.c
+++ b/gdb/mips-tdep.c
@@ -2120,7 +2120,7 @@ micromips_next_pc (struct regcache *regcache, CORE_ADDR pc)
 /* Decoding the next place to set a breakpoint is irregular for the
    mips 16 variant, but fortunately, there fewer instructions.  We have
    to cope ith extensions for 16 bit instructions and a pair of actual
-   32 bit instructions.  We dont want to set a single step instruction
+   32 bit instructions.  We don't want to set a single step instruction
    on the extend instruction either.  */
 
 /* Lots of mips16 instruction formats */
diff --git a/gdb/stubs/m68k-stub.c b/gdb/stubs/m68k-stub.c
index cbea4772fc7..a5ec9bce088 100644
--- a/gdb/stubs/m68k-stub.c
+++ b/gdb/stubs/m68k-stub.c
@@ -486,7 +486,7 @@ _returnFromException (Frame * frame)
       frame = lastFrame;
       frame->frameSize = 4;
       frame->format = 0;
-      frame->fsaveHeader = -1;	/* restore regs, but we dont have fsave info */
+      frame->fsaveHeader = -1;	/* restore regs, but we don't have fsave info */
     }
 
 #if !defined (mc68020) && !defined (mc68332)
diff --git a/gdb/testsuite/gdb.base/skip-inline.exp b/gdb/testsuite/gdb.base/skip-inline.exp
index a0223efa2eb..d15ba556044 100644
--- a/gdb/testsuite/gdb.base/skip-inline.exp
+++ b/gdb/testsuite/gdb.base/skip-inline.exp
@@ -94,7 +94,7 @@ gdb_test "skip function foo" "Function foo will be skipped when stepping\."
 single_step
 
 # Some compilers link the epilogue of functions to the line containing the
-# closing brace, while others dont.  The behavior ends up so out of sync
+# closing brace, while others don't.  The behavior ends up so out of sync
 # with multiple steps at a time, that completely different procs would need
 # to be made, and it is frankly unnecessary.
 if {$epilogue} {
diff --git a/gdb/testsuite/gdb.reverse/step-reverse.exp b/gdb/testsuite/gdb.reverse/step-reverse.exp
index d72638c9169..66ae378a153 100644
--- a/gdb/testsuite/gdb.reverse/step-reverse.exp
+++ b/gdb/testsuite/gdb.reverse/step-reverse.exp
@@ -174,7 +174,7 @@ gdb_test_multiple "stepi" "$test_message" {
 
 # stepi backward out of a function call
 
-# When testing stepi, we dont want to infinitely step if we're not moving
+# When testing stepi, we don't want to infinitely step if we're not moving
 # so we store the starting PC, in case we land on the same line as above
 set start_pc [get_hexadecimal_valueof "\$pc" 0 "get PC at start"]
 set get_pc_count 0
diff --git a/gdbsupport/event-loop.cc b/gdbsupport/event-loop.cc
index c6e1b5b4634..b7217282110 100644
--- a/gdbsupport/event-loop.cc
+++ b/gdbsupport/event-loop.cc
@@ -623,7 +623,7 @@ gdb_wait_for_event (int block)
 	  FD_ZERO (&gdb_notifier.ready_masks[1]);
 	  FD_ZERO (&gdb_notifier.ready_masks[2]);
 
-	  /* Dont print anything if we got a signal, let gdb handle
+	  /* Don't print anything if we got a signal, let gdb handle
 	     it.  */
 	  if (errno != EINTR)
 	    perror_with_name (("select"));
-- 
2.51.0


      parent reply	other threads:[~2026-09-03  5:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-03  5:47 [pushed 1/3] [gdb] Fix some typos Tom de Vries
2026-09-03  5:47 ` [pushed 2/3] [gdb] Fix double words Tom de Vries
2026-09-03  5:47 ` Tom de Vries [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260903054722.1461007-3-tdevries@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox