From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gWOsFgNDmGrHHx8AWB0awg (envelope-from ) for ; Wed, 02 Sep 2026 11:38:43 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=Z7uOk7u9; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 463F91E033; Wed, 02 Sep 2026 11:38:43 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 596A61E033 for ; Wed, 02 Sep 2026 11:38:42 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 198A54B9DB65 for ; Wed, 2 Sep 2026 15:38:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 198A54B9DB65 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=Z7uOk7u9 Received: from mail-oa1-x2a.google.com (mail-oa1-x2a.google.com [IPv6:2001:4860:4864:20::2a]) by sourceware.org (Postfix) with ESMTPS id 1B5DC4BA901E for ; Wed, 2 Sep 2026 15:38:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1B5DC4BA901E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1B5DC4BA901E Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2001:4860:4864:20::2a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788363498; cv=none; b=Lu7NEpweXbmY+Dift5FIwQDIza8stKUV8XUAFPIXEShEztKrBf5RnV8ZxTOr56xBFCdbB3TXL4rmTqsKbcR0yFZU1ESLwLFWGWlcpSzhIOKR4uix7tCeP8ehDU8ADcmAkJ1Z6OYFmqL5ZA2xOueri9ImtUb5u6F2AeEGxjGSH9c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788363498; c=relaxed/simple; bh=GqrzMvK3k4bTefUWfKvTuLXLnaMonaP+GSqclZDpxto=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=dPeDCe3uVDUxfypFXlEcZVtoZW1UMVM2+1agtiHFXog+lkEp5JN2aVuG2X1lBifIvFLxBjHCxZdXU7i42p8F4QoxLg9KQ3Ed3WlTwfLzUhZnVUrAC7W9/Au8carFUF98UbsdH81WmISRUS0qQGz0mc7lRqBi/wj8So68LXfY6aU= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=Z7uOk7u9 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1B5DC4BA901E Received: by mail-oa1-x2a.google.com with SMTP id 586e51a60fabf-46aef6e48fbso760964fac.3 for ; Wed, 02 Sep 2026 08:38:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1788363496; x=1788968296; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=OfDD+PClxs7AGaqVEIRZZmkroOkUN8D/y/udKRDDgCU=; b=Z7uOk7u9Gsz0A2EcdgLpWAvzbh9rEdbkIZuhb6kaQ5PJHcvwnPQTi6e6+5+YQEGcYD h/IeC9rT9Pl9n3gbzbfBCYaKNbZbCETjyhYhJveZg7lXcogZnI66737ZgcMu9NwcA7px LSyCtzziVrIfVcnT2BGx4bVNLcuEXSJ+Lj1BdDVN+PbcYGkVFxuLP3KCT/fAH67gn0rQ vjP44Qx0OVv2oyAChM8HyYjOPMucePJm34kWb+ql7SFscmmEmTPBZu3R01rhq/Jalqoi eNgnI6ZMEVYT7RzHH1TFxWs00eRNSu1lKApsrgxOZWtgSzQjJ1apZEEBgycjKSqwfO0H /GbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788363496; x=1788968296; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OfDD+PClxs7AGaqVEIRZZmkroOkUN8D/y/udKRDDgCU=; b=QficUzESN1qH8fvhBKtULoXfGKaJjiknKvNKelJDOXghBN3pxC6F5J32OBaBn6SfxP aakdtn3mLGeJSt5OnVj3+7GKzmHyHZXdl9YaOu4ZAvoqW0Eys8SjgQvtwcmqH/hvyoXy sDrT4pq+qvrzSKKnJs+ILnoXYt0cjEvpz5CicNHqyKK2XpJxHvmTnhxQdFDQNpOaNP5o 9THH4EDEiWmc+KIClM+R+ZZnpJuxVb5lN6wZHIZuT2jhX3cZpQM9kKjttTTOGC2pfWqd O7i8DZZu7akTvsMyuzmb/SmitTXxCdlJAOc1nTaNWEGN/GR7UG3OsgJMotEv+Cdc1rvG blaA== X-Gm-Message-State: AFuF++lrjOdt6OFOMDNcJpgH9ePftP7TWUm9jIZCgWfiGMCthLvOIcG5 Dv+LAxUo+TlYz19ZFMITjI6LYGulUdqRyAFd7EFbZvm6/u2rI8LP6o2O9tcdFM/b8vvtr+SUD5c eXA3qYw== X-Gm-Gg: AYBFou2LVnKbP7H/l9G0PEloyptYtqbMeOgA7NIZM5gWpeMV5+Mt85AerfjGx5cD0qd xAIYI+FLFCrWg93MPnX4NEEE+QPRW88KKHjz+mhT+Id+sQM+jFFQx7WXSr27tt42z5q2ILLpgma h1yBSnX+/eQkLyBesevYx9p82h02fBZzlTEJft6pmwywQVUQR5GL9W8vpaTMlWJnE6EsY+AeAEO 6pio8CrWrX2TS0XchR1uPoszhngxS5DjMflyV5Utr+n96U9pKMWdZeRCCmUQI2KVzLUPsqBlUJV /wAESDm2K3TZNZ9YTd6oHV9TdkiD5zssIzD91wHV5h88YGkBrJbsPkJKoAGnoOrjHltrdEHr2YU F1P/ECtXEaKZymvlGoe1woltVeLT18jJO4e6lfaq7/pLRRGVJ0OgapmiNqFVCujynR1yW0TImU6 FDP/Pg1+Pg/9WdthdKbroTf8LTTGB2CUh5D3Z3NTSbzWPNy0BncoffJYPdWimotnkwAe5ogH+Vs DhPPQ== X-Received: by 2002:a05:6870:d8d2:b0:45e:25a9:5455 with SMTP id 586e51a60fabf-46f8788656amr4142195fac.2.1788363496589; Wed, 02 Sep 2026 08:38:16 -0700 (PDT) Received: from bapiya (97-122-117-2.hlrn.qwest.net. [97.122.117.2]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-46f336c72fdsm3484644fac.17.2026.09.02.08.38.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2026 08:38:16 -0700 (PDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [pushed] Minor indentation fix in gdb/nat/windows-nat.h Date: Wed, 2 Sep 2026 09:38:13 -0600 Message-ID: <20260902153813.3486662-1-tromey@adacore.com> X-Mailer: git-send-email 2.55.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I noticed a comment in gdb/nat/windows-nat.h was not indented correctly. This patch fixes it. --- gdb/nat/windows-nat.h | 29 ++++++++++++++--------------- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/gdb/nat/windows-nat.h b/gdb/nat/windows-nat.h index 44b628c9bd1..fcdf43e270e 100644 --- a/gdb/nat/windows-nat.h +++ b/gdb/nat/windows-nat.h @@ -155,21 +155,20 @@ struct windows_thread_info pending stop. See stop_one_thread. */ stopping_kind stopping = SK_NOT_STOPPING; -/* Info about a potential pending stop. - - Sometimes, Windows will report a stop on a thread that has been - ostensibly suspended. We believe what happens here is that two - threads hit a breakpoint simultaneously, and the Windows kernel - queues the stop events. However, this can result in the strange - effect of trying to single step thread A -- leaving all other - threads suspended -- and then seeing a stop in thread B. To handle - this scenario, we queue the "pending" stop here, and then - process it once the step has completed. See PR gdb/22992. - If we do have a pending event, its Windows event info is in - LAST_EVENT. - - TARGET_WAITKIND_IGNORE if the thread does not have a pending - stop. */ + /* Info about a potential pending stop. + + Sometimes, Windows will report a stop on a thread that has been + ostensibly suspended. We believe what happens here is that two + threads hit a breakpoint simultaneously, and the Windows kernel + queues the stop events. However, this can result in the strange + effect of trying to single step thread A -- leaving all other + threads suspended -- and then seeing a stop in thread B. To handle + this scenario, we queue the "pending" stop here, and then process + it once the step has completed. See PR gdb/22992. If we do have a + pending event, its Windows event info is in LAST_EVENT. + + TARGET_WAITKIND_IGNORE if the thread does not have a pending + stop. */ target_waitstatus pending_status; /* The last Windows event returned by WaitForDebugEvent for this base-commit: bcca68ba491d7d439875fa9b8b4df8adf17a0986 -- 2.55.0