From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id b+D4Eakml2qIrBsAWB0awg (envelope-from ) for ; Tue, 01 Sep 2026 15:25:29 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=WKzSSD7/; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 34A7B1E033; Tue, 01 Sep 2026 15:25:29 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 32DB61E033 for ; Tue, 01 Sep 2026 15:25:28 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B975A4BA799E for ; Tue, 1 Sep 2026 19:25:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B975A4BA799E Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=WKzSSD7/ Received: from mail-oo1-xc33.google.com (mail-oo1-xc33.google.com [IPv6:2607:f8b0:4864:20::c33]) by sourceware.org (Postfix) with ESMTPS id BD4904BA2E3F for ; Tue, 1 Sep 2026 19:24:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BD4904BA2E3F Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BD4904BA2E3F Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::c33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788290698; cv=none; b=FA+J+wcXX/0bwTt7oFjmpODazULVN99DuFxnWh+vc5UyTTIOGCCfeRRlDFIvbR/h+GDxizSAQx56WRNClAW0mnfwD30H4flZP+7KW40RMxicoJJ4fypJFQIAo9rZYO0QDhsqE1sZaKYzf/NVSR6J8GXzctK6u0RpKmFHQaztfVs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788290698; c=relaxed/simple; bh=QchE+HGMM89hn+uTB6AETbauNXq8aVwwTKKG8x9gn/c=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=wQijRc94Hu/aS13sge1GK5OmnLt8GIsK2h61MpSVqWBbiTwtBrsrV3I+SCS9FM9GlNEi6NN78EKErR9OJGyRl+Mv7JVBX9evJwcYZOCWYVzfsnt0dzl5OAAugE4INzNOY4eeY9KIbj93KgbzshL229Fw4VBbtW6wa/u6TSwNTJM= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=WKzSSD7/ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BD4904BA2E3F Received: by mail-oo1-xc33.google.com with SMTP id 006d021491bc7-6b128dd0cb1so140716eaf.3 for ; Tue, 01 Sep 2026 12:24:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1788290698; x=1788895498; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=YMWDxKCYkGiCyw4N2htlWkPw9m5wz73qDQjJQLrdRvg=; b=WKzSSD7/NzhTPQNJS+oEdEj8wRmaRmZw93imnSTsSg2vkwX/x2CibIjYAu5SjYudSi 77uWXTP0DCsh0EN/GwoiJECeOFaC94K5pgbn6+O5SGPtOqb3RUD2wxOioxdV378i6Ha7 Y+3E0cSi4H0tqFjNoyGQ34CZbKYD4mKKYV5rQHEkXgh6H8tbKaNLUg+vFtGrGpgT9YzP DHMKbdHq6dJ7u3ax9myCLtlVDjNVoDh9Dll6reWOvinCd8kedYlxzXXvMTmcuGe8Tr0f HqVVsXDDa1VUjiPl8pgCBoWYrRvRj+BOQYmr4HhWuEXghsJYuZ1pnuWLmHkewN2vmdij WyXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788290698; x=1788895498; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YMWDxKCYkGiCyw4N2htlWkPw9m5wz73qDQjJQLrdRvg=; b=lvQybOEVWO2uhuk/L5ITculzQKL+tZVMV0R46gkljO4s8x7ONVE1z5lKk6k5XJum0O pTE8x58cVPak+KrGPi5Wg5f4wXpecdPRKSEyJ0ic6+6q6uS47qGmevufoQGsE3yOICke gpt3/REoVVhbF13uM5mwyv6FkH13MlsjGuxLAV1jhvXDB2G5ElEWAsMuBULaGonWyWyU M5ww25JVawO6nwPIUZGfH97LeDwL+yL9nesPch9AB3gTg5POe4MFgyR7e/HtzXkbm+xJ 3fTbVLuMuSbyYvHDkd4R/edA6CBxwHX3JRzN1Rmz33OjMxf43UqPxflLAgN4pb8RGcK3 hU8A== X-Gm-Message-State: AFuF++m0whd9+BqraAJ2WuZvr8jINNh5ngHJacmlO3L79WkNsXLeIVs4 dRIuL3Avsa+226k6xXA4Tu8uwgGy1mCITpFZ93IrZzkxGE7aqUduyP+XA/X7JFRKW1fwXCjFE2x Jcb6rUw== X-Gm-Gg: AR+sD10E0sJkqxHRqDPfKUbWkF8xMQ5c0HDzL+AT6WxbvjkoF7q/TqfhMhgLXaxRtDw SU/vB0vDzmZ2muHGvCziybZrP1BlaH8+G8pUUYwKeBmkgTVonpml762r+FTyzEC+f10fI8iAqQI iM6MLC4COSHMWLprz3x1f65PiqmFhvOduznWqTBhCzYgr9KDk49Xt5NDlTOQnrjV4izRFAObmPT AW1cpF+0r/w6YtP2NGnKIi3gmC5J6JE74LetB+71hpc7T6rHtvwBfapPKKcMQzEfmbdx/0MVq2p uQBlo3NHxgNZXHg3rO2vnxbr4R9+7hociUq0Dvd/1YXmhVCDI9Nn+VHV0PrjaqK9nC7o+Ivn/30 0tx+xOB5x1j/lAy42tBpRXaGZTyOASIKiT3OviHg1SHqYOBKBDUd2xrNRWLx4p1B4yVoX/CfDE/ ZI/BdTin8W8Q860Sfxi1gHZllhVXo/9t6Gu1NbWMThdVp9mlug3xWlKXzVwflUK0ULeG96TJPX9 55M/D4akHMXQ4Rs X-Received: by 2002:a05:6820:188d:b0:6ae:aa38:a0aa with SMTP id 006d021491bc7-6b1c67d98edmr31580408eaf.32.1788290697870; Tue, 01 Sep 2026 12:24:57 -0700 (PDT) Received: from bapiya (97-122-117-2.hlrn.qwest.net. [97.122.117.2]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-46f2d4b266esm741956fac.0.2026.09.01.12.24.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2026 12:24:57 -0700 (PDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Two logging fixes to win32-low.cc Date: Tue, 1 Sep 2026 13:24:55 -0600 Message-ID: <20260901192455.3344494-1-tromey@adacore.com> X-Mailer: git-send-email 2.55.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org While debugging the Windows gdbserver, I found a couple of minor problems in some logging statements in win32-low.cc. First, one spot could call target_waitstatus::sig for the wrong kind of object, resulting in an assertion failure. Second, the "unknown" logging case can be made a bit nicer by printing a string rather than an integer. --- gdbserver/win32-low.cc | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/gdbserver/win32-low.cc b/gdbserver/win32-low.cc index 7629beca213..13c14a7c69f 100644 --- a/gdbserver/win32-low.cc +++ b/gdbserver/win32-low.cc @@ -1168,8 +1168,11 @@ win32_process_target::wait (ptid_t ptid, target_waitstatus *ourstatus, case TARGET_WAITKIND_SIGNALLED: case TARGET_WAITKIND_LOADED: { - OUTMSG2 (("Child Stopped with signal = %d \n", - ourstatus->sig ())); + if (ourstatus->kind () == TARGET_WAITKIND_LOADED) + OUTMSG2 (("Child stopped due to library load\n")); + else + OUTMSG2 (("Child stopped with signal = %d \n", + ourstatus->sig ())); maybe_adjust_pc (current_event); /* All-stop, suspend all threads until they are explicitly @@ -1179,8 +1182,8 @@ win32_process_target::wait (ptid_t ptid, target_waitstatus *ourstatus, return debug_event_ptid (¤t_event); } default: - OUTMSG (("Ignoring unknown internal event, %d\n", - ourstatus->kind ())); + OUTMSG (("Ignoring unknown internal event, %s\n", + ourstatus->to_string ().c_str ())); [[fallthrough]]; case TARGET_WAITKIND_SPURIOUS: /* do nothing, just continue */ base-commit: 6f24afa4391bd33f1263378280b99385d2c13055 -- 2.55.0