From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4ft0Iq/NlWqVRRgAWB0awg (envelope-from ) for ; Mon, 31 Aug 2026 14:53:35 -0400 Received: by simark.ca (Postfix, from userid 112) id 8817D1E166; Mon, 31 Aug 2026 14:53:35 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EF4AF1E033 for ; Mon, 31 Aug 2026 14:53:34 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BA4AC4BA9036 for ; Mon, 31 Aug 2026 18:53:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BA4AC4BA9036 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id C36E84BA2E2B for ; Mon, 31 Aug 2026 18:53:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C36E84BA2E2B Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C36E84BA2E2B Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788202390; cv=none; b=c5sDZsnum7iMqJJoCT6XY5xJGiDeEWkAVacjCTlZGpsG204PRkCEdWaOzpEjd9vNGVhY1IRMfP/GbeJBjgevZtn2VlLbpJOCqyWQ7sz3T0HI4xyBkARuvHWV2bk13pahbunDlK2Zyu3pUSN5FVZ1wKDz7V5d3BL5Ulpc0T7Iuf0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788202390; c=relaxed/simple; bh=ow2HTvYe/yDcw7LSObX6z5LYPR+WRYUpLNSsnPhJ2Uw=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=GDgPXGCfxmTdgeDYgRP4SFLxJ3/cHe+/prvvCwuGCjN32w4nWlRduJhRHo5P1hel4HaCOuaR6E0nTk2NlmQ5U92O3T4LDEeBnhNeWn4ODtb/u8FwA0jflf0Q+nALNEWjz6XcJJPnBMafTbuNQs3C1S1eUgVFRINPRKgAE9bWGQ0= ARC-Authentication-Results: i=1; sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C36E84BA2E2B Received: by simark.ca (Postfix) id C61E71E16F; Mon, 31 Aug 2026 14:53:05 -0400 (EDT) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 5/7] gdb, gdbserver: remove the .NOEXPORT target Date: Mon, 31 Aug 2026 14:51:44 -0400 Message-ID: <20260831185300.572297-6-simon.marchi@efficios.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260831185300.572297-1-simon.marchi@efficios.com> References: <20260831185300.572297-1-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org gdb/Makefile.in and gdbserver/Makefile.in both contain: # GNU Make has an annoying habit of putting *all* the Makefile variables # into the environment, unless you include this target as a circumvention. # Rumor is that this will be fixed (and this target can be removed) # in GNU Make 4.0. .NOEXPORT: This was introduced in gdb in commit 625453dcfda0 ("Merge in irix support", 1991-08-31), and copied to gdbserver's Makefile.in when it was created, in commit c033ec179a2a (1993-08-27). It was a legitimate workaround at the time, but only for a few months. GNU make commit b8d48ad379dc, from 1992-05-03, removed the handling of .NOEXPORT: - int noexport = enter_file (".NOEXPORT")->is_target; ... - /* If `.NOEXPORT' was specified, only export command-line and - environment variables. This is a temporary (very ugly) hack - until I fix this problem the right way in version 4. Ick. */ So .NOEXPORT has done nothing for any GNU make for a very long time, remove it. Change-Id: I173807df18447d3ae2f6728ccb711d43d1f9d307 --- gdb/Makefile.in | 6 ------ gdbserver/Makefile.in | 6 ------ 2 files changed, 12 deletions(-) diff --git a/gdb/Makefile.in b/gdb/Makefile.in index cdf73ec708e0..74361808bf5a 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -2604,12 +2604,6 @@ gdb.cxref: $(SFILES) force_update: -# GNU Make has an annoying habit of putting *all* the Makefile variables -# into the environment, unless you include this target as a circumvention. -# Rumor is that this will be fixed (and this target can be removed) -# in GNU Make 4.0. -.NOEXPORT: - # GNU Make 3.63 has a different problem: it keeps tacking command line # overrides onto the definition of $(MAKE). This variable setting # will remove them. diff --git a/gdbserver/Makefile.in b/gdbserver/Makefile.in index 7c6ab64196e2..5054597bf6ef 100644 --- a/gdbserver/Makefile.in +++ b/gdbserver/Makefile.in @@ -473,12 +473,6 @@ stamp-xml: $(XML_DIR)/feature_to_c.sh Makefile $(XML_FILES) .PRECIOUS: xml-builtin.cc -# GNU Make has an annoying habit of putting *all* the Makefile variables -# into the environment, unless you include this target as a circumvention. -# Rumor is that this will be fixed (and this target can be removed) -# in GNU Make 4.0. -.NOEXPORT: - # GNU Make 3.63 has a different problem: it keeps tacking command line # overrides onto the definition of $(MAKE). This variable setting # will remove them. -- 2.55.0