From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id wWfBJZ2KlGp8IhUAWB0awg (envelope-from ) for ; Sun, 30 Aug 2026 15:55:09 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=aBshYEmt; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=e7ek+o+4; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Sm2+ALaB; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=s9G+kvxa; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 91E931E166; Sun, 30 Aug 2026 15:55:09 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C21D91E033 for ; Sun, 30 Aug 2026 15:55:08 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8884F4BA23F5 for ; Sun, 30 Aug 2026 19:55:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8884F4BA23F5 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=aBshYEmt; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=e7ek+o+4; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Sm2+ALaB; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=s9G+kvxa Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id D46E24BA2E20 for ; Sun, 30 Aug 2026 19:53:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D46E24BA2E20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D46E24BA2E20 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788119606; cv=none; b=CGEY6O8Zaf3bjcw1IkMvQJFQy0uIrpieeG5dt019FChmIDmPFfn/FTvTuY8dbcJ0KYA0/BeyU3HINNbHPoaYRko3npg9Tv6q0peHJ2xpkIprNDvogOmXgw4fJG73NiZIVamHy3VolQTZphackPSGwXZFFzU2v7c2WqgBJ3/0gss= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788119606; c=relaxed/simple; bh=jnsbcSOVxAI34EcdZ+ba6NpWVJ6vjyNbwFxAjyleJKE=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=JuYbyG0QYGuYLMwxOK5rcLVTKhVxcz6NdSEWohEKA5s2qsa4kKpGCah3epZBYDDEQ46k+c2EUj0iALxIIJSAWAPHdllVArAfCM5puumGBbxbvJz5hCh8oUSxWq5IDjGkSqtNw9/DzFignOkKZvTRC5xbxwguATe6Or4WwAl4siQ= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=aBshYEmt; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=e7ek+o+4; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Sm2+ALaB; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=s9G+kvxa DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D46E24BA2E20 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9B094226A0 for ; Sun, 30 Aug 2026 19:53:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1788119600; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Eg2c+zQ+IIwTrvNN8StTxwQAi4n7E2n6M/vVM0opl5I=; b=aBshYEmtE+Ju7ATic34edAtJFM86Pp92USTtjzKqvtMgieg6gE1VJK7yLYxe64OOwcIegv HaeYXD3vXEUE9uHqzfZv4U0Zsk3yfe4hRGsbJqo1YwdswtSZx63p1Iie42oW6FSYsTTcJ6 j/cIBOHUeEWKhvDwipWfTO9okL545RU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1788119600; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Eg2c+zQ+IIwTrvNN8StTxwQAi4n7E2n6M/vVM0opl5I=; b=e7ek+o+4Jqo2ojsDjDPQtvJa28HuhXHJNPUFSkd3MIJUCtWe/fWYF4OtEbhxE3Udc1Xhnb wnCkVB/qYwsJvLAA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1788119596; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Eg2c+zQ+IIwTrvNN8StTxwQAi4n7E2n6M/vVM0opl5I=; b=Sm2+ALaBcnKISdSJwfsT/jwWsbKKQQ8GTMT5V1ALyJki29yL/Zt9BH9hgUQr3w2+UMn1cl pDX3DAKwTfL342Sxqe+Za8Lp74qS8ZMrDHe0VL4+Tq06RPDPFfglOC9w3QsN5grSiJ6VT/ 3lqLrPfYelNZ+2+U03/RsTfyFduNv/4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1788119596; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Eg2c+zQ+IIwTrvNN8StTxwQAi4n7E2n6M/vVM0opl5I=; b=s9G+kvxayfWw6RQxqMZjAXVSSGffcez6Op/fcA0P9Dt7xXvln90bcC86jjMb3w2e085h6z GS/yWSeAHsJdcgCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4652113688 for ; Sun, 30 Aug 2026 19:53:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id CA7VDyyKlGrsUgAAD6G6ig (envelope-from ) for ; Sun, 30 Aug 2026 19:53:16 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH v2 2/3] [gdb] Use shfmt on regformats/regdat.sh Date: Sun, 30 Aug 2026 21:53:14 +0200 Message-ID: <20260830195315.1497894-3-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260830195315.1497894-1-tdevries@suse.de> References: <20260830195315.1497894-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-0.995]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; RCVD_TLS_ALL(0.00)[] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Run shfmt [1] on gdb/regformats/regdat.sh: ... $ shfmt \ --language-dialect=posix \ --indent=4 \ --func-next-line \ --space-redirects \ --write \ gdb/regformats/regdat.sh ... followed by emacs whitespace-cleanup (because shfmt doesn't know about mixed tab/spaces indentation). Normalizes things like: ... if true then ... to: ... if true; then ... as suggested by Simon [2]. Also: - makes sure statements are on their own line - removes double empty line - minor whitespace changes: - do_read () -> do_read() - cat < cat << EOF [1] https://github.com/mvdan/sh [2] https://sourceware.org/pipermail/gdb-patches/2026-August/229818.html --- gdb/regformats/regdat.sh | 35 ++++++++++++++--------------------- 1 file changed, 14 insertions(+), 21 deletions(-) diff --git a/gdb/regformats/regdat.sh b/gdb/regformats/regdat.sh index 2f48c165fc8..6cac186735e 100755 --- a/gdb/regformats/regdat.sh +++ b/gdb/regformats/regdat.sh @@ -23,17 +23,14 @@ set -u # Format of the input files read="type entry" -do_read () +do_read() { type="" entry="" - while read -r line - do - if test "${line}" = "" - then + while read -r line; do + if test "${line}" = ""; then continue - elif expr "${line}" : "#" > /dev/null - then + elif expr "${line}" : "#" > /dev/null; then continue else @@ -42,21 +39,20 @@ do_read () # Work around this by eliminating ``::'' .... line="$(echo "${line}" | sed -e 's/::/: :/g' -e 's/::/: :/g')" - OFS="${IFS}" ; IFS="[:]" + OFS="${IFS}" + IFS="[:]" # Word-splitting on read variable is required. # shellcheck disable=SC2086 - eval read ${read} < new-"$3" copyright "$1" echo '#include "regdef.h"' @@ -121,8 +115,7 @@ expedite=x feature=x osabi=unknown exec < "$1" -while do_read -do +while do_read; do if test "${type}" = "name"; then name="${entry}" @@ -194,7 +187,7 @@ echo osabi_enum=$(grep "${osabi}" "$2" | sed 's/.*(\([^,]\+\),.*/GDB_OSABI_\1/') -cat <xmltarget = xmltarget_${name}; #endif -- 2.51.0