From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id sZPaIpl5kWoWMgsAWB0awg (envelope-from ) for ; Fri, 28 Aug 2026 08:05:45 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Z08eWKJn; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=EsiflpCF; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=GIhXXHHB; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=rQdl4onm; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 82E961E166; Fri, 28 Aug 2026 08:05:45 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5B8A81E033 for ; Fri, 28 Aug 2026 08:05:44 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5268A4BA2E18 for ; Fri, 28 Aug 2026 12:05:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5268A4BA2E18 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Z08eWKJn; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=EsiflpCF; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=GIhXXHHB; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=rQdl4onm Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 7C5084BA2E08 for ; Fri, 28 Aug 2026 12:04:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7C5084BA2E08 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7C5084BA2E08 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787918689; cv=none; b=Gr7ken7opalj3JHWtUIkzCCqiGFeE4+1V8cYXVFC546o9hZTj3meUov/egdE6jiREjN2Xy+6UZVhnkAT01k60etpislTmU42FIz20UsfAtJyv3i5qLKczRB5LUOfKdu3koX1EdwdTmFWNeYpkAcE5n0Sfsd5oRp2cR68NSprq3k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787918689; c=relaxed/simple; bh=enkJIQ/dFduMS88GZ0/pl5X5TtHp7SdUYfZITYe4cs4=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=WHMwOxI1g+RPYSJFOXKXrRRjb1L8nd5XCQ45Ja5jYt7po84EigwUhq1orGxPBXLe32V4P54k0Pwnk4fP6u/so1xOqOJl9lNW5JcGjfI8Au+wG8DkroFprA0xGtZMRnpyK6lPz1B4ungqDzP7yRccO9Mx1FlwZ9c8Gp7q9vpRv/s= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Z08eWKJn; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=EsiflpCF; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=GIhXXHHB; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=rQdl4onm DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7C5084BA2E08 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4030B1FE99 for ; Fri, 28 Aug 2026 12:04:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1787918684; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6pT9nvoSkk78y8gVV7VGzPp3wgSt6XpXADq81eZSAUk=; b=Z08eWKJnfQr2Eg7D7DLSIK19M+heUse7IDVThA0llSJS/CfKbY1IoJUPTMtOlN6ApmUtuj yIrWItA4YYcunkgnoO1jLHDWsJxP2EUGeB/G/GS5BdJYnrFoBozSyl6NfEui3SgKliZ5oq 5neg7n86FTOL0EzNYbOr8y+aDm/NSPU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1787918684; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6pT9nvoSkk78y8gVV7VGzPp3wgSt6XpXADq81eZSAUk=; b=EsiflpCFWA8Ybr2P9HefsZ76jTfBXtXu1FL2Js0AFQOKFgt123QKFpJ8w/dgWsLHe6eaeZ t3gkSqQavQ1h6SDA== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1787918680; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6pT9nvoSkk78y8gVV7VGzPp3wgSt6XpXADq81eZSAUk=; b=GIhXXHHB0qPUrOHbKt0SedmrgtgEe9T3z4XoblM+q/30zQAw661zSzD+58OXMo0vuYRkQz dSBdcWJ15pLLtFT3ZH9x/jKD36RLu2U1qfs8C1CMvSTbQH+KmCxsnrY6X8THq66EA5yaR4 W2XF1pkVqBQVm+SpOne7VZRXINfcLXE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1787918680; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6pT9nvoSkk78y8gVV7VGzPp3wgSt6XpXADq81eZSAUk=; b=rQdl4onmaatdJ2q4Mz35erCTDOaNAwj8Cse/mF64QbPZEnbtwsVc2HgeumXTlFF/w4IVlj /nbiXcgtAiOJhMCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0FFDA13686 for ; Fri, 28 Aug 2026 12:04:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id iP41Alh5kWq4GAAAD6G6ig (envelope-from ) for ; Fri, 28 Aug 2026 12:04:40 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH 2/2] [gdb] Fix unbound variable in regformats/regdat.sh Date: Fri, 28 Aug 2026 14:04:39 +0200 Message-ID: <20260828120439.3857602-3-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260828120439.3857602-1-tdevries@suse.de> References: <20260828120439.3857602-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-0.993]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[gnu.org:url,suse.de:mid,imap1.dmz-prg2.suse.org:helo]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; RCVD_TLS_ALL(0.00)[] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org While testing the previous patch, I noticed the following difference: ... $ sh ./gdb/regformats/regdat.sh \ gdb/regformats/rs6000/powerpc-isa205-ppr-dscr-vsx64l.dat \ gdbsupport/osabi.def \ tmp.txt $ ./gdb/regformats/regdat.sh \ gdb/regformats/rs6000/powerpc-isa205-ppr-dscr-vsx64l.dat \ gdbsupport/osabi.def \ tmp.txt ./gdb/regformats/regdat.sh: line 33: comment: unbound variable ... The difference is due to the start of regdat.sh: ... #!/bin/sh -u ... where -u is enabling the unbound variable check. In the first variant, this setting is ignored. Fix this by using "set -u" instead, making sure that the unbound variable check is done for both variants. The comment variable is not used in a meaningful way, so fix the unbound variable error by removing it. Tested in the same way as the preceding patch. --- gdb/regformats/regdat.sh | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/gdb/regformats/regdat.sh b/gdb/regformats/regdat.sh index 01f2dabe459..f93270ba0ca 100755 --- a/gdb/regformats/regdat.sh +++ b/gdb/regformats/regdat.sh @@ -1,4 +1,4 @@ -#!/bin/sh -u +#!/bin/sh # Register protocol definitions for GDB, the GNU debugger. # Copyright (C) 2001-2026 Free Software Foundation, Inc. @@ -18,6 +18,8 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see . +set -u + # Format of the input files read="type entry" @@ -28,15 +30,11 @@ do_read () while read -r line do if test "${line}" = "" - then - continue - elif test "${line}" = "#" -a "${comment}" = "" then continue elif expr "${line}" : "#" > /dev/null then - comment="${comment} -${line}" + continue else # The semantics of IFS varies between different SH's. Some -- 2.51.0