From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WZa9JoygkGrK8gcAWB0awg (envelope-from ) for ; Thu, 27 Aug 2026 16:39:40 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=JrFoQkuo; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9B3231E166; Thu, 27 Aug 2026 16:39:40 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_SBL_CSS autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B4A9E1E033 for ; Thu, 27 Aug 2026 16:39:39 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EBE7C4BA9003 for ; Thu, 27 Aug 2026 20:39:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EBE7C4BA9003 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=JrFoQkuo Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id D147A4BA2E16 for ; Thu, 27 Aug 2026 20:39:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D147A4BA2E16 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D147A4BA2E16 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787863154; cv=none; b=rb+p4BWTujO/YLrXY4aSnAfxXhIA1dmHK8YQEbrc1fJ7+hhHg++MOAWlghvYudRaRRJFry2bJ7jL2HaVobzG65IylhVu6+gw18ZeJKOLCrWIw7I46zF9FidlvMbjseylxsIOt6bDBas0/PLNmC3x3WwICCN5eEJF24zdF/NioVI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787863154; c=relaxed/simple; bh=CNVocoVDbZsL9SGtalfJkkZ5nujRCgSI478cJcpxeKg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=L4ErA6uGqIS5BAb09q6Byf8HE6rRpaaJVx007fBnPUs4U2k5YSRk8hGc5CV00QA+IelYq6ijDFBlLDdFiEYHRyIxUuR6S515Df2ZbrAHJzR9LJPrJckJvDSjW1+foYgdolHV3yKp67/BwkZBD+xetZCY1MRIJ6IZMimV4lhOZx4= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=JrFoQkuo DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D147A4BA2E16 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787863154; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4nRndtDgrmbh2bXruPlC67UjdrF23jjv/c7A6LE4Mes=; b=JrFoQkuoI4CmumoghRZv3dtq0RL36Dryhr7gdxR3W2Oy95yvCftNoUIPXuOd3jJwuLDRx+ 2DYITc2Q7GY2r6zSyb7VCw2jqO/poFLnFCdr2zmMdRNLN4sTUQa68d3UdotHqga+CoBw7E 7TixHh0EYIM1xV3URAgqRIxElByddMw= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-644--Q3J-WKhOt6FHoydMXbJLQ-1; Thu, 27 Aug 2026 16:39:12 -0400 X-MC-Unique: -Q3J-WKhOt6FHoydMXbJLQ-1 X-Mimecast-MFC-AGG-ID: -Q3J-WKhOt6FHoydMXbJLQ_1787863152 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DD38419540EF for ; Thu, 27 Aug 2026 20:39:11 +0000 (UTC) Received: from glarsen-thinkpadp16vgen1.rmtbr.csb (unknown [10.96.134.63]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5DE1630002EE; Thu, 27 Aug 2026 20:39:09 +0000 (UTC) From: Guinevere Larsen To: gdb-patches@sourceware.org Cc: Guinevere Larsen Subject: [PATCH] gdb/testsuite: Fix supplying a function name to gdb_continue_to_breakpoint Date: Thu, 27 Aug 2026 17:38:57 -0300 Message-ID: <20260827203857.206218-1-guinevere@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: zM32kWcMOUVah5lZBVK8V4-pe-M5QcS5KOFhAUG6Pk8_1787863152 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org The previous regex pattern in gdb_continue_to_breakpoint expects a message in one of the following forms: Breakpoint N, in Breakpoint N, at And so, checks for either the "in" or the "at" keywords before the user-supplied pattern. However, this means that if GDB doesn't stop somewhere that requires printing the address, the test can't supply the function name when checking for the breakpoint. This commit adds the possibility of looking just for the comma before the user-supplied pattern, allowing the second form of the stop message to also accept a function name. with '#' will be ignored, and an empty message aborts the commit. # # On branch gwen-test_breakpoint_threads # Changes to be committed: # modified: gdb/testsuite/lib/gdb.exp # --- gdb/testsuite/lib/gdb.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 1a6438f36a5..1eb643cdf1a 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -954,7 +954,7 @@ proc gdb_continue_to_breakpoint {name {location_pattern .*}} { set kfail_pattern "Process record does not support instruction 0xfae64 at.*" return [gdb_test_multiple "continue" $full_name { - -re "(?:Breakpoint|Temporary breakpoint) .* (at|in) $location_pattern\r\n$gdb_prompt $" { + -re "(?:Breakpoint|Temporary breakpoint) .*( at| in|,) $location_pattern\r\n$gdb_prompt $" { pass $full_name } -re "(?:$kfail_pattern)\r\n$gdb_prompt $" { base-commit: 6e3ecea0e3ca191e81e82ee0194c49eea1ffb101 -- 2.55.0