Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [PATCH v2 3/5] [gdb] Fix target element validity error in features/gdb-target.dtd
Date: Wed, 26 Aug 2026 23:22:07 +0200	[thread overview]
Message-ID: <20260826212209.925066-4-tdevries@suse.de> (raw)
In-Reply-To: <20260826212209.925066-1-tdevries@suse.de>

When running xmllint with --valid, I got:
...
gdb/features/rs6000/powerpc-405.xml:9: element target: validity error : \
  No declaration for attribute xmlns:xi of element target
<target xmlns:xi="http://www.w3.org/2001/XInclude">
                                                  ^
...

Fix this by updating features/gdb-target.dtd.

Note that this is not a regression since "Fix xmllint namespace errors".

Before that patch, we have a slightly different error:
...
gdb/features/rs6000/powerpc-405.xml:58: element target: validity error : \
  Element target content does not follow the DTD, \
  expecting (architecture? , osabi? , compatible* , feature*), \
  got (xi:include xi:include feature )
</target>
...

This patch fixes both variants.
---
 gdb/features/gdb-target.dtd | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gdb/features/gdb-target.dtd b/gdb/features/gdb-target.dtd
index 2c405af8add..d1efbad16a5 100644
--- a/gdb/features/gdb-target.dtd
+++ b/gdb/features/gdb-target.dtd
@@ -9,10 +9,10 @@
 <!-- The osabi and compatible elements were added post GDB 6.8.  The version
      wasn't bumped, since older GDBs silently ignore unknown elements.  -->
 
-<!ELEMENT target	(architecture?, osabi?, compatible*, feature*)>
+<!ELEMENT target	(architecture?, osabi?, compatible*, xi:include*, feature*)>
 <!ATTLIST target
-	version		CDATA	#FIXED "1.0">
-
+	version		CDATA	#FIXED "1.0"
+	xmlns:xi	CDATA   #FIXED "http://www.w3.org/2001/XInclude">
 <!ELEMENT architecture	(#PCDATA)>
 
 <!ELEMENT osabi	(#PCDATA)>
-- 
2.51.0


  parent reply	other threads:[~2026-08-26 21:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-26 21:22 [PATCH v2 0/5] [gdb] xml linting Tom de Vries
2026-08-26 21:22 ` [PATCH v2 1/5] [pre-commit] Check xml files Tom de Vries
2026-08-26 21:22 ` [PATCH v2 2/5] [gdb] Fix xmllint namespace errors Tom de Vries
2026-08-26 21:22 ` Tom de Vries [this message]
2026-08-26 21:22 ` [PATCH v2 4/5] [gdb] Fix syscalls-info -> syscalls_info in syscalls/gdb-syscalls.dtd Tom de Vries
2026-08-26 21:22 ` [PATCH v2 5/5] [pre-commit] Use --valid with xmllint Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260826212209.925066-4-tdevries@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox