Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nikita.Venkatesh@arm.com
To: gdb-patches@sourceware.org
Cc: nd@arm.com, Nikita Venkatesh <Nikita.Venkatesh@arm.com>
Subject: [PATCH] Include <array> in ui-style.h
Date: Wed, 26 Aug 2026 16:32:56 +0100	[thread overview]
Message-ID: <20260826153256.907020-1-Nikita.Venkatesh@arm.com> (raw)

From: Nikita Venkatesh <Nikita.Venkatesh@arm.com>

ui-style.h uses std::array without including <array> directly.

This builds successfully with GCC 8 and libstdc++ as its <tuple> header
includes <array>. However, libc++'s <tuple> does not include <array> with
Apple Clang 13.0.0. This causes the GDB builds to fail on macOS with:

	error: implicit instantiation of undefined template
	'std::array<unsigned char, 3>'

Include <array> directly in ui-style.h rather than relying on the
include from <tuple>.

OK for trunk and gdb-18 branch?
---
 gdb/ui-style.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gdb/ui-style.h b/gdb/ui-style.h
index fc40b93709d..201a6f302d9 100644
--- a/gdb/ui-style.h
+++ b/gdb/ui-style.h
@@ -19,6 +19,8 @@
 #ifndef GDB_UI_STYLE_H
 #define GDB_UI_STYLE_H
 
+#include <array>
+
 /* One of the color spaces that usually supported by terminals.  */
 enum class color_space
 {
-- 
2.34.1


             reply	other threads:[~2026-08-26 15:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-26 15:32 Nikita.Venkatesh [this message]
2026-08-26 16:34 ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260826153256.907020-1-Nikita.Venkatesh@arm.com \
    --to=nikita.venkatesh@arm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox