From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YXVXFHFqjWqKxj4AWB0awg (envelope-from ) for ; Tue, 25 Aug 2026 06:12:01 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=Z4++okwz; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=Z4++okwz; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4AD2F1E0A3; Tue, 25 Aug 2026 06:12:01 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8A1AA1E033 for ; Tue, 25 Aug 2026 06:12:00 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 36B8C4BA798F for ; Tue, 25 Aug 2026 10:11:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 36B8C4BA798F Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=Z4++okwz; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=Z4++okwz Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazlp170110003.outbound.protection.outlook.com [IPv6:2a01:111:f403:c200::3]) by sourceware.org (Postfix) with ESMTPS id 9E6954BA5434 for ; Tue, 25 Aug 2026 10:11:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9E6954BA5434 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9E6954BA5434 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c200::3 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1787652665; cv=pass; b=tedRneJYpjvNlkjGqC198MOIBwq+IVjU3uUe83dLryckJBUU/wh2qT+91Y5FPYMEn88uAJibqQ9szzcPkqm0cCOo7gIRB6nd0ioIw3eWargmmNYmXRKMCci/TxpnNebYX/TpSAvJ/vGPgQNPlaeZho6vJQWZF7smm2CTDoDapqY= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1787652665; c=relaxed/simple; bh=VtHv/TVrpLE1BrWhI7KhQFViLCCrDf8gPR3dI0AuXNg=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=NTkkDIR5bHT0Ypu6kvAwpxJIxQ9G8vJuvg+dHeazfpOlOkR9hmRAZEwmcgbv5AZjZ2QT0NSIjcPEGUAy5HQz7uP1CWbdnc83TtqfNGND2S2MY+fNQlx3QeRWJRyGYoAB7lLByJepgFLoVcOl/ANzfaMTHonzgKHzHSveui+3o50= ARC-Authentication-Results: i=3; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=Z4++okwz; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=Z4++okwz DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9E6954BA5434 ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=XDaM+dmvX9MRFdeJ99qblsaCN7x2hWktLvy8NoePGBj/vJ9HqaBEzNjnbnUCInOw6qr4ht9XVNiHCOOgKz9Jo9MsXgZjSiAeD44yQEcEUZMKNSlrLr/c2xXzCzHghrJI3DQMLDSoxDtQuLSPHAPZCbtb7O3E0sGXtvvxLBE/ZbmrsGUgoaHtKz8xZekRwJzsReFA59SpvifeUljZFbMTMDmMyqemvTkmsg7hP5nwgYtIVHQ0ZGvhGbS3xEtrIFUbsoLxuM5/U5fKRvmgb0/S61Qt6D81Ui05PLhRvWtGVMvBcobe+jqGiVzE+6lRnTshl9hyxZb+a7sYtpj6pCt8xg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n1i+BlumYMpEE6ZqZl97ZG3xLnNtMkjr872lyHXvRt4=; b=eNMPVzU3TUk0NaO2tqAWqIYqOCqMcKT0Db2iefjA62lFrNATbrrQOaquyzLpvGT0TTJZFNmAF9bArUGUy+NM3cLlBwSjFXh67Xib0aoG6fEgIxmUk4u4Kni8jk91J73oYeoQFdHgpZPs1O6Yi34r0pVDZH/wNlJugCKvknngeYaFvVPEzBZO57W6cEb91ObcZRhqjwe9jyvy4+ELfkntyk45BJ8q8V0C4+K+PxnT0bDY3i03M0yDyQOqMln1nQGLAyhp/i5g45eU/VoAfvb+hp+mnjKx+F9acytRwEYqZ2djSuB/Kwcx2XcVgTvzcrIDvRZ/3eL0EAj4CL/mRpq+CA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n1i+BlumYMpEE6ZqZl97ZG3xLnNtMkjr872lyHXvRt4=; b=Z4++okwzTue48dtLX4isGNRlRqL8dkdi8bezvYCl2kc5fsrRHwmB0VgWL0BeuwjUku/R3LnP8QD4urLrRATP77bcx9JMZ1sBGkSgKHb3VhvokqlMvvnBy6PTwm1mR9XE71sh4+U17l8Yopvc3k++bS7p8ZcTyBloVRuGTJ62ISk= Received: from ZR0P278CA0121.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:20::18) by PAWPR08MB9853.eurprd08.prod.outlook.com (2603:10a6:102:2e6::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.339.12; Tue, 25 Aug 2026 10:10:59 +0000 Received: from MI3PEPF00008481.eurprd02.prod.outlook.com (2603:10a6:910:20:cafe::48) by ZR0P278CA0121.outlook.office365.com (2603:10a6:910:20::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.339.12 via Frontend Transport; Tue, 25 Aug 2026 10:10:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by MI3PEPF00008481.mail.protection.outlook.com (10.167.240.168) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.360.3 via Frontend Transport; Tue, 25 Aug 2026 10:10:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pAKoutP015+SB8BuLcnD78UA8Ld17byCABQxFmJqG9le3qiKBi4T1GH2VDAD61QPCPL7liLUwZpLWzVciNswVAaZVP8vFVa+cgGtH6grBWvVwjsgE2VCer8dIlEQQwF1lFJ80Y7YGbDP6LwwFB3s+qDwMA3ipU/Y+ajIqpVc4fnEGbdyGBP1hSYVZekZ9VHncsKQQfWE1+UUVVwc/42DGwXS3JEO+yD4K6XT3Xepv0IbryPXigHg+nY5YZVOJvPeCyJO2PZSHY0FgcfgofIje6ITGhxnmahE+CqEf/GeKtgYQbUZ1q7uYtfDOFbrZ9yiVuCDGHQMwQexfJouu9BkGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n1i+BlumYMpEE6ZqZl97ZG3xLnNtMkjr872lyHXvRt4=; b=BP52Izg25mCT8Iu6FdLy9SMjgybJkEwjcVwSDeGSd9bhak7l65IbPiZbWOXRH5QV/KnZ3z5vH5ywOZkwGCbKBPKlengweh1giAUjL6aESZUVoF69Ej9aa4IniPfltDynOHNJmCbrp+UcNcO2bbXn/uPnbHbzQLNWxA09+5iL3nYa9A1aGbPWq1QxTPeZ5hXRRG7qeLKJgLt/r0hsahGIWrVF0HLn/IplMLihvoOHzvuprpkbYb9JqlZKV0Z6TgZ4tY1dyUzg1gQPXNIuP1HuZBDKN1kSCJvzfqgqGocfDYnb1uOJsy0tBzLbDSp6iZ9Tb7D9jZiaf7T+6V8zWj3NEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 172.205.89.229) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n1i+BlumYMpEE6ZqZl97ZG3xLnNtMkjr872lyHXvRt4=; b=Z4++okwzTue48dtLX4isGNRlRqL8dkdi8bezvYCl2kc5fsrRHwmB0VgWL0BeuwjUku/R3LnP8QD4urLrRATP77bcx9JMZ1sBGkSgKHb3VhvokqlMvvnBy6PTwm1mR9XE71sh4+U17l8Yopvc3k++bS7p8ZcTyBloVRuGTJ62ISk= Received: from AS4P189CA0029.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:5db::20) by PA4PR08MB6096.eurprd08.prod.outlook.com (2603:10a6:102:eb::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.339.12; Tue, 25 Aug 2026 10:10:21 +0000 Received: from AM4PEPF00027A62.eurprd04.prod.outlook.com (2603:10a6:20b:5db:cafe::1a) by AS4P189CA0029.outlook.office365.com (2603:10a6:20b:5db::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.360.6 via Frontend Transport; Tue, 25 Aug 2026 10:10:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 172.205.89.229) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 172.205.89.229 as permitted sender) receiver=protection.outlook.com; client-ip=172.205.89.229; helo=nebula.arm.com; pr=C Received: from nebula.arm.com (172.205.89.229) by AM4PEPF00027A62.mail.protection.outlook.com (10.167.16.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.360.3 via Frontend Transport; Tue, 25 Aug 2026 10:10:20 +0000 Received: from AZ-NEU-EX04.Arm.com (10.240.25.138) by AZ-NEU-EX04.Arm.com (10.240.25.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Tue, 25 Aug 2026 10:10:20 +0000 Received: from PF4S4363.arm.com (10.57.48.229) by mail.arm.com (10.240.25.138) with Microsoft SMTP Server id 15.2.2562.29 via Frontend Transport; Tue, 25 Aug 2026 10:10:20 +0000 From: Matthieu Longo To: CC: Simon Marchi , Thiago Jung Bauermann , Luis Machado , "Luis Machado" , Christina Joos , Kevin Buettner , "Matthieu Longo" Subject: [PATCH v2 6/6] gdb/linux-tdep: remove legacy parse_smaps_data overload Date: Tue, 25 Aug 2026 11:09:12 +0100 Message-ID: <20260825100912.514232-7-matthieu.longo@arm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260825100912.514232-1-matthieu.longo@arm.com> References: <20260825100912.514232-1-matthieu.longo@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM4PEPF00027A62:EE_|PA4PR08MB6096:EE_|MI3PEPF00008481:EE_|PAWPR08MB9853:EE_ X-MS-Office365-Filtering-Correlation-Id: 04124130-4627-4e07-0670-08df02912846 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; ARA:13230040|376014|1800799024|82310400026|23010399003|36860700016|11063799006|10067099003|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info-Original: v1snXv4Ya+nLQW9sOBORkgBlYoZZiOq47giH6cn5PW1czCDJisO792Mji6FOdy3vARfYN6QEPZ1e+v1veJ+gYcnOycOENNx9nS+ibKPMwrmbejGqAFC29LMLZh838kErRNtBRWnZeiOJiAtpHeGu4RAV9Oz6S+N7H97yVAcrL6kJD6HU79LabOvS7BBLK+n12VBhhM0uGRBjPZ+6ZtInS+Af/e2WTIGn8Ef2t4r5RD5QXmLX5PZ8wgBPPUF8D96OwpPyRk0m2ybQZTkmw2AJ4Jim3fVjbTdLKpUqcN05aqtuSjMWH7V/EYFL1tnPlK9DlD82zukYscIWKC28T5fSJ0UeNd55AvLKyItqL5DSn0hfrSAP6A6YqwSK90bgfHONfnGyYsAKdo1IsEq1xeQLBP0AIN9t/DmVpK/5tZ66rBLMTbu1eb2LdUHcJ/SNJfN85vn097bCC5dFCR0+3OrBRZwg1RDX1WmLcR8shrqFjYsQFpQ/dJ8fjoIJlHrA1EzUQIbnGWSYaAwsOwOHTacsNVP/PGV0s32V6QIsFM5TSwzhbi9s1FL4EEb/wOwkkXPCJxkYonSRhA1ZymFG7n81uAKwwUAkcFjQDLgWpJEEyDdkM1IHKGR5AjqPe0/BcbjvnW8KGz9txvmhV8KrBmqjywZtwEKQ6ztHBCAwhCXwVRggZYHo/g52s9TODP6oRfC9bQe06LYlU7ELj06l7RhUVw== X-Forefront-Antispam-Report-Untrusted: CIP:172.205.89.229; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:nebula.arm.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(376014)(1800799024)(82310400026)(23010399003)(36860700016)(11063799006)(10067099003)(56012099006)(18002099003)(22082099003); DIR:OUT; SFP:1101; X-Exchange-RoutingPolicyChecked: 3xDAML9W9m9cRLXULI76SAVB8uLKt9O0CTDFkjliGcdXWVplb+Vwt94Zd6hD1woDVFbOMWfhz8pH+//A2zsFFG1VNrrB4JI/7PNUMv+q9icXbZ/GRN1BmzXiECJztDOJHwondqnlche+BrhhzwUqNBLC9n8jH8ksIWtPlxZmjkl7gkhk0M9kJ0Ofys/UOFLWTAreECJ/82UrDr3lnvsQfAWPbW9nJPU8BM9xFm3DMglsWJead7wa3JbGxluQZQOgZIHroBptbkEVLFVpwLJ8AoUvJt5nnyUkr6WD3ePeRjMZj4W0iE8VySWPb0uYVCDTIPETkcGlVDvtbU0McEieNw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6096 X-MS-Exchange-Transport-CrossTenantHeadersStripped: MI3PEPF00008481.eurprd02.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: dcf0e15d-36ee-47c3-efca-08df02911248 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700016|14060799003|1800799024|35042699022|376014|82310400026|23010399003|18002099003|22082099003|11063799006|56012099006|10067099003; X-Microsoft-Antispam-Message-Info: vL0OlV0BseDGoqbOGNaiT9dIhxL8WN9Ee8DJiJOeZgVUu+7pvB53uIg3u/yVZOuxQJkThD0AE+KiH3smRJkj8x0bD6SD5NlItV5p4lLRge1vGL7hUku0YhIsaRAiab9cg2Dqc4/5NIBd76kuJbQQEMDuQIakccAnJ+DEjzb0Jdb7SeF6NVBsP+2vV2qU6SJBRZqAvDfY4O3YhjVg9x/U5iAeQ3DRSZZIhRXY5ercWqEjlQDVVwH5WzwHLbdatz0yiK0oMCLSEi+ATDJ0GpcJv9p5pIa9m1GwVr/w2ZTS99DrVHMyUUbVBDekdxpJDqOM0sICYRYxc5mSjSpAIqn0kRvf7uR4KvBlZUGDaGmyxcGYUVM15ZmywrYGhe3rcrKHemI/4Y3OLizmtb5x77WTnGMXGtUa36w6eK56R7896m+tG5tngh0zCn3GQ8xw0cHeEhtvD8TTF1tdeI6hak6sdTrfvRiX4Ycb/DJ02/tCOj8fyCmAqwo4zgBKBTVwyfNvCDlRqOOcjL+mhnZSAuVS+/CnYTVwQUVIFdsQ6roJ0edD/7THMosZFrxcArM4B/et+BkYMT//gu8ODqDjphXTCOQ3SqglESf9mHrenWHEcbad3/C+0gCT2lETQUpaX6pbc7k1KD+aZDEyvkPBBMgLHpXdptqy+FZxwnLApGrKGTL6WTyzE4c2LMoo45L1cyadGvfAz2YP4xp+Kz5SzedNYg== X-Forefront-Antispam-Report: CIP:4.158.2.129; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:outbound-uk1.az.dlp.m.darktrace.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(36860700016)(14060799003)(1800799024)(35042699022)(376014)(82310400026)(23010399003)(18002099003)(22082099003)(11063799006)(56012099006)(10067099003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Ssxe/iixh8UtONK13SxCwI708OAvw+x5846RqwYYNlesjkZgZBWzy9eSKsdv3mHUBMLz7wUuAw+cfkmP4bxHtfRUk1zFbFcMrTlkxpyiMXoqTnAHHaiTkTrloVEXL0DHeSM2P+wBN5od020FM+FVmDk6oIxLEnumpz7BWxn31zcbtA/BH6IFo0sEhAQNHHwhvaJiifs4l+yetwNA127MWAD2p60B+lsjAwp7gJQ8y7W2cN8f+rDKn/Fs0MTvs0LkyuNNUKk8dj8K/vTOOsPGiYWd3pHJAFv4es2MUs1ylaU+lW5dxvTLFvBGuJjnDD7oUmyEQecnwI6n3l8CGs2gAGyDi2Pcgmh4liagMUch/h9AzP7toSwtwINZ4Kvv8fG4msPUfKxez8yM9ubJrszbLaQLVO7TF18mBBCuh5hNbwY33XWBO5/bq6WDcRDplM/c X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2026 10:10:57.7424 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 04124130-4627-4e07-0670-08df02912846 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[4.158.2.129]; Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: MI3PEPF00008481.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9853 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Now that all callers use the file_reader_t overload of parse_smaps_data, the legacy interface taking a raw buffer and filename separately is no longer needed. Fold its implementation into the file_reader_t version and remove the obsolete wrapper. This also simplifies the implementation by using the file_reader_t accessors directly. Reviewed-By: Thiago Jung Bauermann Reviewed-By: Luis Machado --- gdb/linux-tdep.c | 30 ++++++++++++------------------ 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c index 2833d8a4bb6..4cdb02b9c09 100644 --- a/gdb/linux-tdep.c +++ b/gdb/linux-tdep.c @@ -1581,18 +1581,17 @@ parse_smaps_key_value (const char *keyword, const char *line, /* Helper function to parse the contents of /proc//smaps into a data structure, for easy access. - DATA is the contents of the smaps file. The parsed contents are stored - into the SMAPS vector. */ + FREADER is a wrapper around the contents of the smaps file. + The parsed contents are stored into the SMAPS vector. */ static std::vector -parse_smaps_data (const char *data, - const std::string &maps_filename) +parse_smaps_data (const file_reader_t &freader) { char *line, *t; - gdb_assert (data != nullptr); + gdb_assert (freader); - line = strtok_r ((char *) data, "\n", &t); + line = strtok_r (freader.data (), "\n", &t); std::vector smaps; @@ -1648,8 +1647,8 @@ parse_smaps_data (const char *data, if (sscanf (line, "%64s", keyword) != 1) { - warning (_("Error parsing {s,}maps file '%s'"), - maps_filename.c_str ()); + warning (_("Error parsing keyword in {s,}maps file '%s'"), + freader.c_filepath ()); break; } @@ -1663,12 +1662,12 @@ parse_smaps_data (const char *data, decode_vmflags (line, &v); if (parse_smaps_key_value (keyword, line, "Rss:", - maps_filename, + freader.filepath (), &rss)) continue; if (parse_smaps_key_value (keyword, line, "Swap:", - maps_filename, + freader.filepath (), &swap)) continue; @@ -1679,8 +1678,9 @@ parse_smaps_data (const char *data, if (sscanf (line, "%*s%lu", &number) != 1) { - warning (_("Error parsing {s,}maps file '%s' number"), - maps_filename.c_str ()); + warning (_("Error parsing numeric value associated with " + "key '%s' in {s,}maps file '%s'"), + keyword, freader.c_filepath ()); break; } if (number > 0) @@ -1730,12 +1730,6 @@ parse_smaps_data (const char *data, return smaps; } -static std::vector -parse_smaps_data (const file_reader_t &freader) -{ - return parse_smaps_data (freader.data (), freader.filepath ()); -} - /* Helper that checks if an address is in a memory tag page for a live process. */ -- 2.55.0