Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Dubiec <jdx@o2.pl>
To: gdb-patches@sourceware.org
Cc: Jan Dubiec <jdx@o2.pl>
Subject: [PATCH] H8/300: sim: testsuite: Use the correct file descriptor for stdout.
Date: Sat, 22 Aug 2026 12:44:46 +0200	[thread overview]
Message-ID: <20260822104502.1569137-1-jdx@o2.pl> (raw)

This is obviously a typo, because the file descriptor for stdout is 1 on
both Linux and Windows. As a result, the test cases returned nothing
on Windows, i.e. neither "pass" nor "fail". Which, BTW, raises the
question of why 0 works on Linux. For over 20 years...

Signed-off-by: Jan Dubiec <jdx@o2.pl>
---
 sim/testsuite/h8300/testutils.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sim/testsuite/h8300/testutils.inc b/sim/testsuite/h8300/testutils.inc
index 63d27d45c14..1e2c7c31c7b 100644
--- a/sim/testsuite/h8300/testutils.inc
+++ b/sim/testsuite/h8300/testutils.inc
@@ -85,7 +85,7 @@ _main:
 
 ; Output "pass\n"
 	.macro pass
-	mov.w	#0, r0		; fd == stdout
+	mov.w	#1, r0		; fd == stdout
 .if (sim_cpu == h8300)
 	mov.w	#pass_str, r1	; buf == "pass\n"
 	mov.w	#5, r2		; len == 5
@@ -98,7 +98,7 @@ _main:
 
 ; Output "fail\n"
 	.macro fail
-	mov.w	#0, r0		; fd == stdout
+	mov.w	#1, r0		; fd == stdout
 .if (sim_cpu == h8300)
 	mov.w	#fail_str, r1	; buf == "fail\n"
 	mov.w	#5, r2		; len == 5
-- 
2.55.0

             reply	other threads:[~2026-08-22 10:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-22 10:44 Jan Dubiec [this message]
2026-08-24 10:47 ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260822104502.1569137-1-jdx@o2.pl \
    --to=jdx@o2.pl \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox