From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 3SJiNOkGimq2ZTcAWB0awg (envelope-from ) for ; Sat, 22 Aug 2026 16:30:33 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=oA0g6Mdm; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BF87F1E0A3; Sat, 22 Aug 2026 16:30:33 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 459D11E09B for ; Sat, 22 Aug 2026 16:30:32 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C65794BAE7DD for ; Sat, 22 Aug 2026 20:30:31 +0000 (GMT) Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id A61B44BA900F for ; Sat, 22 Aug 2026 20:30:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A61B44BA900F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A61B44BA900F Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787430607; cv=none; b=b5cWVF+SlzRgNfmpzTH2WKxSehLwiFDPvK6x3SVhdkQS4AZwIomHNxLynvhdQRXH/tGm1xV5dAqo/UI5MEqeRtWIAmHnJvE2+tbzLm5oMYsdgwYGN3Xj/YGi+zLlaIihAjYrnjyYNgt0Ebq1Gkk9STmneBcJ5nVQ9RkWHFrMtO4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787430607; c=relaxed/simple; bh=tvIV4VWAZShXY3qeMPBrr6ZJJ2Z/KIRY1fSpzc16QlE=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=sCZURlGVlzVQKOfI+/qRqrJRaHpDCKxhOCCjJZyoJZBjZDDJU5rdrnf5H8GFrIcInTYmuOEX4sz9PaQEAPEoD2MjCI6oNai4Ie9spK5PqqZ6sNBgDMkB3Q7y12/Fd1aOeRrEy3VxV7ILexlO4/2kk2fH6uvjW2YQ65TqlqYhlhI= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=oA0g6Mdm reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A61B44BA900F Authentication-Results: sourceware.org; dkim=policy reason="signing key too small" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=oA0g6Mdm Received: from eig-obgw-6003b.ext.cloudfilter.net ([10.0.30.175]) by cmsmtp with ESMTPS id xq0iwhPnAuFzgxsLvwh0TV; Sat, 22 Aug 2026 20:30:07 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id xsLuwwg0LZEEtxsLuwJkOW; Sat, 22 Aug 2026 20:30:06 +0000 X-Authority-Analysis: v=2.4 cv=bphMBFai c=1 sm=1 tr=0 ts=6a8a06ce a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=ItBw4LHWJt0A:10 a=CCpqsmhAAAAA:8 a=b8GBexpPQRx1FkmBIZgA:9 a=QEXdDO2ut3YA:10 a=ul9cdbp4aOFLsgKbc677:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ER3vIAfv+SIIOct//XZBW51ziSJ25oy9Y5D6n08K2a0=; b=oA0g6MdmqZquC5A6w2Y8Jx4mJr Psjwc+B9CnqKSQoQYBrgPgMKMrHqR151WSE0lP6YlgDWE23qoSYN1tqG5YS00cua91y1BeJGm8Yj+ 5sb/UZ9NiJAi9uDRkXwDSIJcG; Received: from 97-122-117-2.hlrn.qwest.net ([97.122.117.2]:35668 helo=[192.168.122.1]) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.5) (envelope-from ) id 1wxsLu-00000002Mju-0oY6; Sat, 22 Aug 2026 14:30:06 -0600 From: Tom Tromey Date: Sat, 22 Aug 2026 14:30:05 -0600 Subject: [PATCH 3/5] Fix weird quoting in stap-probe.c MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260822-no-backquotes-in-strings-v1-3-0b035ad036a3@tromey.com> References: <20260822-no-backquotes-in-strings-v1-0-0b035ad036a3@tromey.com> In-Reply-To: <20260822-no-backquotes-in-strings-v1-0-0b035ad036a3@tromey.com> To: gdb-patches@sourceware.org Cc: Tom Tromey X-Mailer: b4 0.14.3 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.117.2 X-Source-L: No X-Exim-ID: 1wxsLu-00000002Mju-0oY6 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-117-2.hlrn.qwest.net ([192.168.122.1]) [97.122.117.2]:35668 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfPNsrCwsC7K2g1sv2IEL3C9M4ae/7hXzVr+O1P4Z6CE+FIIuvZ1/yd/TS4Bwx+dJNQjgFO0+JyPjIi/IiXsfo7QFElFDXLW/B9ViyVA+S5TZvw2JJ6YR Ft7nXhNkaBe9bvyX/g0VqvzJOKITTR8N7FAmh96+SmjrJuhyqhFYmFjaO0bQJUdHmy4fF4xe5iuvXc+Slxgo1VxoAO9S7/Z7QLA= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I found some code in stap-probe.c that split the quoting in a strange way: warning (_("unrecognized bitness %s%c' for probe `%s'"), got_minus ? "`-" : "`", *cur, Here the leading ` is not part of the format string. I found this odd and so I split this fix out into its own patch. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34044 --- gdb/stap-probe.c | 4 ++-- gdb/testsuite/gdb.arch/amd64-stap-optional-prefix.exp | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/gdb/stap-probe.c b/gdb/stap-probe.c index 986ff38c586..654a2f7ca45 100644 --- a/gdb/stap-probe.c +++ b/gdb/stap-probe.c @@ -1304,8 +1304,8 @@ stap_probe::parse_arguments (struct gdbarch *gdbarch) { /* We have an error, because we don't expect anything except 1, 2, 4 and 8. */ - warning (_("unrecognized bitness %s%c' for probe `%s'"), - got_minus ? "`-" : "`", *cur, + warning (_("unrecognized bitness \"%s%c\" for probe \"%s\""), + got_minus ? "-" : "", *cur, this->get_name ().c_str ()); return; } diff --git a/gdb/testsuite/gdb.arch/amd64-stap-optional-prefix.exp b/gdb/testsuite/gdb.arch/amd64-stap-optional-prefix.exp index 9cd7dec166c..8f26e3fe9bf 100644 --- a/gdb/testsuite/gdb.arch/amd64-stap-optional-prefix.exp +++ b/gdb/testsuite/gdb.arch/amd64-stap-optional-prefix.exp @@ -79,7 +79,7 @@ foreach probe_name $normal_probes_names \ with_test_prefix "fail_probe" { goto_probe "fail_probe" - gdb_test "print \$_probe_arg0" "warning: unrecognized bitness `-7' for probe `fail_probe'\r\nInvalid probe argument 0 -- probe has 0 arguments available" + gdb_test "print \$_probe_arg0" "warning: unrecognized bitness \"-7\" for probe \"fail_probe\"\r\nInvalid probe argument 0 -- probe has 0 arguments available" } with_test_prefix "fail2_probe" { -- 2.49.0