Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [pushed] [gdb/testsuite] Simplify regexp in gdb.rocm/watchpoint-at-end-of-shader.exp
Date: Wed, 19 Aug 2026 10:29:38 +0200	[thread overview]
Message-ID: <20260819082938.2003302-1-tdevries@suse.de> (raw)

In gdb.rocm/watchpoint-at-end-of-shader.exp, we have:
...
	    [multi_line "Switching to \[^\r\n\]+(?=\r\n)" \
		"" \
...

This expands to "Switching to \[^\r\n\]+(?=\r\n)\r\n".

The lookahead '(?=\r\n)' is superfluous (because it's followed by '\r\n'), so
drop it.

While we're at it, reduce escaping by using {}.
---
 gdb/testsuite/gdb.rocm/watchpoint-at-end-of-shader.exp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.rocm/watchpoint-at-end-of-shader.exp b/gdb/testsuite/gdb.rocm/watchpoint-at-end-of-shader.exp
index 2ae0e044a53..298b5be9461 100644
--- a/gdb/testsuite/gdb.rocm/watchpoint-at-end-of-shader.exp
+++ b/gdb/testsuite/gdb.rocm/watchpoint-at-end-of-shader.exp
@@ -71,7 +71,8 @@ proc do_test {precise_memory has_xfail} {
 	    setup_xfail "*-*-*"
 	}
 	gdb_test "continue" \
-	    [multi_line "Switching to \[^\r\n\]+(?=\r\n)" \
+	    [multi_line \
+		{Switching to [^\r\n]+} \
 		"" \
 		"Thread $::decimal \[^\r\n\]*hit Hardware watchpoint $::decimal: -location \\*v" \
 		"" \

base-commit: ab1830f633107b180b46938003e6f49fb44cb17d
-- 
2.51.0


                 reply	other threads:[~2026-08-19  8:30 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260819082938.2003302-1-tdevries@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox