From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8qc2JQAmg2q1LC0AWB0awg (envelope-from ) for ; Mon, 17 Aug 2026 11:17:20 -0400 Received: by simark.ca (Postfix, from userid 112) id 7B9031E167; Mon, 17 Aug 2026 11:17:20 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CB4301E167 for ; Mon, 17 Aug 2026 11:17:19 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 63C474BA7998 for ; Mon, 17 Aug 2026 15:17:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 63C474BA7998 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 7F2124BA2E08; Mon, 17 Aug 2026 15:16:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7F2124BA2E08 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7F2124BA2E08 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786979815; cv=none; b=nkzNlR/HbT9Q7NSwwjUggADu/2OzBG/7v+lFGe7HbNdzFEc2oxVlBC2JwK0G6loP6jLV3Q0dYrxtBX2K1kQbnFw1AOB6xvtZjXhxzjqrfAI4kYW+EdmOWyt5TkzKYzc4VFDmdRMgG6JK+0zg1cpfuL0p9Xxj4+fK6Bn3w0G5v/Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786979815; c=relaxed/simple; bh=xSoIYREBbKwQqXK4ONlHj1ObJU2nUkzVKMQFSSJ9+hw=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=WPHdxvIv94YBX4wguCsBCqBKd17toHRiPuVmmYU9P1/pU521EXwCbeGbLwYBImwF+2KHCS8MNehizyd8BnYqOpXCSMH/+Sah+aJs4wceFhJ9nLK/c26Xn/gSj1fGoU0dmC6fUhs3SG6TXWefH25hkrQT0CIvwcCrsg+LxJeJ2ks= ARC-Authentication-Results: i=1; sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7F2124BA2E08 Received: by simark.ca (Postfix) id B98601E173; Mon, 17 Aug 2026 11:16:52 -0400 (EDT) From: Simon Marchi To: gdb-patches@sourceware.org, binutils@sourceware.org Cc: Simon Marchi Subject: [PATCH 07/13] gdb/csky: remove uses of sprintf Date: Mon, 17 Aug 2026 11:16:12 -0400 Message-ID: <20260817151646.152571-8-simon.marchi@efficios.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817151646.152571-1-simon.marchi@efficios.com> References: <20260817151646.152571-1-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org When building on macOS, I get a few: /Users/smarchi/src/binutils-gdb/gdb/csky-tdep.c:434:4: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Werror,-Wdeprecated-declarations] 434 | sprintf (tdesc_reg.name, "cp1cr%d", remain); | ^ Replace these uses with snprintf, via xsnprintf, which asserts that the destination buffer was large enough for the output string. Change-Id: Idc5c0c42479f767c63b0d0cece5ab14cacec9a60 --- gdb/csky-tdep.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/gdb/csky-tdep.c b/gdb/csky-tdep.c index e86f79a42eaf..ad0d50d8218d 100644 --- a/gdb/csky-tdep.c +++ b/gdb/csky-tdep.c @@ -431,19 +431,22 @@ csky_get_supported_register_by_index (int index) { case 0: /* Bank1. */ { - sprintf (tdesc_reg.name, "cp1cr%d", remain); + xsnprintf (tdesc_reg.name, sizeof (tdesc_reg.name), "cp1cr%d", + remain); tdesc_reg.num = 189 + remain; } break; case 1: /* Bank2. */ { - sprintf (tdesc_reg.name, "cp2cr%d", remain); + xsnprintf (tdesc_reg.name, sizeof (tdesc_reg.name), "cp2cr%d", + remain); tdesc_reg.num = 276 + remain; } break; case 2: /* Bank3. */ { - sprintf (tdesc_reg.name, "cp3cr%d", remain); + xsnprintf (tdesc_reg.name, sizeof (tdesc_reg.name), "cp3cr%d", + remain); tdesc_reg.num = 221 + remain; } break; @@ -460,7 +463,8 @@ csky_get_supported_register_by_index (int index) case 13: /* Bank14. */ { /* Regitsers in Bank4~14 have continuous regno with start 308. */ - sprintf (tdesc_reg.name, "cp%dcr%d", (multi + 1), remain); + xsnprintf (tdesc_reg.name, sizeof (tdesc_reg.name), "cp%dcr%d", + (multi + 1), remain); tdesc_reg.num = 308 + ((multi - 3) * 32) + remain; } break; @@ -482,7 +486,8 @@ csky_get_supported_register_by_index (int index) case 29: /* Bank31. */ { /* Regitsers in Bank16~31 have continuous regno with start 660. */ - sprintf (tdesc_reg.name, "cp%dcr%d", (multi + 2), remain); + xsnprintf (tdesc_reg.name, sizeof (tdesc_reg.name), "cp%dcr%d", + (multi + 2), remain); tdesc_reg.num = 660 + ((multi - 14) * 32) + remain; } break; -- 2.55.0