From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EXf3ISImg2qsLC0AWB0awg (envelope-from ) for ; Mon, 17 Aug 2026 11:17:54 -0400 Received: by simark.ca (Postfix, from userid 112) id 88ABA1E167; Mon, 17 Aug 2026 11:17:54 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D258E1E033 for ; Mon, 17 Aug 2026 11:17:53 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 009574BA902E for ; Mon, 17 Aug 2026 15:17:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 009574BA902E Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id AEF104BA23F3; Mon, 17 Aug 2026 15:16:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AEF104BA23F3 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AEF104BA23F3 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786979813; cv=none; b=eKzkKXc8sSzNXxz/+wmj08KD1e2LzNMuw8S8fieJ5OZmn4bNb3B0YuB0onR8gOVpn8ELjcBAT/KFU7meQJJKCY4pux2CIMXbILr/iNGeRRpiagWsZmxfx3MbPStYqJE0Z7ElOctzXu5v7CoTW/p0CLzB5LTav3avCTVzaJ31B2k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786979813; c=relaxed/simple; bh=lzSOuc7r6jRErubxyQEmD9JfnFxOWlFxhMCzehUsY7w=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=Hr9IfQHMqVQTV5OeeIEC/r8bJ5QWdbDTJq80seye3lbowmIWI+Rmck6yu7HeYnjTzUZE0DBDnXkP62A/93oipbHx4xjjWyHWhQDzc2/URS1KKByiCfsG8KRTpSwQr7HwDrOAr8qKlzrweSn9ESS6kmpNUNYzPqN2rA4OSYgkqyQ= ARC-Authentication-Results: i=1; sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AEF104BA23F3 Received: by simark.ca (Postfix) id 20D401E168; Mon, 17 Aug 2026 11:16:52 -0400 (EDT) From: Simon Marchi To: gdb-patches@sourceware.org, binutils@sourceware.org Cc: Simon Marchi Subject: [PATCH 04/13] sim/ppc: make defines.h sed command portable Date: Mon, 17 Aug 2026 11:16:09 -0400 Message-ID: <20260817151646.152571-5-simon.marchi@efficios.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817151646.152571-1-simon.marchi@efficios.com> References: <20260817151646.152571-1-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org When building on macOS, whose sed is the BSD one, I get: GEN ppc/stamp-defines sed: 1: "/^#define HAVE_.*1$/{ s ...": extra characters at the end of p command make[1]: *** [ppc/stamp-defines] Error 1 BSD sed apparently does not accept a `}' directly after another command, it needs a separating semicolon. Add one after the `p'. GNU sed accepts both forms, and produces the same output either way. Re-generate sim/Makefile.in. Change-Id: I0709ad7b0051e08299f2576113b549aba9fc703f --- sim/Makefile.in | 2 +- sim/ppc/local.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sim/Makefile.in b/sim/Makefile.in index 1f9bbfec03f1..2a23b5c2eaa9 100644 --- a/sim/Makefile.in +++ b/sim/Makefile.in @@ -5722,7 +5722,7 @@ testsuite/common/bits64m63.c: testsuite/common/bits-gen$(EXEEXT) testsuite/commo @SIM_ENABLE_ARCH_ppc_TRUE@ppc/defines.h: ppc/stamp-defines ; @true @SIM_ENABLE_ARCH_ppc_TRUE@ppc/stamp-defines: config.h Makefile -@SIM_ENABLE_ARCH_ppc_TRUE@ $(AM_V_GEN)$(SED) -n -e '/^#define HAVE_.*1$$/{ s/ 1$$/",/; s/.* HAVE_/"HAVE_/; p }' < config.h > ppc/defines.hin +@SIM_ENABLE_ARCH_ppc_TRUE@ $(AM_V_GEN)$(SED) -n -e '/^#define HAVE_.*1$$/{ s/ 1$$/",/; s/.* HAVE_/"HAVE_/; p; }' < config.h > ppc/defines.hin @SIM_ENABLE_ARCH_ppc_TRUE@ $(AM_V_at)$(SHELL) $(srcroot)/move-if-change ppc/defines.hin ppc/defines.h @SIM_ENABLE_ARCH_ppc_TRUE@ $(AM_V_at)touch $@ diff --git a/sim/ppc/local.mk b/sim/ppc/local.mk index f9f134abe3c9..9aca96465acd 100644 --- a/sim/ppc/local.mk +++ b/sim/ppc/local.mk @@ -80,7 +80,7 @@ noinst_PROGRAMS += %D%/run %D%/defines.h: %D%/stamp-defines ; @true %D%/stamp-defines: config.h Makefile - $(AM_V_GEN)$(SED) -n -e '/^#define HAVE_.*1$$/{ s/ 1$$/",/; s/.* HAVE_/"HAVE_/; p }' < config.h > %D%/defines.hin + $(AM_V_GEN)$(SED) -n -e '/^#define HAVE_.*1$$/{ s/ 1$$/",/; s/.* HAVE_/"HAVE_/; p; }' < config.h > %D%/defines.hin $(AM_V_at)$(SHELL) $(srcroot)/move-if-change %D%/defines.hin %D%/defines.h $(AM_V_at)touch $@ -- 2.55.0