From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id wYTcOLQmg2q1LC0AWB0awg (envelope-from ) for ; Mon, 17 Aug 2026 11:20:20 -0400 Received: by simark.ca (Postfix, from userid 112) id E46A91E167; Mon, 17 Aug 2026 11:20:20 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6C9FF1E033 for ; Mon, 17 Aug 2026 11:20:20 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E515B4BA79A2 for ; Mon, 17 Aug 2026 15:20:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E515B4BA79A2 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 580484BA2E08; Mon, 17 Aug 2026 15:16:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 580484BA2E08 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 580484BA2E08 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786979812; cv=none; b=q78b3AW4Y3L0B9k74alWkz2uUIk/mSqzp8ptE66WZ/BhjHjBDi2E1V80mL0Bbu7zrEGF895snF8iDOoSmAcDNd8hwum+OzXS6dxsrCfcDmRGYVkLRPTf7siQqjCaRwqGLkohlB0kUtMkci0KOp0FXTsuxFVYwXHgC0lA5Rmjqoo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786979812; c=relaxed/simple; bh=RqD00ZTZl6fRpgsVuoDbakj6tExfqSkuu1HJYjzHyAY=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=sb5+9eWWBVZ4utwDFDdI95RRaYIg9rUfTb9OBMxsPGIlxjopiDZ6AQO+asPDis+vnqClTSk+uSkyHZj6LtNyODPJikyHOZFefxP2zx4Wl5Y+fUBi2fUq1pjFYbcT9AAhUFAemi64pZxVbhI+CPciGpm1pINdoGqVmeJLqgILTtM= ARC-Authentication-Results: i=1; sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 580484BA2E08 Received: by simark.ca (Postfix) id 7B9721E0A3; Mon, 17 Aug 2026 11:16:51 -0400 (EDT) From: Simon Marchi To: gdb-patches@sourceware.org, binutils@sourceware.org Cc: Simon Marchi Subject: [PATCH 02/13] gdbsupport: remove uses of sprintf Date: Mon, 17 Aug 2026 11:16:07 -0400 Message-ID: <20260817151646.152571-3-simon.marchi@efficios.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817151646.152571-1-simon.marchi@efficios.com> References: <20260817151646.152571-1-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org When building on macOS, I get some errors about the uses of sprintf: CXX xml-utils.o /Users/smarchi/src/binutils-gdb/gdbsupport/xml-utils.cc:91:8: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Werror,-Wdeprecated-declarations] 91 | sprintf (str, "%d", va_arg (ap, int)); | ^ We know they are safe, because the 32 byte destination buffer is large enough for all conversions. But I also don't think it's a big deal to switch to xsnprintf to avoid these errors, and to catch any future error. Change-Id: If3531e1916e103dfccd0ec033639b14a2b6df3cf --- gdbsupport/xml-utils.cc | 35 +++++++++++++++++++---------------- 1 file changed, 19 insertions(+), 16 deletions(-) diff --git a/gdbsupport/xml-utils.cc b/gdbsupport/xml-utils.cc index 13dc27499120..cec7281c9297 100644 --- a/gdbsupport/xml-utils.cc +++ b/gdbsupport/xml-utils.cc @@ -88,52 +88,55 @@ string_xml_appendf (std::string &buffer, const char *format, ...) str = va_arg (ap, char *); break; case 'd': - sprintf (str, "%d", va_arg (ap, int)); + xsnprintf (buf, sizeof (buf), "%d", va_arg (ap, int)); break; case 'u': - sprintf (str, "%u", va_arg (ap, unsigned int)); + xsnprintf (buf, sizeof (buf), "%u", va_arg (ap, unsigned int)); break; case 'x': - sprintf (str, "%x", va_arg (ap, unsigned int)); + xsnprintf (buf, sizeof (buf), "%x", va_arg (ap, unsigned int)); break; case 'o': - sprintf (str, "%o", va_arg (ap, unsigned int)); + xsnprintf (buf, sizeof (buf), "%o", va_arg (ap, unsigned int)); break; case 'l': f++; switch (*f) { case 'd': - sprintf (str, "%ld", va_arg (ap, long)); + xsnprintf (buf, sizeof (buf), "%ld", va_arg (ap, long)); break; case 'u': - sprintf (str, "%lu", va_arg (ap, unsigned long)); + xsnprintf (buf, sizeof (buf), "%lu", + va_arg (ap, unsigned long)); break; case 'x': - sprintf (str, "%lx", va_arg (ap, unsigned long)); + xsnprintf (buf, sizeof (buf), "%lx", + va_arg (ap, unsigned long)); break; case 'o': - sprintf (str, "%lo", va_arg (ap, unsigned long)); + xsnprintf (buf, sizeof (buf), "%lo", + va_arg (ap, unsigned long)); break; case 'l': f++; switch (*f) { case 'd': - sprintf (str, "%" PRId64, - (int64_t) va_arg (ap, long long)); + xsnprintf (buf, sizeof (buf), "%" PRId64, + (int64_t) va_arg (ap, long long)); break; case 'u': - sprintf (str, "%" PRIu64, - (uint64_t) va_arg (ap, unsigned long long)); + xsnprintf (buf, sizeof (buf), "%" PRIu64, + (uint64_t) va_arg (ap, unsigned long long)); break; case 'x': - sprintf (str, "%" PRIx64, - (uint64_t) va_arg (ap, unsigned long long)); + xsnprintf (buf, sizeof (buf), "%" PRIx64, + (uint64_t) va_arg (ap, unsigned long long)); break; case 'o': - sprintf (str, "%" PRIo64, - (uint64_t) va_arg (ap, unsigned long long)); + xsnprintf (buf, sizeof (buf), "%" PRIo64, + (uint64_t) va_arg (ap, unsigned long long)); break; default: str = 0; -- 2.55.0