From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gbbGL+smg2q1LC0AWB0awg (envelope-from ) for ; Mon, 17 Aug 2026 11:21:15 -0400 Received: by simark.ca (Postfix, from userid 112) id BD4A31E168; Mon, 17 Aug 2026 11:21:15 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 376091E033 for ; Mon, 17 Aug 2026 11:21:15 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C45A14BA9034 for ; Mon, 17 Aug 2026 15:21:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C45A14BA9034 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id B04FE4BA79BC; Mon, 17 Aug 2026 15:18:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B04FE4BA79BC Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B04FE4BA79BC Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786979935; cv=none; b=K997S3itFN/L5vc5rKyRhVS1LytQOWREVG0KqjuGI8Qbr6ze3qS2MCrEBkqv0iocLkWJlEal6/wQ2+i2sLGUvg2S1+6v6a1UJQwAv5uH6/wzIMFvcA9DZD8sxyITrnmgFuNcDNkyduBnx8gRol78JC1cyXMrCXYbGxq9Pn+cTKA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786979935; c=relaxed/simple; bh=aQxHI5funKTOFVP/mz3CNMC8or0I1jTWyWpcBroL40Y=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=yEkw5FzW8skuB3lKPHCTK5JaME8sZjp69kjsVlmHApG0bbAX/KJr0prc68xWI+VH+q2UjepCg/yr/SpCHL/PF/RMjI9jHSM8rxQC/hPtQiQpwKqfXanDK+leXrdV13v0Dz8vVXLpoD9nfbMsa4lOama02YgzLd7ZmLn7T+gcC94= ARC-Authentication-Results: i=1; sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B04FE4BA79BC Received: by simark.ca (Postfix) id 843211E171; Mon, 17 Aug 2026 11:18:53 -0400 (EDT) From: Simon Marchi To: gdb-patches@sourceware.org, binutils@sourceware.org Cc: Simon Marchi Subject: [PATCH 13/13] gdb/tracepoint: remove uses of sprintf Date: Mon, 17 Aug 2026 11:16:18 -0400 Message-ID: <20260817151646.152571-14-simon.marchi@efficios.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817151646.152571-1-simon.marchi@efficios.com> References: <20260817151646.152571-1-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org When building on macOS, I get some: /Users/smarchi/src/binutils-gdb/gdb/tracepoint.c:1196:4: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Werror,-Wdeprecated-declarations] 1196 | sprintf (end, "M-1,%s,%lX", phex_nz (m_memranges[i].start, 0), | ^ Replace them with xsnprintf. Change-Id: Id3ec76c47e5c0091fa3a028e36063b2115378e7e --- gdb/tracepoint.c | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/gdb/tracepoint.c b/gdb/tracepoint.c index 798bb9a552d8..932a8f557e44 100644 --- a/gdb/tracepoint.c +++ b/gdb/tracepoint.c @@ -1164,6 +1164,9 @@ collection_list::stringify () gdb_printf ("\n"); if (!m_memranges.empty () && info_verbose) gdb_printf ("Collecting memranges: \n"); + + char *buf_end = temp_buf.data () + temp_buf.size (); + for (i = 0, count = 0, end = temp_buf.data (); i < m_memranges.size (); i++) { @@ -1193,11 +1196,12 @@ collection_list::stringify () "FFFFFFFF" (or more, depending on sizeof (unsigned)). Special-case it. */ if (m_memranges[i].type == memrange_absolute) - sprintf (end, "M-1,%s,%lX", phex_nz (m_memranges[i].start, 0), - (long) length); + xsnprintf (end, buf_end - end, "M-1,%s,%lX", + phex_nz (m_memranges[i].start, 0), (long) length); else - sprintf (end, "M%X,%s,%lX", m_memranges[i].type, - phex_nz (m_memranges[i].start, 0), (long) length); + xsnprintf (end, buf_end - end, "M%X,%s,%lX", + m_memranges[i].type, phex_nz (m_memranges[i].start, 0), + (long) length); } count += strlen (end); @@ -1213,7 +1217,9 @@ collection_list::stringify () count = 0; end = temp_buf.data (); } - sprintf (end, "X%08X,", (int) m_aexprs[i]->buf.size ()); + + xsnprintf (end, buf_end - end, "X%08X,", + (int) m_aexprs[i]->buf.size ()); end += 10; /* 'X' + 8 hex digits + ',' */ count += 10; @@ -2816,11 +2822,14 @@ encode_source_string (int tpnum, ULONGEST addr, { if (80 + strlen (srctype) > buf_size) error (_("Buffer too small for source encoding")); - sprintf (buf, "%x:%s:%s:%x:%x:", - tpnum, phex_nz (addr), - srctype, 0, (int) strlen (src)); + + xsnprintf (buf, buf_size, "%x:%s:%s:%x:%x:", + tpnum, phex_nz (addr), + srctype, 0, (int) strlen (src)); + if (strlen (buf) + strlen (src) * 2 >= buf_size) error (_("Source string too long for buffer")); + bin2hex ((gdb_byte *) src, buf + strlen (buf), strlen (src)); return -1; } -- 2.55.0