From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id oY9rN+Mmg2qoLS0AWB0awg (envelope-from ) for ; Mon, 17 Aug 2026 11:21:07 -0400 Received: by simark.ca (Postfix, from userid 112) id DFCD31E033; Mon, 17 Aug 2026 11:21:07 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8398D1E033 for ; Mon, 17 Aug 2026 11:21:07 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C0B954BA7992 for ; Mon, 17 Aug 2026 15:21:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C0B954BA7992 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 1E44D4BA79B9; Mon, 17 Aug 2026 15:18:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1E44D4BA79B9 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1E44D4BA79B9 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786979934; cv=none; b=CDI7TOl6v3zqSOhNq5y4dtXv02bR6s+ShppkHOpWzMVLOA1ZHkvJjoIBFYv2NCo5bqaMK7koa+PkBrI/nPR16P7bZJ6N0cNXq7CS7A1pmDwvQoGkgvC2fTBiKPO5AwIIUyfgUkVn7FLr4Oa9Qny5FCCpPCMGnVCUveOf2xoU43Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786979934; c=relaxed/simple; bh=6p/KfTwll3M8yfrYwwN24+QrdFlBEml8jOuJ/6t6HQM=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=WoHyr5X8bq6B5lZnuPnXJ4zbnpqIW6GsUPOa4xtmuV+0lAbvkF+ETm541zA6QykNCvnmJltGLoLFmcMPwtIQEHJ7U8jVs9QHIP6rkhC89sQFkYSDTqeb/tpyv+HLQbS0X6RhpjS8VQzB69ZO+4OF/5VHwERs/aoRZHkq8Ldm+LI= ARC-Authentication-Results: i=1; sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1E44D4BA79B9 Received: by simark.ca (Postfix) id 451051E09E; Mon, 17 Aug 2026 11:18:53 -0400 (EDT) From: Simon Marchi To: gdb-patches@sourceware.org, binutils@sourceware.org Cc: Simon Marchi Subject: [PATCH 09/13] gdb/elfread: remove use of sprintf Date: Mon, 17 Aug 2026 11:16:14 -0400 Message-ID: <20260817151646.152571-10-simon.marchi@efficios.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817151646.152571-1-simon.marchi@efficios.com> References: <20260817151646.152571-1-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org When building on macOS, I get: /Users/smarchi/src/binutils-gdb/gdb/elfread.c:813:3: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Werror,-Wdeprecated-declarations] 813 | sprintf (name_got_plt, "%s" SYMBOL_GOT_PLT_SUFFIX, name); | ^ Change this use of sprintf with an std::string, which also allows getting rid of a use of alloca. Change-Id: I296e25c863463ef05eca582c8303557570d63cf0 --- gdb/elfread.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/gdb/elfread.c b/gdb/elfread.c index e3890ae0270c..fcbd0176d08f 100644 --- a/gdb/elfread.c +++ b/gdb/elfread.c @@ -804,20 +804,17 @@ static int elf_gnu_ifunc_resolve_by_got (const char *name, CORE_ADDR *addr_p) { gnu_ifunc_debug_printf ("resolving \"%s\" by GOT", name); - char *name_got_plt; - const size_t got_suffix_len = strlen (SYMBOL_GOT_PLT_SUFFIX); int found = 0; const char *func = __func__; - name_got_plt = (char *) alloca (strlen (name) + got_suffix_len + 1); - sprintf (name_got_plt, "%s" SYMBOL_GOT_PLT_SUFFIX, name); + std::string name_got_plt = std::string (name) + SYMBOL_GOT_PLT_SUFFIX; /* FIXME: we only search the initial namespace. To search other namespaces, we would need to provide context, e.g. in form of an objfile in that namespace. */ current_program_space->iterate_over_objfiles_in_search_order - ([name, name_got_plt, &addr_p, &found, func] (struct objfile *objfile) + ([name, &name_got_plt, &addr_p, &found, func] (struct objfile *objfile) { bfd *obfd = objfile->obfd.get (); struct gdbarch *gdbarch = objfile->arch (); @@ -828,8 +825,8 @@ elf_gnu_ifunc_resolve_by_got (const char *name, CORE_ADDR *addr_p) gdb_byte *buf = (gdb_byte *) alloca (ptr_size); bound_minimal_symbol msym - = lookup_minimal_symbol (current_program_space, name_got_plt, - objfile); + = lookup_minimal_symbol (current_program_space, + name_got_plt.c_str (), objfile); if (msym.minsym == NULL) return 0; if (msym.minsym->type () != mst_slot_got_plt) @@ -850,7 +847,8 @@ elf_gnu_ifunc_resolve_by_got (const char *name, CORE_ADDR *addr_p) addr = gdbarch_addr_bits_remove (gdbarch, addr); gnu_ifunc_debug_printf_func (func, "GOT entry \"%s\" points to %s", - name_got_plt, paddress (gdbarch, addr)); + name_got_plt.c_str (), + paddress (gdbarch, addr)); if (elf_gnu_ifunc_record_cache (name, addr)) { -- 2.55.0