From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id aj0sEwewfWrqOCMAWB0awg (envelope-from ) for ; Thu, 13 Aug 2026 07:52:39 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=umM3SIxT; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=awPwwer/; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=iAVDaUUc; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=QwI1RF58; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3EAB01E033; Thu, 13 Aug 2026 07:52:39 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A68BD1E033 for ; Thu, 13 Aug 2026 07:52:37 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 59FBC4BA798C for ; Thu, 13 Aug 2026 11:52:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 59FBC4BA798C Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=umM3SIxT; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=awPwwer/; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=iAVDaUUc; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=QwI1RF58 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 8E7814BA2E12 for ; Thu, 13 Aug 2026 11:52:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8E7814BA2E12 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8E7814BA2E12 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786621924; cv=none; b=UxoEdZfGm8d471M+qJTG/fvL3/z+yKM6VQ9f7Z/T6og1LLmTthf9DSHoezDbmBkewdJWv/Qu4f7ogiYMkIH7qXJun+s5aEC/13UOeaSf2SQl1hVhno+PH8EsbW5dmvhapE6kH+iRiTjRLOd9MzXnnyyazlVReMpyAINNMgm1R2Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786621924; c=relaxed/simple; bh=Kyd+HvStzKJAhOuAmJmDdX0ZNETdft6ayu00foA4o+8=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=WPF095KAOHIN300iZ+9bgP3AjGkgLlLx3buxnefx5+qpvUw3gNzQK1mZ1AK7M8MmeBLwJU4sa55EilRdsRQJzCBNE7lXjbu9cAGfCHberYGXwdL0KdvZNPZ6+x/J3Ky5G+6Em6TrRpy8CwnqixysIBi4HLREz5/lHAWz7ZH/uUk= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=umM3SIxT; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=awPwwer/; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=iAVDaUUc; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=QwI1RF58 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8E7814BA2E12 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4B3243E8F for ; Thu, 13 Aug 2026 11:51:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1786621919; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ge2QNSP3op6TUiQifzBsIxSjB0aaBf4IgBOo6x0vgKw=; b=umM3SIxTpMAbhWxR/4K+iVx03Cnu+7pZrGCQ58KT7pnNMxd6sR6213PAMc38dE7CgUgehc LGkAn4gCqItWQ8Ropgk4lCy7jedS7MlWxvdIU3uqlYH4BXsKd0MdgohW/Qwmr+/m7r2HPv T0YJrdz54F98gSmEmfgwAxChU7iA4yw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1786621919; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ge2QNSP3op6TUiQifzBsIxSjB0aaBf4IgBOo6x0vgKw=; b=awPwwer/TxwnfVDtVjWLa2d8uDPFekK0NWAlfk/84KwLmtBGeNYxrePfdn/GfiTOpKGjcF is2lF2CnXHx5LsAw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=iAVDaUUc; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=QwI1RF58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1786621915; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ge2QNSP3op6TUiQifzBsIxSjB0aaBf4IgBOo6x0vgKw=; b=iAVDaUUchh5JwQze176FhLLln4WM1cr5nU5NQoNNdu036xm0TFCE+rszGlERMjyrZLGuuc oNgU/haxixDlTNMih0yatQGCiXxvc4PPgIi64grf1XtadYs5QbE5mkIYOKfpnFGZI0UEz0 GN0vDXt9c4Zu4ffEUm1ubOTBKAR8FJM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1786621915; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ge2QNSP3op6TUiQifzBsIxSjB0aaBf4IgBOo6x0vgKw=; b=QwI1RF589P/FsqyZvYt8VqTwbdaAYNYBkfqbWsrXOY62NaZDuPPXm7QKNt06RZy9R8xdl4 AD9V+8FGVpdWXnDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3551E77DDC for ; Thu, 13 Aug 2026 11:51:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id awyhC9uvfWqoLgAAD6G6ig (envelope-from ) for ; Thu, 13 Aug 2026 11:51:55 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH] [gdb/build] Add warning_prefix_default/error_prefix_default constants Date: Thu, 13 Aug 2026 13:51:53 +0200 Message-ID: <20260813115154.2547573-1-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: 4B3243E8F X-Spamd-Result: default: False [-3.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_TLS_ALL(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:dkim,sourceware.org:url,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Post-commit review of commit f33422af6d8 ("[gdb/build] Fix cli/cli-style.c build error with C++20") pointed out the need for a comment for a reinterpret_cast [1]. While reviewing the comment in gdb/top.c for bd_heavy_horizontal et al, I realized I could use the same style: ... static const char bd_heavy_horizontal[] = u8"\u2501"; ... and get rid of the reinterpret_cast. Add warning_prefix_default and error_prefix_default constants, and copy the comment from gdb/top.c. Tested on x86_64-linux. [1] https://sourceware.org/pipermail/gdb-patches/2026-August/229421.html --- gdb/cli/cli-style.c | 29 +++++++++++++++++++---------- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/gdb/cli/cli-style.c b/gdb/cli/cli-style.c index 5c26519c6d7..cc22b861ca0 100644 --- a/gdb/cli/cli-style.c +++ b/gdb/cli/cli-style.c @@ -449,13 +449,26 @@ no_emojis () emoji_styling = AUTO_BOOLEAN_FALSE; } -/* Emoji warning prefix: +/* Emoji warning prefix default: - u26A0: Warning Sign: ⚠ - uFE0F: Variation Selector-16 (VS16) The VS16 forces "Emoji" presentation. It is needed because the default - presentation for Warning Sign is "Text". Together, we get: ⚠️ . */ -static std::string warning_prefix - = reinterpret_cast (u8"\u26A0\uFE0F "); + presentation for Warning Sign is "Text". Together, we get: ⚠️ . + + Emoji error prefix default: + - u274C: Cross Mark: ❌ + No VS16 is needed because the default presentation for Cross Mark is + "Emoji". + + UTF-8 string literals have type: + - const char[N] (until C++20), or + - const char8_t[N] (since C++20). + Assign them to a variable to stabilize the type. */ +static const char warning_prefix_default[] = u8"\u26A0\uFE0F "; +static const char error_prefix_default[] = u8"\u274C "; + +/* Emoji warning prefix. */ +static std::string warning_prefix = warning_prefix_default; /* Implement 'show style warning-prefix'. */ @@ -476,12 +489,8 @@ print_warning_prefix (ui_file *file) gdb_puts (warning_prefix.c_str (), file); } -/* Emoji error prefix: - - u274C: Cross Mark: ❌ - No VS16 is needed because the default presentation for Cross Mark is - "Emoji". */ -static std::string error_prefix - = reinterpret_cast (u8"\u274C "); +/* Emoji error prefix. */ +static std::string error_prefix = error_prefix_default; /* Implement 'show style error-prefix'. */ base-commit: f33422af6d81c623871f1407e2fce0794e90739a -- 2.51.0