Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [PATCH] [gdb/build] Fix cli/cli-style.c build error with C++20
Date: Thu, 13 Aug 2026 04:54:45 +0200	[thread overview]
Message-ID: <20260813025445.237662-1-tdevries@suse.de> (raw)

PR build/34514 reports for a C++20 build:
...
cli/cli-style.c:457:37: error: conversion from ‘const char8_t [8]’ to \
  non-scalar type ‘std::string’ {aka ‘std::__cxx11::basic_string<char>’} \
  requested
  457 | static std::string warning_prefix = u8"\u26A0\uFE0F ";
      |                                     ^~~~~~~~~~~~~~~~~
...

The u8 literal is char[] until C++20, but char8_t[] since C++20.

Fix this by using a reinterpret_cast<const char *>.

Tested by rebuilding using GCC 15.3.0, with and without -std=c++20.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34514
---
 gdb/cli/cli-style.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gdb/cli/cli-style.c b/gdb/cli/cli-style.c
index 60c00acdf43..5c26519c6d7 100644
--- a/gdb/cli/cli-style.c
+++ b/gdb/cli/cli-style.c
@@ -454,7 +454,8 @@ no_emojis ()
    - uFE0F: Variation Selector-16 (VS16)
    The VS16 forces "Emoji" presentation.  It is needed because the default
    presentation for Warning Sign is "Text".  Together, we get: ⚠️ .  */
-static std::string warning_prefix = u8"\u26A0\uFE0F ";
+static std::string warning_prefix
+  = reinterpret_cast<const char *> (u8"\u26A0\uFE0F ");
 
 /* Implement 'show style warning-prefix'.  */
 
@@ -479,7 +480,8 @@ print_warning_prefix (ui_file *file)
    - u274C: Cross Mark: ❌
    No VS16 is needed because the default presentation for Cross Mark is
    "Emoji".  */
-static std::string error_prefix = u8"\u274C ";
+static std::string error_prefix
+  = reinterpret_cast<const char *> (u8"\u274C ");
 
 /* Implement 'show style error-prefix'.  */
 

base-commit: dbf19e0f878eb592011c25c1dbbfc35eee330ec2
-- 
2.51.0


             reply	other threads:[~2026-08-13  2:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-13  2:54 Tom de Vries [this message]
2026-08-13  3:15 ` Simon Marchi
2026-08-13  4:34 ` Eli Zaretskii
2026-08-13 11:53   ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260813025445.237662-1-tdevries@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox