From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id HEAHIpN7fGoFniAAWB0awg (envelope-from ) for ; Wed, 12 Aug 2026 09:56:35 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=th20l91T; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=YniGzDrl; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=mX1O1s0U; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=TVSyZnrv; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 79A6E1E033; Wed, 12 Aug 2026 09:56:35 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CD95C1E033 for ; Wed, 12 Aug 2026 09:56:34 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5C6914B99F53 for ; Wed, 12 Aug 2026 13:56:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5C6914B99F53 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=th20l91T; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=YniGzDrl; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=mX1O1s0U; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=TVSyZnrv Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id DA6954BA5434 for ; Wed, 12 Aug 2026 13:56:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DA6954BA5434 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DA6954BA5434 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786542964; cv=none; b=jJLoEte8/Be3ZAAtfANb6w+/qkx5FbqwQykix22H3iPttfZqsPSN2iSRT5ckPY1NlmPGW2teRn1LV34IkLQAeVfkjLYjxMJYwJRf2NHwhP5JEYAIKS5cUP+hC6cM1uy+rdn0fC2KFlAMFBMqMfjVBd/bay+pQVu2cS9uJWo4HtE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786542964; c=relaxed/simple; bh=0Xqk1fwg+koAvmaqMlqRCsB4EnOEa0R/iKZuTMIqnkU=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=YMthswlfADucuipfYd/gStAU9tvEdj2o7cD80Pg5D+Kd21/GF4aP8RbdcewOXWIVsXAXD1ff6FUWiHtdk+kuwDNjD9vvjL1eIft5mCyH3UqcSNMRKEjLdWT0XrzHS/bosLfgc2HDyeDZdUs91b2ns6Z5hGQc0Sy6ZMoVeT5uK88= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=th20l91T; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=YniGzDrl; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=mX1O1s0U; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=TVSyZnrv DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DA6954BA5434 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AC3323E5F for ; Wed, 12 Aug 2026 13:55:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1786542958; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yYitnbXdiMy4rw2hfPjEsXV7eQ5iJ0Xi52mt3JyP7N0=; b=th20l91TuPiIARFNetKEIkqSPtlbsFCGgEtSE+rAD1gTxTULsnZk3FZ9FqjVI4nl1WtXfv vBM958wotELmVQLvT1upCeNEsTwYLMejKgANZvZABTdeHcExCHszW2IVcPHT3J0GKGrsIB g1T/+2Qj3rFGUKi3Ucg5TmLbinZ7ZmU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1786542958; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yYitnbXdiMy4rw2hfPjEsXV7eQ5iJ0Xi52mt3JyP7N0=; b=YniGzDrl91l3Sfe2s1lNC5xX0zpYYaQD4Nbx8/hGAjbiXew7S/oHLGM5GvsEOQxwApd8Fh ae28mrP2g8hbWrCg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=mX1O1s0U; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=TVSyZnrv DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1786542954; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yYitnbXdiMy4rw2hfPjEsXV7eQ5iJ0Xi52mt3JyP7N0=; b=mX1O1s0U+UAHWeWv8cO/EH7wQ0O1hu8mm9OHHER2vWbJZNhJzJr8pfPyL0Uyo4LuPMAPH3 mD/G/VUsr4n0162SWroAZqXuQ2W/QGwu25DjCeQB+pLZlgxJM/Rnog2loUVlGelsWyqpGc wm9D7c/GkyQYVq335JuYqIqcmKJ9dFc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1786542954; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yYitnbXdiMy4rw2hfPjEsXV7eQ5iJ0Xi52mt3JyP7N0=; b=TVSyZnrvdYjYZzrEk63Q2wZBt6bM4sHhgoBOXMs8jH/idH7oBlDgHapHGlp1kUn7AbJEGf pM4nO6xUJOm8nYCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 95361779B2 for ; Wed, 12 Aug 2026 13:55:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id N7sKI2p7fGpSfgAAD6G6ig (envelope-from ) for ; Wed, 12 Aug 2026 13:55:54 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH] [gdb] Rewrite error and warning emojis Date: Wed, 12 Aug 2026 15:55:54 +0200 Message-ID: <20260812135554.2356569-1-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: AC3323E5F X-Spamd-Result: default: False [-3.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_ONE(0.00)[1]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,compart.com:url,unicode.org:url,suse.de:mid,suse.de:dkim]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org While working on PR34501 I realized that these two strings actually contain two unicode characters: ... static std::string warning_prefix = "⚠️ "; static std::string error_prefix = "❌️ "; ... Both the Warning Sign [1] and the Cross Mark [2] are followed by Variation Selector-16 (VS16) [3]. To make this obvious, I decided to rewrite in a style that makes it explicit both which unicode characters are used, and how they are encoded: ... static std::string warning_prefix = u8"\u26A0\uFE0F "; ... In the process I found out that the Cross Mark doesn't need VS16, because its default presentation is already "Emoji" rather than "Text", so that one simply becomes: ... static std::string error_prefix = u8"\u274C "; ... AFAICT, this property (default presentation == "Emoji") can be verified by finding Cross Mark here [4] and checking that property Emoji_Presentation applies. Tested on x86_64-linux. [1] https://www.compart.com/en/unicode/U+26A0 [2] https://www.compart.com/en/unicode/U+274C [3] https://www.compart.com/en/unicode/U+FE0F [4] https://www.unicode.org/Public/17.0.0/ucd/emoji/emoji-data.txt --- gdb/cli/cli-style.c | 15 +++++++++++---- gdb/testsuite/gdb.base/style.exp | 2 +- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/gdb/cli/cli-style.c b/gdb/cli/cli-style.c index 03a887232c7..5c175ee29ea 100644 --- a/gdb/cli/cli-style.c +++ b/gdb/cli/cli-style.c @@ -449,8 +449,12 @@ no_emojis () emoji_styling = AUTO_BOOLEAN_FALSE; } -/* Emoji warning prefix. */ -static std::string warning_prefix = "⚠️ "; +/* Emoji warning prefix: + - u26A0: Warning Sign: ⚠ + - uFE0F: Variation Selector-16 (VS16) + The VS16 forces "Emoji" presentation. It is needed because the default + presentation for Warning Sign is "Text". Together, we get: ⚠️ . */ +static std::string warning_prefix = u8"\u26A0\uFE0F "; /* Implement 'show style warning-prefix'. */ @@ -471,8 +475,11 @@ print_warning_prefix (ui_file *file) gdb_puts (warning_prefix.c_str (), file); } -/* Emoji error prefix. */ -static std::string error_prefix = "❌️ "; +/* Emoji error prefix: + - u274C: Cross Mark: ❌ + No VS16 is needed because the default presentation for Cross Mark is + "Emoji". */ +static std::string error_prefix = u8"\u274C "; /* Implement 'show style error-prefix'. */ diff --git a/gdb/testsuite/gdb.base/style.exp b/gdb/testsuite/gdb.base/style.exp index 8a49d1c5973..8d576ff00f1 100644 --- a/gdb/testsuite/gdb.base/style.exp +++ b/gdb/testsuite/gdb.base/style.exp @@ -335,7 +335,7 @@ proc run_style_tests { } { gdb_test_no_output "set host-charset UTF-8" # Chosen since it will print an error. gdb_test "maint translate-address" \ - "❌️ requires argument.*" \ + "❌ requires argument.*" \ "emoji output" gdb_test_no_output "set style error-prefix abcd:" \ base-commit: 17afc47d8bc304f527eb58ea8086a39fdc0cbd19 -- 2.51.0