From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id dwR+CrnWemqejBwAWB0awg (envelope-from ) for ; Tue, 11 Aug 2026 04:00:57 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=S1kpQCFC; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Al7r7hZv; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=TmIM2coP; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=9cCr3PEH; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 14D361E166; Tue, 11 Aug 2026 04:00:57 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 802441E033 for ; Tue, 11 Aug 2026 04:00:54 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2A05C4BA79B9 for ; Tue, 11 Aug 2026 08:00:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2A05C4BA79B9 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=S1kpQCFC; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Al7r7hZv; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=TmIM2coP; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=9cCr3PEH Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id B301A4BA799F for ; Tue, 11 Aug 2026 08:00:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B301A4BA799F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B301A4BA799F Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786435228; cv=none; b=jGfGqQraYQXVKkPHTCh2jLJUAdskQa54P/1JqGnfwSOb+HrjbdAF+DNjcvy3aVd20udWYYmapOk70rmMPB7UQAX3T6uGWoq7k0bKnoqbkzHK20jA/LVLYl+XJY9XafFCwsiNxudzBOgW/ni1mGWKllXDZcTP3s9foOOYu7kM3qg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786435228; c=relaxed/simple; bh=7/ISF7VCjlpn3AljhDgLhsOUGINpcNmugfWiUOXcu6s=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=PH+O4ZjkYmnQMJ5j9qzJ5caDHKz1l643St+U2VxVrCpiu0L67xgyOtKHoRpy1uO3OQtqnnkawSEEWwIcalsmH0yjVJTzIMlOby9MUM44qIdZwFwK6DQsn4Mm7fPsvQhxNS+NOjCTWtv2ul6i3YVndTeqv23rRE+YZBMhaI9jymg= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=S1kpQCFC; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Al7r7hZv; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=TmIM2coP; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=9cCr3PEH DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B301A4BA799F Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B35873E22 for ; Tue, 11 Aug 2026 08:00:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1786435222; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Wspe3UZAWF3Z7ECCGwnkGo2HJJa5R8T0sW42eFnHJBU=; b=S1kpQCFCbi8uRpZ+jqDmfbrSdAwMMzh/yXuwScpW8/oJTR9Oz+k23cFftFoNMp4Pr5BsgI PVhngV+qvTSHHDwdxpjqsYVGmYMHo4gLyERbm3gfILOq56Hb88qDMaG8Yf5/+4+1nbBHUO uXy5Bj6up8b9DnjUQ0Iym/WluI2Gipc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1786435222; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Wspe3UZAWF3Z7ECCGwnkGo2HJJa5R8T0sW42eFnHJBU=; b=Al7r7hZvxBLR3HsOoikW4xsWAEyUi0o8wfZZAd1rsAt6I54fpbDuyFyHcdTnUIbQyMQ3H2 5WmkV7s25ztnHCCQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=TmIM2coP; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=9cCr3PEH DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1786435218; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Wspe3UZAWF3Z7ECCGwnkGo2HJJa5R8T0sW42eFnHJBU=; b=TmIM2coPWM5ZsmYo5ztP9N1WvTR/v4hoxoWUBQOzl9NlQH6cgs4Sk+eTN80VDE4KmaABsc s3W/LPuausvYpiiIDZ8ecFn2MT+D84XW4JREIZCEV0MFZN77F1UwLm38/vwMcDTvxfg2mL YBBsFJ4ZiemSJgBGT9lkJdV/0SRYXNM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1786435218; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Wspe3UZAWF3Z7ECCGwnkGo2HJJa5R8T0sW42eFnHJBU=; b=9cCr3PEHAVoJyCjhwM/42+GX9XsUhapg5rPa3eodFLNBoK5aMaIUgSQBGpwq8iEeuVz7aM FLdkycZsZHJDEZAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9F48A779B2 for ; Tue, 11 Aug 2026 08:00:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id wbiMJZLWemq4JQAAD6G6ig (envelope-from ) for ; Tue, 11 Aug 2026 08:00:18 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH] [gdb/python] Document quit_force uses Date: Tue, 11 Aug 2026 10:00:18 +0200 Message-ID: <20260811080018.1151006-1-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; FROM_EQ_ENVFROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:dkim]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_TLS_ALL(0.00)[]; TO_DN_NONE(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Queue-Id: B35873E22 X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org The Python extension has two functions that convert exceptions from the GDB domain to the Python domain and vice versa: gdbpy_convert_exception and gdbpy_handle_exception. Each function has an exception though, where it calls quit_force: - for gdbpy_convert_exception, when handling gdb_exception_forced_quit, and - for gdbpy_handle_exception, when handling SystemExit. I think it's a good idea to document these exceptions in more detail, and since AFAICT the reasoning is the same, I've added the same comment in both places. --- gdb/python/py-utils.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/gdb/python/py-utils.c b/gdb/python/py-utils.c index a831b96eb38..1c68b206601 100644 --- a/gdb/python/py-utils.c +++ b/gdb/python/py-utils.c @@ -221,7 +221,14 @@ gdbpy_convert_exception (const struct gdb_exception &exception) if (exception.reason == RETURN_QUIT) exc_class = PyExc_KeyboardInterrupt; else if (exception.reason == RETURN_FORCED_QUIT) - quit_force (NULL, 0); + { + /* Ideally we'd like to propagate the exception to top-level, where + we'll call quit_force. Propagating the exception would ensure that + appropriate cleanups are run. + OTOH, there is the risk that the exception will be swallowed. + For now, don't take this risk and immediately call quit_force. */ + quit_force (NULL, 0); + } else if (exception.error == MEMORY_ERROR) exc_class = gdbpy_gdb_memory_error; else @@ -485,6 +492,11 @@ gdbpy_handle_exception () exit_arg = 1; } + /* Ideally we'd like to propagate the exception to top-level, where + we'll call quit_force. Propagating the exception would ensure that + appropriate cleanups are run. + OTOH, there is the risk that the exception will be swallowed. + For now, don't take this risk and immediately call quit_force. */ quit_force (&exit_arg, 0); } else if (! fetched_error.type_matches (gdbpy_gdberror_exc) base-commit: 8e6c4f526a68b796b7bd71d53e4dc459ac56c3ef -- 2.51.0