From: Pedro Alves <pedro@palves.net>
To: gdb-patches@sourceware.org
Subject: [PATCH 1/2] testsuite/lib/set_unbuffered_mode.c: Fix return type
Date: Tue, 11 Aug 2026 00:08:25 +0100 [thread overview]
Message-ID: <20260810230826.3466696-2-pedro@palves.net> (raw)
In-Reply-To: <20260810230826.3466696-1-pedro@palves.net>
The __gdb_set_unbuffered_output constructor function in
testsuite/lib/set_unbuffered_mode.c is defined to return int (and then
does not have a return statement), when it should be defined to return
void. This fixes it.
Change-Id: I94fc587c90601f6ed58cee31b94a414b77bbc733
---
gdb/testsuite/lib/set_unbuffered_mode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gdb/testsuite/lib/set_unbuffered_mode.c b/gdb/testsuite/lib/set_unbuffered_mode.c
index 4fedca672dd..6d69ccabaeb 100644
--- a/gdb/testsuite/lib/set_unbuffered_mode.c
+++ b/gdb/testsuite/lib/set_unbuffered_mode.c
@@ -19,8 +19,8 @@
#include <stdio.h>
-static int __gdb_set_unbuffered_output (void) __attribute__ ((constructor));
-static int
+static void __gdb_set_unbuffered_output (void) __attribute__ ((constructor));
+static void
__gdb_set_unbuffered_output (void)
{
setvbuf (stdout, NULL, _IONBF, BUFSIZ);
--
2.54.0
next prev parent reply other threads:[~2026-08-10 23:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 23:08 [PATCH 0/2] gdb/testsuite: Prepare set_unbuffered_mode.c for windows-msvc Pedro Alves
2026-08-10 23:08 ` Pedro Alves [this message]
2026-08-10 23:08 ` [PATCH 2/2] testsuite/lib/set_unbuffered_mode.c: Use constructor priority Pedro Alves
2026-08-11 9:01 ` [PATCH 0/2] gdb/testsuite: Prepare set_unbuffered_mode.c for windows-msvc Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260810230826.3466696-2-pedro@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox