From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gbmBMB5VemplrxsAWB0awg (envelope-from ) for ; Mon, 10 Aug 2026 18:47:58 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=palves.net header.i=@palves.net header.a=rsa-sha256 header.s=dreamhost header.b=STW2OT06; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C1D941E09B; Mon, 10 Aug 2026 18:47:58 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 63D651E09B for ; Mon, 10 Aug 2026 18:47:58 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 147654BB3BA4 for ; Mon, 10 Aug 2026 22:47:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 147654BB3BA4 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=palves.net header.i=@palves.net header.a=rsa-sha256 header.s=dreamhost header.b=STW2OT06 Received: from hedgehog.birch.relay.mailchannels.net (hedgehog.birch.relay.mailchannels.net [23.83.209.81]) by sourceware.org (Postfix) with ESMTPS id E53FD4BB3B80 for ; Mon, 10 Aug 2026 22:47:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E53FD4BB3B80 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=palves.net ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E53FD4BB3B80 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=23.83.209.81 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786402048; cv=none; b=abfh6seLsuDsWVFcLTUY2xINl6avMb4Bjtzf1A9Ay9z45FNcxWUWGYBA9KTQfGqf0TXZ6jCOA+GcHdpPoEFYrDurqRAFd530L9yWmTROfgq9lZcDuDp/IGkAzwhv4FXGEINxWd3hVo6vufpqg+etmsKvqWmUCU7ZwCGda0kUhU0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786402048; c=relaxed/simple; bh=tBcZaCAWg5/r+X8bhCiP/Kze4u+mno5Ldq47WPimYXA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=T+tij8NB74XaE6uAQWoaH5SN5zbifMXvyEmpww+VAbNUvcv7unKdHXcXmXV4SDi6lUYlYSDP5gC+RCO+3FIad0ncly38KHp4/pDq8veLDJbpyERdfWbsK48avStrnPm95/gBV0YuiMqq9m1Fnt4HX5J09J0tAyb3/vozoAl+bcE= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=palves.net header.i=@palves.net header.a=rsa-sha256 header.s=dreamhost header.b=STW2OT06 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E53FD4BB3B80 X-Sender-Id: dreamhost|x-authsender|pedro@palves.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id DBB624628C3; Mon, 10 Aug 2026 22:47:26 +0000 (UTC) Received: from pdx1-sub0-mail-a249.dreamhost.com (100-108-70-253.trex-nlb.outbound.svc.cluster.local [100.108.70.253]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 94FE6463B13; Mon, 10 Aug 2026 22:47:22 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|pedro@palves.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|pedro@palves.net X-MailChannels-Auth-Id: dreamhost X-Battle-Illustrious: 03a5331d1408903f_1786402046789_550754187 X-MC-Loop-Signature: 1786402046789:1581713018 X-MC-Ingress-Time: 1786402046789 Received: from pdx1-sub0-mail-a249.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.108.70.253 (trex/8.0.2); Mon, 10 Aug 2026 22:47:26 +0000 Received: from localhost (bl21-204-140.dsl.telepac.pt [2.82.204.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: pedro@palves.net) by pdx1-sub0-mail-a249.dreamhost.com (Postfix) with ESMTPSA id 4hJqdQ0LGxz105F; Mon, 10 Aug 2026 15:47:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=palves.net; s=dreamhost; t=1786402042; bh=AMJu/LSFYfRhM38u1J8Kfsrb1kqtnr5bZyQrPqy+8hI=; h=From:To:Cc:Subject:Date:Content-Transfer-Encoding; b=STW2OT06UuzvS+OuwwKTVqKZtBiZJRUxtlRmGqzQLT2fpVPRCijfiv/ucfNJjjaib ATl1CIynSwDkxdUsLa+YORlInF7rPmCsDi1d2RvCcFIvCKeB5QWZzHPUnG2uK6tduY 1wkVuinjO4xQhaXtL8UoDowqV5i90CGUMRzlfMZDKPiqu+wnL1a8ksQfG+I2hElqkz ADgf1mEtF6ZTU0Ul7oBDzAqARk7q8yG2YOnfe9iBgrgMFFbqCxd7Da7z8UecWmS+Pc qssQNKKMZQ8yUVOYBOTvthKLkVd8c9HJayA/pdqGK4Ye1jeegv2MZbpGpVCYu15TMA iccO4ypxkA+0w== From: Pedro Alves To: gdb-patches@sourceware.org Cc: Lancelot SIX Subject: [PATCH 2/2] allow_hipcc_tests: Allow native Windows (windows-msvc) Date: Mon, 10 Aug 2026 23:46:32 +0100 Message-ID: <20260810224633.3455055-3-pedro@palves.net> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260810224633.3455055-1-pedro@palves.net> References: <20260810224633.3455055-1-pedro@palves.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Make allow_hipcc_tests allow Windows as well. Slightly tweak the returned string to be more generic. Add comment about why we do the istarget check at all. We only allow windows-msvc, and not mingw, as the AMD ROCm compiler on Windows targets x86_64-pc-windows-msvc. Change-Id: I45262f2fe24455ade6075eded2cd7df03979c6cc --- gdb/testsuite/lib/rocm.exp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/lib/rocm.exp b/gdb/testsuite/lib/rocm.exp index 025fa63da6f..439870b8263 100644 --- a/gdb/testsuite/lib/rocm.exp +++ b/gdb/testsuite/lib/rocm.exp @@ -138,8 +138,12 @@ gdb_caching_proc allow_hip_tests {} { return {0 "remote debugging"} } - if {![istarget "*-linux*"]} { - return {0 "target platform is not Linux"} + # Check a hardcoded set of targets as an optimization, so that we + # save one external program invocation (of 'gdb --configuration') + # when GDB is not configured with amd-dbgapi support. External + # program invocations have a non-negligible time cost on Windows. + if {![istarget "*-linux*"] && ![istarget "*-*-windows-msvc*"]} { + return {0 "target platform is not supported"} } # Ensure that GDB is built with amd-dbgapi support. -- 2.54.0