From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ZlIWJ+4nemo6aRsAWB0awg (envelope-from ) for ; Mon, 10 Aug 2026 15:35:10 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=NlfdfGwy; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8F9391E166; Mon, 10 Aug 2026 15:35:10 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_SBL_CSS autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E29FD1E09B for ; Mon, 10 Aug 2026 15:35:09 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D5EF44BA23E3 for ; Mon, 10 Aug 2026 19:35:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D5EF44BA23E3 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=NlfdfGwy Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id EB69E4B9DB72 for ; Mon, 10 Aug 2026 19:34:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EB69E4B9DB72 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EB69E4B9DB72 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786390485; cv=none; b=GPsDMM9/cbRtxGJchm4Z2IpT2C1tFCWGgbUSJBrQjQE2+aiv62svHd+GxVcPlGA5zSGlq2xVlIR80S9IyIaZ3vl5IxHtCulg5gLTveopvnyWbknKOhVKnLJnL6UaEad+ESsAu2fFMxJpmDsED7La0WChOY8CF2tkEFxRLUydVgo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786390485; c=relaxed/simple; bh=bTJK9nVsuqyDJbBNmHd8CVS7gp2VjUykkVV3KdQVMkE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=tT5mCABCks02fzqdEBonx1BYXlY0fEA5abtSUTEhOaEXVc+zAXYA0s1s1spHJWGAj3m1Fgj06Y7f4XrNvLj9CVTkTiorMBOTdC7iImkkns3YyDMPWapJhX+m/RzQSRZCi8HQF+fiC9MvWaM7HopmQWGiluHiSB2nfwDRpIEAuAU= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=NlfdfGwy DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EB69E4B9DB72 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786390484; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZKQjFjuSbysUBIRYHKX/JhtVpOUmhcBV0Lb+nhyRihU=; b=NlfdfGwyQNhpdOPPXKXhoqxH/MzukimmzPOXcEtpnSdQA+zjtuHhKPhY5BmqYGIg148ke8 Ul5s527RuZJuSUdygLUPospDg6YD5Fz/w8mKH5tnEOmpk3lrGtvl8livQkSfI7eNQ6dRpT VDsV12fCZ6hVZyMxayS8GGiTXq9AXcY= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-134-sUthbNAoM0O_D5iabIHqpw-1; Mon, 10 Aug 2026 15:34:41 -0400 X-MC-Unique: sUthbNAoM0O_D5iabIHqpw-1 X-Mimecast-MFC-AGG-ID: sUthbNAoM0O_D5iabIHqpw_1786390480 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2C1751955F5A; Mon, 10 Aug 2026 19:34:40 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.96.134.31]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1960B180049F; Mon, 10 Aug 2026 19:34:37 +0000 (UTC) From: Guinevere Larsen To: gdb-patches@sourceware.org Cc: Guinevere Larsen , Christina Joos Subject: [PATCH] gdb/record: avoid rax usage in i386-avx-record.exp Date: Mon, 10 Aug 2026 16:32:32 -0300 Message-ID: <20260810193232.54873-1-guinevere@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: jrwR--QJX_YGu2UejVcsF_IntpsXphhzQ5stJo_h1fM_1786390480 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org My recent commit, 1c04308f0958cbac83bad22703758139ea6969b6: Author: Guinevere Larsen Date: Tue Jun 16 16:03:43 2026 -0300 gdb/record: add support for BMI2 instructions Introduced a few tests that rely on the rax register being set before entering the function. This isn't reliable, as eax is almost always set to 0 (except in my machine for some reason). To avoid ISAs getting in the way, this commit changes the test to use r12 (and r12w/r12d when appropriate), so that it won't be disturbed by the compiler. Reported-by: Christina Joos --- gdb/testsuite/gdb.reverse/i386-avx-reverse.c | 32 +++++++++---------- .../gdb.reverse/i386-avx-reverse.exp | 8 ++--- 2 files changed, 20 insertions(+), 20 deletions(-) diff --git a/gdb/testsuite/gdb.reverse/i386-avx-reverse.c b/gdb/testsuite/gdb.reverse/i386-avx-reverse.c index 88cd3fc7f34..4d45482c07a 100644 --- a/gdb/testsuite/gdb.reverse/i386-avx-reverse.c +++ b/gdb/testsuite/gdb.reverse/i386-avx-reverse.c @@ -770,48 +770,48 @@ bmi_test () { /* start bmi_test. */ /* Using GDB, load these values onto registers for testing. - eax = 0x1312 + r12 = 0x1312 ebx = 0xdeadbeef ecx = 0xcafeface edx = 0x2337 r8 = 0 this way it's easy to confirm we're undoing things correctly. */ - asm volatile ("andn %rbx, %rax, %r8"); - asm volatile ("andn %ebx, %eax, %ecx"); + asm volatile ("andn %rbx, %r12, %r8"); + asm volatile ("andn %ebx, %r12d, %ecx"); asm volatile ("bextr %rcx, %r8, %rbx"); asm volatile ("bextr %ebx, %ecx, %r8d"); - asm volatile ("blsi %rax, %rcx"); + asm volatile ("blsi %r12, %rcx"); asm volatile ("blsi %ebx, %r8d"); asm volatile ("blsmsk %r8, %rbx"); - asm volatile ("blsmsk %eax, %eax"); + asm volatile ("blsmsk %r12d, %r12d"); asm volatile ("blsr %rcx, %rbx"); asm volatile ("blsr %r8d, %ecx"); - asm volatile ("lzcnt %rax, %r8"); - asm volatile ("lzcnt %eax, %ecx"); - asm volatile ("lzcnt %ax, %bx"); + asm volatile ("lzcnt %r12, %r8"); + asm volatile ("lzcnt %r12d, %ecx"); + asm volatile ("lzcnt %r12w, %bx"); - asm volatile ("tzcnt %rax, %rcx"); - asm volatile ("tzcnt %eax, %ebx"); - asm volatile ("tzcnt %ax, %r8w"); + asm volatile ("tzcnt %r12, %rcx"); + asm volatile ("tzcnt %r12d, %ebx"); + asm volatile ("tzcnt %r12w, %r8w"); - asm volatile ("mulx %eax, %ebx, %ecx"); + asm volatile ("mulx %r12d, %ebx, %ecx"); asm volatile ("mulx %ebx, %ecx, %ebx"); asm volatile ("pdep %r8, %rcx, %rbx"); asm volatile ("pext %edx, %ecx, %ebx"); asm volatile ("rorx $10, %r8, %rbx"); - asm volatile ("sarx %edx, %ebx, %eax"); - asm volatile ("shlx %eax, %ecx, %ebx"); - asm volatile ("shrx %r8d, %eax, %ecx"); + asm volatile ("sarx %edx, %ebx, %r12d"); + asm volatile ("shlx %r12d, %ecx, %ebx"); + asm volatile ("shrx %r8d, %r12d, %ecx"); asm volatile ("bzhi %edx, %ebx, %r8d"); - asm volatile ("bzhi %rax, %rcx, %r8"); + asm volatile ("bzhi %r12, %rcx, %r8"); return 0; /* end bmi_test */ } diff --git a/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp b/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp index 5d65245db39..a5b0e6612aa 100644 --- a/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp +++ b/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp @@ -1201,7 +1201,7 @@ gdb_test "finish" "Run till exit from.*convert_test.*" \ gdb_test_no_output \ "set \$r8 = 0" "set r8 for bmi test" gdb_test_no_output \ - "set \$eax = 0x1312" "set eax for bmi test" + "set \$r12 = 0x1312" "set r12 for bmi test" gdb_test_no_output "set \$ebx = 0xdeadbeef" "set ebx for bmi test" gdb_test_no_output "set \$ecx = 0xcafeface" "set ecx for bmi test" gdb_test_no_output "set \$edx = 0x2337" "set edx for bmi test" @@ -1213,7 +1213,7 @@ if {[record_full_function "bmi"] == true} { test_one_general_register "shrx" "ecx" "0xe884173" test_one_general_register "shlx" "ebx" "0x0" - test_one_general_register "sarx" "eax" "0x3" + test_one_general_register "sarx" "r12" "0x3" test_one_general_register "rorx" "ebx" "0x3b" test_one_general_register "pext" "ebx" "0x0" test_one_general_register "pdep" "ebx" "0x0" @@ -1232,13 +1232,13 @@ if {[record_full_function "bmi"] == true} { test_one_general_register "blsr" "ecx" "0x2" test_one_general_register "blsr" "ebx" "0xffffffff" - test_one_general_register "blsmsk" "eax" "0x1312" + test_one_general_register "blsmsk" "r12" "0x1312" test_one_general_register "blsmsk" "ebx" "0x0" test_one_general_register "blsi" "r8" "0x0" test_one_general_register "blsi" "ecx" "0xdeadaced" - test_one_general_register "bextr" "eax" "0x1312" + test_one_general_register "bextr" "r12" "0x1312" test_one_general_register "bextr" "ebx" "0xdeadbeef" test_one_general_register "andn" "ecx" "0xcafeface" base-commit: a80fede20bc1330eca5e419392c6595bb3a6ac1d -- 2.55.0