From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id O8SIOAOOc2rjrQoAWB0awg (envelope-from ) for ; Wed, 05 Aug 2026 15:24:51 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=llsEAmAc; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D14151E09B; Wed, 05 Aug 2026 15:24:51 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E520B1E09B for ; Wed, 05 Aug 2026 15:24:50 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 93EAD4B99F50 for ; Wed, 5 Aug 2026 19:24:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 93EAD4B99F50 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=llsEAmAc Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [IPv6:2607:f8b0:4864:20::232]) by sourceware.org (Postfix) with ESMTPS id 059374B9DB63 for ; Wed, 5 Aug 2026 19:24:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 059374B9DB63 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 059374B9DB63 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::232 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1785957866; cv=none; b=OWgPugVuVvzO+0yR2omQmbbOKc0Lo0epdc/gMku+a0FJDJUpYYVpVeq9hkCFcFEswUWEDTa1o1VFyrETKcWFztOV+rkFD7eWMZanepjiUPfAR9P3IXVzE9P5dcsy+90D2qquZcRM93ZJX7LDYS7J3fThvVcm7nxNv3oLs1TyOk0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1785957866; c=relaxed/simple; bh=uqnLDXuWbxQncOh4p4UNHY41gnIR5eUQo4mo44CNATw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=amZqQ4DZbwi7ySibm5jNd6iAFM4kJr+0vETA3ERsrdLs71qkNPnDL3ROixjsM0FvhrljGZkhcN6LIypuaelDn724MqXt1AgG34pF/oDaIt6r7gaI7pgDuZyTFt/2TFQ9J4FKOENxHANrWbHaySGtbYAKCxwHd2mIVWOvVikEbsk= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=llsEAmAc DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 059374B9DB63 Received: by mail-oi1-x232.google.com with SMTP id 5614622812f47-4a40bcc8d69so897196b6e.3 for ; Wed, 05 Aug 2026 12:24:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1785957865; x=1786562665; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=FesFe50oqnDQHCI6hbkGeW+vKO/MFpU25VO+NsOeyII=; b=llsEAmAcSgIVqz3wCpuUqKbqgQejNp2StFycy2ubdrY3oPYi/477D8IcnZ40/YBabv 5NpEMHQecoryuzfRnLTMNCRDyvLb2LMZSDCgL2eeqWMkad2awuXatbvz681WbpDupm1u Ebft9Oievj0/dV0dDYzCUk06ykPQeNIjkZtRAz9hz/boi3LjiVdHNfJbHN2V5vc4oHO2 JnN85QoRA/4lj/AAZhdg+MQYyou/97fazgWJOkoBplkpDI8U7Ob8xsHltouvV0Pivd00 d8J/ET+jRlalEGuGuFJSUCXJ+SppbCXs5YaDQ2hLZaJfVEn5gw+iXDa5U5PG54PswPOh Xtnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785957865; x=1786562665; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FesFe50oqnDQHCI6hbkGeW+vKO/MFpU25VO+NsOeyII=; b=myBgCJidVELxF7WSJ+NeroIKDMrnt9Rt2tNUOp+zZVwBwMyhnY9VXEkeGiKBT0+N0b tm6Ccjc1EyDkIUpeaxM80R4uc1ISgapo48YDC4zjUXWMvw43PrizSxOyAP3hMOkVvixp Fel9s08DMFRQ+4Ua1IP4yXRw20ebrR1lLlSAiGle3z2zOdSWIpezTRhtE833/dhyR3LY hkv5l7bsuCKmUnW/I07XqQE1jJkZe4vT9U3VC2aBtVPJXX7UgQzpY3sk6twVsIAPp+tQ yAQW4jEJ6pHnQcD97i+n3jUNkDbkcTaX6XxA3DKOPRaZbWvzf8AdfgsgW7vvUMI9jGJs mhvQ== X-Gm-Message-State: AOJu0YzFTaH2kbw88PrQcbyO7xqbuBpLaenPXWFBSyML2VoYKjSx1E5S /G0JIb3A4blN172THxghS9oCgB/DgBb8J1u7qE0LucDqMKyW1Tjnrqdhg3K4baCV+1Qaz5B/cAS 6tm4= X-Gm-Gg: AR+sD10lwQDqI4WZ2lY5OzGge2a8BNKflcBGTGsXA2ET504rXy8d6xGIonKSHzhgouG mia7HRLQoeRclBrARI/5Ud4s8AlStEdfcIShHRSujI02ZHEuhaJp+/xqknnMPUYGtQpS2XBx4Tm JO8se2nfPyBBbVXXd/QXvVV5T6dJOkdEZYtuNYaMEcEyLijgaQ9selvc3eao+M9IqSG88WSH/Rd vefdy2x4+t0GvFfbo3eA9hx9ROZ7ofaRLQIrGlOUGavJLsV4j6NfGNZrjo3MtDZS6H1Bx49QtO4 SyUQeNSDcXwInO2ACy7hbN49iwOI0aJU0hNMiSbWJ77uKDs/HDgkseMwkop0wbyXUshxZUg7Fcc DvWJGvzCFOkn3AUs7SQjiOTDTKQq9kveDceBqUn0HQ/hkn9Cc4DBYtKoJEnDI9KjTjsIelSIke9 sJQFseIcJBAfalQjrwCIf/xdF2CswK/fp5ACtX9zT3AXcY3ZNuwgqhJdBZWE4HK+YanfgSlMxFL J0W3cEQ X-Received: by 2002:a05:6808:1514:b0:492:3ed0:9073 with SMTP id 5614622812f47-4afadd321ccmr5075962b6e.4.1785957865262; Wed, 05 Aug 2026 12:24:25 -0700 (PDT) Received: from bapiya (75-166-225-82.hlrn.qwest.net. [75.166.225.82]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4afae458389sm2702338b6e.2.2026.08.05.12.24.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 12:24:24 -0700 (PDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Minor 'debug_*' function improvements Date: Wed, 5 Aug 2026 13:24:22 -0600 Message-ID: <20260805192422.3038043-1-tromey@adacore.com> X-Mailer: git-send-email 2.55.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I wanted to get a summary of a type in gdb and then realized I had forgotten the function name, so I had to dig around to find it. This made me think that perhaps renaming the debug_* functions to all just be named 'debug' would be an improvement, since it's easier to remember. Then I noticed that debug_type and debug_val don't print a trailing newline. Finally, I needed to be able to see the contents of a gdb_mpz. --- gdb/expprint.c | 4 ++-- gdb/gmp-utils.c | 12 ++++++++++++ gdb/typeprint.c | 5 +++-- gdb/valprint.c | 5 +++-- 4 files changed, 20 insertions(+), 6 deletions(-) diff --git a/gdb/expprint.c b/gdb/expprint.c index bc1929b1a1b..4859d48f6a4 100644 --- a/gdb/expprint.c +++ b/gdb/expprint.c @@ -35,13 +35,13 @@ /* Meant to be used in debug sessions, so don't export it in a header file. */ -extern void ATTRIBUTE_USED debug_exp (struct expression *exp); +extern void ATTRIBUTE_USED debug (struct expression *exp); /* Print EXP. */ void ATTRIBUTE_USED -debug_exp (struct expression *exp) +debug (struct expression *exp) { exp->dump (gdb_stdlog); gdb_flush (gdb_stdlog); diff --git a/gdb/gmp-utils.c b/gdb/gmp-utils.c index 168479c50df..f681752a956 100644 --- a/gdb/gmp-utils.c +++ b/gdb/gmp-utils.c @@ -39,6 +39,18 @@ gmp_string_printf (const char *fmt, ...) return str; } +/* Meant to be used in debug sessions, so don't export it in a header file. */ +extern void ATTRIBUTE_UNUSED debug (const gdb_mpz &); + +/* Print VAL. */ + +void ATTRIBUTE_UNUSED +debug (const gdb_mpz &val) +{ + gdb_printf (gdb_stdlog, "%s\n", val.str ().c_str ()); + gdb_flush (gdb_stdlog); +} + /* See gmp-utils.h. */ void diff --git a/gdb/typeprint.c b/gdb/typeprint.c index 31a9c1814a3..9177f5808f7 100644 --- a/gdb/typeprint.c +++ b/gdb/typeprint.c @@ -516,14 +516,15 @@ ptype_command (const char *type_name, int from_tty) } /* Meant to be used in debug sessions, so don't export it in a header file. */ -extern void ATTRIBUTE_UNUSED debug_type (struct type *type); +extern void ATTRIBUTE_UNUSED debug (struct type *type); /* Print TYPE. */ void ATTRIBUTE_UNUSED -debug_type (struct type *type) +debug (struct type *type) { type_print (type, "", gdb_stdlog, 1); + gdb_printf (gdb_stdlog, "\n"); gdb_flush (gdb_stdlog); } diff --git a/gdb/valprint.c b/gdb/valprint.c index 50a4663ca3b..dbfcbf8fad4 100644 --- a/gdb/valprint.c +++ b/gdb/valprint.c @@ -1232,14 +1232,15 @@ value_print (struct value *val, struct ui_file *stream, } /* Meant to be used in debug sessions, so don't export it in a header file. */ -extern void ATTRIBUTE_UNUSED debug_val (struct value *val); +extern void ATTRIBUTE_UNUSED debug (struct value *val); /* Print VAL. */ void ATTRIBUTE_UNUSED -debug_val (struct value *val) +debug (struct value *val) { value_print (val, gdb_stdlog, &user_print_options); + gdb_printf (gdb_stdlog, "\n"); gdb_flush (gdb_stdlog); } base-commit: b7da195b94b423e5cfd27a14c636ffe9f7380cdd -- 2.55.0