From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8qTcE8UfcGrKPwEAWB0awg (envelope-from ) for ; Mon, 03 Aug 2026 00:57:41 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=KxD9yn/7; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3FAD61E09E; Mon, 03 Aug 2026 00:57:41 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8941B1E033 for ; Mon, 03 Aug 2026 00:57:40 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 23E874BAE7F0 for ; Mon, 3 Aug 2026 04:57:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 23E874BAE7F0 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=KxD9yn/7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 033B14BA23E8 for ; Mon, 3 Aug 2026 04:57:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 033B14BA23E8 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 033B14BA23E8 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1785733037; cv=none; b=cIRvGfAmPxeNnQNHSV1WT6JCCIu14wAaqj2PnkFjmS2s7Y+YGGByeWwQw/HqN+jDzKg6KcuF0W9hLj9cM3bLuTJmmNe5nea8L7SCKpccVjYkz9xieU5bE6JPv/u1UWwCDBu3FLwNM3geFLCJvL+Aq20NACllfuo7EkrcCXc52wE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1785733037; c=relaxed/simple; bh=tQ/sw32Wy6CVb26m2OQ66vTB4WEtytk+zDTA5RKivTg=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=P9pBJtNudkGa5CXvxxBGjdAH2MH6qfpU8s/+pag1Mvgx9+IXWyGktjmEGCMk1X7rkoBcVnPqE3DXmd6ays6h66CCT42ubEv9qKwzy2UbyyZSknQQiLCHzMVzIFmdR3F8noZ9Wx0tbuwzPuneU2kWgJv3TO5WFTCAeqpzFrMWbdc= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=KxD9yn/7 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 033B14BA23E8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785733036; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HKHWYHZDQ1LzccvXw/Q/7sAjm+FfUxn8ssUxx9riSv0=; b=KxD9yn/7TaO7WhrIW4uz1IX54eQgneLhPnJncwKj1IBJj6e7jVwq2MvHuKOKvE1z4olO7b CZ/QvPOxtldE9lvkxBJJ4aTejBMH9xEXyzzZWL2Q26Fr9SwKNxmd9iTCeTGxtz2bHUAIDU lRkJy6FeuhVAdt10HEHJeJ+M3cVPJcs= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-5-J_r-MnKMPCqKSzF-GrpChQ-1; Mon, 03 Aug 2026 00:57:09 -0400 X-MC-Unique: J_r-MnKMPCqKSzF-GrpChQ-1 X-Mimecast-MFC-AGG-ID: J_r-MnKMPCqKSzF-GrpChQ_1785733028 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 93B57180047F; Mon, 3 Aug 2026 04:57:08 +0000 (UTC) Received: from f44-mesa-1 (unknown [10.22.88.9]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D88A730001A2; Mon, 3 Aug 2026 04:57:07 +0000 (UTC) Date: Sun, 2 Aug 2026 21:57:04 -0700 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Tom de Vries Subject: Re: [PATCH 2/2] [gdb/testsuite] Fix gdb.base/msym-lang.exp on ppc64-linux Message-ID: <20260802215704.0a3f2050@f44-mesa-1> In-Reply-To: <20260802093421.794182-3-tdevries@suse.de> References: <20260802093421.794182-1-tdevries@suse.de> <20260802093421.794182-3-tdevries@suse.de> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: _fo42DheeF_iiUFPVCCmr_gd96VJ56G2DpiSaO_UYPw_1785733028 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Sun, 2 Aug 2026 11:34:21 +0200 Tom de Vries wrote: > On x86_64-linux, with test-case gdb.base/msym-lang.exp we get: > ... > (gdb) info func foo > All functions matching regular expression "foo": > > Non-debugging symbols: > 0x0000000000401116 foo() > 0x000000000040112c foo() > (gdb) PASS: $exp: info func foo > ... > > But on ppc64-linux, we get: > ... > (gdb) info func foo > All functions matching regular expression "foo": > > Non-debugging symbols: > 0x0000000000000914 .foo() > 0x0000000000000974 .foo() > (gdb) FAIL: $exp: info func foo > ... > > The dot prefix is due to the function descriptors used in the PPC v1 ABI. > > Fix this by allowing the dot prefix. > > Tested on x86_64-linux and ppc64-linux. > --- > gdb/testsuite/gdb.base/msym-lang.exp | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.base/msym-lang.exp b/gdb/testsuite/gdb.base/msym-lang.exp > index d0beddea417..38521e4ebf7 100644 > --- a/gdb/testsuite/gdb.base/msym-lang.exp > +++ b/gdb/testsuite/gdb.base/msym-lang.exp > @@ -20,4 +20,11 @@ if {[prepare_for_testing "failed to prepare" $testfile [list $srcfile $srcfile2] > return > } > > -gdb_test "info func foo" ".* foo\\(\\).* foo\\(\\).*" > +# The optional leading dot is for ppc64 v1 ABI function descriptors. > +set re_foo [quotemeta {@/[.]?/foo()}] > + > +gdb_test "info func foo" \ > + [multi_line \ > + "Non-debugging symbols:" \ > + "$hex $re_foo" \ > + "$hex $re_foo"] > -- > 2.51.0 > LGTM. Approved-By: Kevin Buettner