From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id V/VoKn8ecGqmPAEAWB0awg (envelope-from ) for ; Mon, 03 Aug 2026 00:52:15 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Nv+O/05n; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9FFC11E09E; Mon, 03 Aug 2026 00:52:15 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1B2111E033 for ; Mon, 03 Aug 2026 00:52:15 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 500C34BB1C00 for ; Mon, 3 Aug 2026 04:52:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 500C34BB1C00 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Nv+O/05n Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 6B2A04BA23E4 for ; Mon, 3 Aug 2026 04:51:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6B2A04BA23E4 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6B2A04BA23E4 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1785732709; cv=none; b=K/UZP4M6b0HARPfIisfQMPvkH/X0lR+6IcdrONNmVYXGeZQVRCN1wmxGyDWxxDxyQL0bVZMO5GEyyhzFxfJY3pdt6TmNMym7EdPOj5xC5sIl/K0hP7WOrCrBC7yhfu8jTRKm5on/Z75MMpI92X+XezReY3mwtnhQzJ54AgGY8VI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1785732709; c=relaxed/simple; bh=59FmfTs40792jFcBSqUNemVYOBFs9HlFrMOk3mTXSeg=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=S7lcc0w7LjKjOLA53DkQL/oNPKFJ81QcjDjZonYW4v+Tjo/Zyt/HHRIQ3pFDxNhkOVoy3CFmi7DRbTl6F/a8o0XPLxTtYSKAyTHxPOpJ2TKGwEECI7XQOw65PYyXhb3dfqJY53AuuUzSV81CCJf/aav9Am1POdn2Iu2xXVZuUvY= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Nv+O/05n DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6B2A04BA23E4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785732709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3eZ268+RDN3fSNv/dQSpYgz1Qn7/+N75tonliFsrl48=; b=Nv+O/05nt27x2PR/vuNqesLPh4wfy2hSmD4wjys9f5rcMnvrq6M60U6vVXfaXf36B8YmAQ fPFFR6Rdb/V+YuPrcsrWbohYqWMn8ZN/seFfjdc3bIGASQKibrtdVnvxCLi968fvZQsXRQ HU4tHJLuGFYJr+LQS4U24F4UnYRZB5o= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-340-QMaBiZd3OSeei7_oRy94mA-1; Mon, 03 Aug 2026 00:51:40 -0400 X-MC-Unique: QMaBiZd3OSeei7_oRy94mA-1 X-Mimecast-MFC-AGG-ID: QMaBiZd3OSeei7_oRy94mA_1785732699 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 630021800370; Mon, 3 Aug 2026 04:51:39 +0000 (UTC) Received: from f44-mesa-1 (unknown [10.22.88.9]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7E60F30001A2; Mon, 3 Aug 2026 04:51:38 +0000 (UTC) Date: Sun, 2 Aug 2026 21:51:35 -0700 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Tom de Vries Subject: Re: [PATCH 1/2] [gdb/testsuite] Fix gdb.base/examine-address-class.exp for big endian Message-ID: <20260802215135.37d2c18f@f44-mesa-1> In-Reply-To: <20260802093421.794182-2-tdevries@suse.de> References: <20260802093421.794182-1-tdevries@suse.de> <20260802093421.794182-2-tdevries@suse.de> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: B0gIpIUCm7WGp1JDQS1czO9BI1wcrYZ-UgfBIjALf3w_1785732699 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi Tom, LGTM except for one typo in the commit log... On Sun, 2 Aug 2026 11:34:20 +0200 Tom de Vries wrote: > On ppc64-linux and s390x-linux, with test-case > gdb.base/examine-address-class.exp I get: > ... > (gdb) x/1dh (int *) &var^M > 0x3fffffffe560: 0^M > (gdb) FAIL: $exp: x/1dh (int *) &var > ... > > This is caused by big vs. little endian. > > On x86_64-linux (little endian), we have: > ... > (gdb) p /x ((short *)&var)[0] > $6 = 0x2a > (gdb) p /x ((short *)&var)[1] > $7 = 0x0 > (gdb) > ... > > And on ppc64-linux (big endian), we have: > ... > (gdb) p /x ((short *)&var)[0] > $2 = 0x0 > (gdb) p /x ((short *)&var)[1] > $3 = 0x2a > ... > > Fix this by assigning 0x002a0x002a to var, making sure that There's a '0x' in the middle of that constant. The code shows it correctly as 0x002a002a. > ((short *)&var)[0] == ((short *)&var)[1] == 42. > > Tested on x86_64-linux, ppc64-linux and s390x-linux. > --- > gdb/testsuite/gdb.base/examine-address-class.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.base/examine-address-class.c b/gdb/testsuite/gdb.base/examine-address-class.c > index c868b10119f..8f6b89c14bf 100644 > --- a/gdb/testsuite/gdb.base/examine-address-class.c > +++ b/gdb/testsuite/gdb.base/examine-address-class.c > @@ -18,6 +18,6 @@ > int > main (void) > { > - int var = 42; > + int var = 0x002a002a; > return 0; /* break-here. */ > } > -- > 2.51.0 With the typo fixed: Approved-By: Kevin Buettner