From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Yi5YL5PmbWpXTzsAWB0awg (envelope-from ) for ; Sat, 01 Aug 2026 08:29:07 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=UMaD2kEe; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=yqTDdjSx; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=S6Qiv6hb; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=EQPEM3r8; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 72D161E099; Sat, 01 Aug 2026 08:29:07 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7079D1E099 for ; Sat, 01 Aug 2026 08:29:06 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0857F4BA9021 for ; Sat, 1 Aug 2026 12:29:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0857F4BA9021 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=UMaD2kEe; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=yqTDdjSx; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=S6Qiv6hb; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=EQPEM3r8 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 4168E4BA901C for ; Sat, 1 Aug 2026 12:28:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4168E4BA901C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4168E4BA901C Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1785587322; cv=none; b=F3BeRsDSX/KAeSgx1XZw8ZkTouPNf9u9zde22g55CZSu5UA3brpzOcJo2EXNA1EZKNYwIhcYuH2lf/cJxO9tSNu18nz0lRDsxmbLG14ezTSfXz+x6krRfBBtHXVvOAPkju866N+sg5XPKxMWDBWLpTuKuUeq6gtswLbNflAJtdg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1785587322; c=relaxed/simple; bh=pIldJQnLmv1rONn0D3ED66SCpmfog1ASs50m2FVmm7A=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=Usflw4bSv2uYi9b1YvsgJOLnH0K+F9u1qiKDZ+JQwszPfNYLTtAPa8G05oyiyvVlI7G3gNK2g2MvnVlZgtologAAbnS2PC15sfKSmtxmlnLCBD1mpaRdf37HLxTqcC4Y6Mo3waawh6B/q8zLnmTUKg3WzWcIq6wJKb8olWYQqes= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=UMaD2kEe; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=yqTDdjSx; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=S6Qiv6hb; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=EQPEM3r8 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4168E4BA901C Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 18BC23EF2 for ; Sat, 1 Aug 2026 12:28:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1785587317; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=60QGDqtq1MA7mi4V4qHvOS6Nm7F9aGcHlmpg/OmlAmY=; b=UMaD2kEeFb21abNncpShTM7KCr61ls5DKbQlmt8zhxasdTLdPzwgT1b+v1ONQZqgRXeRrr M2yIL2rtsm+Z4GPA8+2TvDiuEximH5fxtp2JjKlbzTU1GK6xZyWRW1oqnYDtblgFToTeZ+ 9F34imp/NkX9G7a4ar1fqNC08qSlueA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1785587317; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=60QGDqtq1MA7mi4V4qHvOS6Nm7F9aGcHlmpg/OmlAmY=; b=yqTDdjSx1+hwVqUxzeP1qi8E4DSYzJJFgHMUqWxIWm3DjdSvgqbgByv5qjOz7Z7cfZZLR3 1icOYdaLOw2furCA== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1785587313; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=60QGDqtq1MA7mi4V4qHvOS6Nm7F9aGcHlmpg/OmlAmY=; b=S6Qiv6hbRIP+enSRHH16/DVV1fgS3JH9fLPLQu4xFAk+o4+/n04ssB5ExTlPoTaNKdsuxV uHODsOZl6m8Jt9qyBXYBjUuS01wKCQkGq0Y6Y4u3i3v4xVDo+2a1j05EvpD5oWioG75Pvd PIDDIZPapj2WHFA/KctsSNNfbSFkm9Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1785587313; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=60QGDqtq1MA7mi4V4qHvOS6Nm7F9aGcHlmpg/OmlAmY=; b=EQPEM3r8giP/lZnwnd5XdrfFgSP6QIwyDRMnUTib02/+ciSMqkqgN214D33cyk0q0Hc1z/ 2oqXCocndd9qm9Bg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 03374779BF for ; Sat, 1 Aug 2026 12:28:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id WAcLO3DmbWqhSQAAD6G6ig (envelope-from ) for ; Sat, 01 Aug 2026 12:28:32 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH] [gdb/tui] Fix gdb.tui/list-before.exp on ppc64-linux Date: Sat, 1 Aug 2026 14:28:32 +0200 Message-ID: <20260801122832.3152974-1-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; URIBL_BLOCKED(0.00)[suse.de:mid,imap1.dmz-prg2.suse.org:helo]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; FROM_EQ_ENVFROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, suse.de:mid, gdb.tui:url] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On ppc64-linux, with test-case gdb.tui/list-before.exp I run into: ... (gdb) tui enable^M ... (gdb) Screen Dump (size 80 columns x 24 rows, cursor at column 6, row 16): 0 +------------------------------------------------------------------------------+ 1 | | 2 | | 3 | | 4 | | 5 | | 6 | | 7 | [ No Source Available ] | 8 | | 9 | | 10 | | 11 | | 12 | | 13 | | 14 +------------------------------------------------------------------------------+ 15 exec No process (src) In: L?? PC: ?? 16 (gdb) 17 18 19 20 21 22 23 FAIL: $exp: initial source listing ... The problem is in tui_get_begin_asm_address, where we look up the minimal symbol for main, and use its address. With the v1 ABI, we don't get the address of main in the .text section: ... 00000000000008b4 <.main>: 8b4: fb e1 ff f8 std r31,-8(r1) 8b8: f8 21 ff c1 stdu r1,-64(r1) 8bc: 7c 3f 0b 78 mr r31,r1 ... but the address of the descriptor of main in the .opd section: ... 000000000001fee8
: 1fee8: 00 00 00 00 .long 0x0 1feec: 00 00 08 b4 .long 0x8b4 1fef0: 00 00 00 00 .long 0x0 1fef4: 00 02 7f 00 .long 0x27f00 ... Fix this by using gdbarch_convert_from_func_ptr_addr, similar to how that's used in create_internal_breakpoint. Tested on ppc64-linux and x86_64-linux. --- gdb/tui/tui-disasm.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/tui/tui-disasm.c b/gdb/tui/tui-disasm.c index 5c68312a91b..68a5c425934 100644 --- a/gdb/tui/tui-disasm.c +++ b/gdb/tui/tui-disasm.c @@ -409,7 +409,11 @@ tui_get_begin_asm_address (struct gdbarch **gdbarch_p, CORE_ADDR *addr_p) bound_minimal_symbol main_symbol = lookup_minimal_symbol (current_program_space, main_name ()); if (main_symbol.minsym != nullptr) - addr = main_symbol.value_address (); + { + addr = main_symbol.value_address (); + addr = gdbarch_convert_from_func_ptr_addr + (gdbarch, addr, current_inferior ()->top_target ()); + } } } else /* The target is executing. */ base-commit: 5b805c95e9399e35f7bc895ec5b67aabdbc6ce41 -- 2.51.0